Use 全国地方公共団体コード for Order #223
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yasulab
changed the title
yasulab
changed the title
0 means octal number in Ruby, which breaks when sorting: e.g. puts 010 => 8
yasulab
force-pushed
the
use-code-for-order
branch
2 times, most recently
from
a2266ec to
87567c0
Compare
Some Japanese codes for regions start with 0. We should compare as String rather than Integer. cf. #219
yasulab
force-pushed
the
use-code-for-order
branch
from
87567c0 to
293ac4f
Compare
yasulab
commented
Dec 11, 2017
| d.description = dojo['description'] | ||
| d.logo = dojo['logo'] | ||
| d.tags = dojo['tags'] | ||
| d.url = dojo['url'] | ||
| d.created_at = dojo['createdAt'] ? Time.zone.parse(dojo['createdAt']) : Time.zone.now | ||
| d.created_at = d.new_record? ? Time.zone.now : d.created_at |
There was a problem hiding this comment.
Issue とは関係ないですが created_at が更新されてしまうバグを見つけたのでついでに直しました 🐛 🔍
|
@nalabjp 全国地方公共団体コードを |
|
.oO(CoderDojo 御茶ノ水からの申請が先ほどあったので、ついでにこのコミットに載せちゃいますね。master にコミットすると conflict しそうなので ><) |
|
手元で動かして問題なさそうだったので、デプロイしてみます 🚀✨ |
nalabjp
reviewed
Dec 11, 2017
| @@ -0,0 +1,6 @@ | |||
| class ChangeOrderToInteger < ActiveRecord::Migration[5.1] | |||
| def change | |||
| change_column :dojos, :order, :string, default: '000000' | |||
There was a problem hiding this comment.
rollbackが必要になった時に戻せなくなる気がします。
こんな感じでup, downするほうが良いですね。
https://github.com/coderdojo-japan/coderdojo.jp/blob/5da47bf0e2541fc11a3ed7cc36bf75dab961fb66/db/migrate/20170820090605_change_column_type_dojo_event_services.rb
There was a problem hiding this comment.
なるほど🤔 こっそり直せないか後で試してみます ><
|
良さそうに思いました😁 |
|
ですね 😆 レビューありがとうございます! 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix #219 and can be a step to automate inserting Order column (#58), which enables us to remove
orderfrom dojos.yaml.