Skip to content

Commit 63fb702

Browse files
authored
Merge pull request #218 from coderdojo-japan/includes-cop
Use `eager_load` instead of `includes`
2 parents b8bd627 + b26292f commit 63fb702

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

app/controllers/static_pages_controller.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
class StaticPagesController < ApplicationController
22
def home
33
@dojo_count = Dojo.count
4-
@regions_and_dojos = Dojo.includes(:prefecture).default_order.group_by { |dojo| dojo.prefecture.region }
4+
@regions_and_dojos = Dojo.eager_load(:prefecture).default_order.group_by { |dojo| dojo.prefecture.region }
55
end
66

77
def stats
88
@url = request.url
99
@dojo_count = Dojo.count
10-
@regions_and_dojos = Dojo.includes(:prefecture).default_order.group_by { |dojo| dojo.prefecture.region }
10+
@regions_and_dojos = Dojo.eager_load(:prefecture).default_order.group_by { |dojo| dojo.prefecture.region }
1111

1212
# TODO: 次の静的なDojoの開催数もデータベース上で集計できるようにする
1313
@sum_of_events = EventHistory.count + # 以下は2017年11月3日時点で個別に確認した数字

0 commit comments

Comments
 (0)