variantを使ってviewからロジックを排除する

zephiransas · zephiransas · commit 3f38f51e5e31 · 2017-11-07T17:24:06.000+09:00
diff --git a/app/views/static_pages/_dojos.html+smartphone.erb b/app/views/static_pages/_dojos.html+smartphone.erb
diff --git a/app/views/static_pages/_dojos.html.erb b/app/views/static_pages/_dojos.html.erb
@@ -0,0 +1,3 @@
+<ul class="loaded">
+  <%= render partial: 'dojo', collection: @regions_and_dojos.values.flatten %>
+</ul>
diff --git a/app/views/static_pages/home.html.erb b/app/views/static_pages/home.html.erb
@@ -84,13 +84,9 @@
   <br />
   <h2>全国の道場</h2>
   <br />
-  <% if request.from_smartphone? %>
-    <%= render 'dojos_by_region', locals: { regions_and_dojos: @regions_and_dojos } %>
-  <% else %>
-    <ul class="loaded">
-      <%= render partial: 'dojo', collection: @regions_and_dojos.values.flatten %>
-    </ul>
-  <% end %>
+
+  <%= render 'dojos' %>
+
 </section>
 
 <section class="text-center">

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+<ul class="loaded">`
	`2`	`+ <%= render partial: 'dojo', collection: @regions_and_dojos.values.flatten %>`
	`3`	`+</ul>`