Skip to content

Commit 8758df9

Browse files
committed
refactor: remove Extender and google-cloud
This removes the ability to extend the logger with google-cloud. It's not being used and causing issues in other projects (i.e. code-server) so we decided to remove it entirely.
1 parent fd8c8ef commit 8758df9

File tree

3 files changed

+1
-71
lines changed

3 files changed

+1
-71
lines changed

package.json

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,7 @@
1111
"types": "out/index.d.ts",
1212
"author": "Coder",
1313
"license": "MIT",
14-
"peerDependencies": {
15-
"@google-cloud/logging": "^9.2.1"
16-
},
1714
"devDependencies": {
18-
"@google-cloud/logging": "^9.2.1",
1915
"@types/mocha": "^8.2.2",
2016
"@types/node": "^12.6.8",
2117
"@typescript-eslint/eslint-plugin": "^4.22.0",

src/extender.ts

Lines changed: 0 additions & 49 deletions
This file was deleted.

src/logger.ts

Lines changed: 1 addition & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -72,11 +72,6 @@ export type Message = {
7272
tagColor: string
7373
}
7474

75-
/**
76-
* An extra function to call with a message.
77-
*/
78-
export type Extender = (msg: Message & { section?: string }) => void
79-
8075
/**
8176
* Represents a message formatted for use with something like `console.log`.
8277
*/
@@ -308,7 +303,6 @@ export class Logger {
308303
private _formatter: Formatter,
309304
private readonly name?: string,
310305
private readonly defaultFields?: FieldArray,
311-
private readonly extenders: Extender[] = [],
312306
) {
313307
if (name) {
314308
this.nameColor = this.hashStringToColor(name)
@@ -345,10 +339,6 @@ export class Logger {
345339
this.muted = true
346340
}
347341

348-
public extend(extender: Extender): void {
349-
this.extenders.push(extender)
350-
}
351-
352342
public info(fn: LogCallback): void
353343
public info(message: string, ...fields: FieldArray): void
354344
public info(message: LogCallback | string, ...fields: FieldArray): void {
@@ -409,7 +399,7 @@ export class Logger {
409399
* Each name is deterministically generated a color.
410400
*/
411401
public named(name: string, ...fields: FieldArray): Logger {
412-
const l = new Logger(this._formatter, name, fields, this.extenders)
402+
const l = new Logger(this._formatter, name, fields)
413403
if (this.muted) {
414404
l.mute()
415405
}
@@ -462,13 +452,6 @@ export class Logger {
462452
}
463453

464454
this._formatter.write(message.level)
465-
466-
this.extenders.forEach((extender) => {
467-
extender({
468-
section: this.name,
469-
...message,
470-
})
471-
})
472455
}
473456

474457
/**

0 commit comments

Comments
 (0)