Skip to content

Commit a21e454

Browse files
committed
fix: move chmod after socket listen
1 parent f4153b0 commit a21e454

File tree

1 file changed

+8
-5
lines changed

1 file changed

+8
-5
lines changed

src/node/app.ts

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -44,12 +44,15 @@ export const listen = async (server: http.Server, { host, port, socket, "socket-
4444
// [] is the correct format when using :: but Node errors with them.
4545
server.listen(port, host.replace(/^\[|\]$/g, ""), onListen)
4646
}
47-
if (socket && mode) {
48-
await fs.chmod(socket, mode).catch((err) => {
49-
util.logError(logger, "socket chmod", err)
50-
})
51-
}
5247
})
48+
49+
// NOTE@jsjoeio: we need to chmod after the server is finished
50+
// listening. Otherwise, teh socket may not have been created yet.
51+
if (socket && mode) {
52+
await fs.chmod(socket, mode).catch((err) => {
53+
util.logError(logger, "socket chmod", err)
54+
})
55+
}
5356
}
5457

5558
/**

0 commit comments

Comments
 (0)