wip: we did it

Author: jsjoeio

test/unit/node/app.test.ts

@@ -1,9 +1,10 @@
 import { logger } from "@coder/logger"
 import { promises, rmdirSync } from "fs"
 import * as http from "http"
+import * as https from "https"
 import * as path from "path"
 import { createApp, ensureAddress, handleArgsSocketCatchError, handleServerError } from "../../../src/node/app"
-import { setDefaults } from "../../../src/node/cli"
+import { OptionalString, setDefaults } from "../../../src/node/cli"
 import { getAvailablePort, tmpdir } from "../../utils/helpers"
 
 describe("createApp", () => {
@@ -137,6 +138,27 @@ describe("createApp", () => {
     rmdirSync(socketPath, { recursive: true })
     server.close()
   })
+
+  it("should create an https server if args.cert exists", async () => {
+    // No idea why we have this weird optional string thing
+    const port = await getAvailablePort()
+    const cert = new OptionalString("./test/utils/test.crt")
+    const defaultArgs = await setDefaults({
+      port,
+      cert,
+      _: [],
+      ["cert-key"]: "./test/utils/test.key",
+    })
+    const app = await createApp(defaultArgs)
+    const server = app[2]
+
+    // This doesn't check much, but it's a good sanity check
+    // to ensure we actually get back values from createApp
+    expect(server).toBeInstanceOf(https.Server)
+
+    // Cleanup
+    server.close()
+  })
 })
 
 describe("ensureAddress", () => {

test/utils/test.crt

@@ -0,0 +1,32 @@
+-----BEGIN CERTIFICATE-----
+MIIFjjCCA3YCCQCVV/TwiFnSozANBgkqhkiG9w0BAQsFADCBiDELMAkGA1UEBhMC
+VVMxDjAMBgNVBAgMBVRleGFzMQ8wDQYDVQQHDAZBdXN0aW4xDjAMBgNVBAoMBUNv
+ZGVyMRQwEgYDVQQLDAtFbmdpbmVlcmluZzESMBAGA1UEAwwJY29kZXIuY29tMR4w
+HAYJKoZIhvcNAQkBFg9oZWxsb0Bjb2Rlci5jb20wHhcNMjEwOTE1MTgyNDIwWhcN
+MzEwOTEzMTgyNDIwWjCBiDELMAkGA1UEBhMCVVMxDjAMBgNVBAgMBVRleGFzMQ8w
+DQYDVQQHDAZBdXN0aW4xDjAMBgNVBAoMBUNvZGVyMRQwEgYDVQQLDAtFbmdpbmVl
+cmluZzESMBAGA1UEAwwJY29kZXIuY29tMR4wHAYJKoZIhvcNAQkBFg9oZWxsb0Bj
+b2Rlci5jb20wggIiMA0GCSqGSIb3DQEBAQUAA4ICDwAwggIKAoICAQCoczbPZMn4
+ILxg/Vw6512NgORHpMmfxSxqRORw3VM9bnxTiq1xPqP8ol/3Bvk7PGmvlNN3alcE
+vEapyV6ceF9FxCJARBXpIqNS/tLNtAjIIiCOrBjVXTrDI8jsYIYgojDue+i/OAxA
+0CPGXXZKPH6yvpjbczHZDrG5GYchWWMzA1gzq4iiQJH1MZviQS3tSZSqw0Vn1jYK
+V4BAOkSkxS4NrevjK7bIW9Dfrly9bfJfd+YZNr0ARp46G6Ke33xxF2KYpngscEFZ
+f5RYJLevFFDs1+UGn4/YTDcGv+6yC4ftz0OuM7CZqcc8UtE9g1yIm5kCllPVptW1
+6c8K8GC3l0kCDO3X5C0cWee86Hzlb+uIdoHTsjif6l9+v/FfmiRjeEDKcgh1fEgB
+z21GFsCq6XPPU975V38AftSxQ9RBs/Zfv7Ra+fFITISgdfQWH/pETrevsr1KUEf1
+xOkEZhEuQWo4XzKSNojFHRr7lvxrCUPGt9gIr5k3frxx5mVTqKJSiyjFTrFRCQ0n
+SlNlB5GzQEzPRMqGGxT+CjXz2Sgc0n0xbxm6tORYbKRygPTwSyaiZbRJQrYP/J0K
+XsZvKyQDU5HIzI3sUK3pnMbEhM08wptbRXjBGVtZ4etYfPhOUJogZ1VnXakBQHjg
+iGWQ2Jcd56FhdrPl9V/5AqRaly895bXM7QIDAQABMA0GCSqGSIb3DQEBCwUAA4IC
+AQCoWQyoeJLXXxy74uTYM9wng5O03p0IM7fnViPtYa/5oXjX/h2e6X3ijStJ6JmL
+mUL5Z7wY9JfHCbaKlC0ZrftwGrbldAPsKK1ZjOg9lgh1ZzkL++Akept992IEH9GU
+VB2l1N87xiQs7y40bwzlMbDmV/X9P2GhgyWpcUY8s6fkbczHU0tYJnOjj9H1HAlX
+yUsq587Z9j5TwF3f+UcprqEDaqwRhCmknXMJTbNeoL5T2d5WxXqZEiWJGD364nJw
+xt+VoriCwWZclltUcBqnDheyxmWWa6SGxz2aiS2cHC14V7sgaxpe05uSumGtzLeL
+H+x8Qx9a+eyNq/miV9czK++miaLyGQRkSDE35iFWUKpa1C1BcKl53uKfYCo6u83a
+nAWr/CATnyFgVZzMEJloSvYfnuA2+klJtZ9cRV0lp4CxefR+AKnkcNtmCr71LX12
+b7XTXHw68gEQp/iVZc0cP23gaDs26KIduLez2moF+iTjqn4J77epV6vGjuj27WL3
+hK8Z7KUFqUU6DSVJ2Z/qGBw/ZP78l//o2Jbu4KFfg5UviUzrLXWfrMJw9uqgfD4c
+OiahmBsqB/9JHGFGOhQy1/F8k/7Y3k1o1hdYwNCmB7iwPJ9eklhYHCrQc/yIarZz
+Z4rwv90aq+cFtoVvrTPA0rjSu4jwo2tI/nYfdZOfcCXhcw==
+-----END CERTIFICATE-----

test/utils/test.key

@@ -0,0 +1,52 @@
+-----BEGIN PRIVATE KEY-----
+MIIJQgIBADANBgkqhkiG9w0BAQEFAASCCSwwggkoAgEAAoICAQCoczbPZMn4ILxg
+/Vw6512NgORHpMmfxSxqRORw3VM9bnxTiq1xPqP8ol/3Bvk7PGmvlNN3alcEvEap
+yV6ceF9FxCJARBXpIqNS/tLNtAjIIiCOrBjVXTrDI8jsYIYgojDue+i/OAxA0CPG
+XXZKPH6yvpjbczHZDrG5GYchWWMzA1gzq4iiQJH1MZviQS3tSZSqw0Vn1jYKV4BA
+OkSkxS4NrevjK7bIW9Dfrly9bfJfd+YZNr0ARp46G6Ke33xxF2KYpngscEFZf5RY
+JLevFFDs1+UGn4/YTDcGv+6yC4ftz0OuM7CZqcc8UtE9g1yIm5kCllPVptW16c8K
+8GC3l0kCDO3X5C0cWee86Hzlb+uIdoHTsjif6l9+v/FfmiRjeEDKcgh1fEgBz21G
+FsCq6XPPU975V38AftSxQ9RBs/Zfv7Ra+fFITISgdfQWH/pETrevsr1KUEf1xOkE
+ZhEuQWo4XzKSNojFHRr7lvxrCUPGt9gIr5k3frxx5mVTqKJSiyjFTrFRCQ0nSlNl
+B5GzQEzPRMqGGxT+CjXz2Sgc0n0xbxm6tORYbKRygPTwSyaiZbRJQrYP/J0KXsZv
+KyQDU5HIzI3sUK3pnMbEhM08wptbRXjBGVtZ4etYfPhOUJogZ1VnXakBQHjgiGWQ
+2Jcd56FhdrPl9V/5AqRaly895bXM7QIDAQABAoICAD4fJ0J60AUixXYbWa0bcCPk
+Ocu2GOlEBOo39+srpCwOl+kTRn1x9XYQx8VJHBbdY7ht8UKjw+2qJYEuEycvOSt4
+do0uzsnIjWTpNwLHd0mfVFRpYUsmc6pNgyaxPiXAyrzYk3AZkmNAn0DjbOFZx/vR
+UHv10pdS1PYHVQ9WcL/6Zse/Zcc4ettq7SsWkIJm1V3YX7s4g3ty44hMNM5zLVW8
+IzcHAwSG39Pt8KOnbXAJvqDjz/XPFUEmueVPVAw87I6RLdZtm5wO8b1D5T27B1Eh
+GYREyf6htNVXaQbeO8XW3wXaaDFzLFexzxqZXEHA6D/NAqPTQBMzY7iMB48NSs3O
+SWT1eRLe6soNnQNrFMy01bMg0k+cAM/+umSR7ByNatto+7ISk5LVawpBwBAldUsO
+50yB5lIZ4QfgqVdPFxK0Rop62LpJNcb3CK7Bxq5yyu2jyM0u4IJIlWNfCKdcHLtY
+frhGGIfsQbLCwsaztL2y/go3K0ni57QyMSQ/6FlKPS392qR4jYNVZHU61Nj+b2TG
+YH8BaS9B3Z3UG90aKvE6P1Olb5BPSqdS8rB9EmmAf9+cF/Dwa4Wvf595ezD3Z6l9
+S+navScsbQXdHmtHsB5+OmPyoLklO7pufFvPVof1YS1k6d4ZWAhOBvmBi7UhYHr6
+3VLfLeP22p+lLIvJ2rnBAoIBAQDdxals7ucxB/u8Tx7tam/lHEvHdv3CJpPKmL16
+OzYuX4TQBOkP7XY5TeYU5eSwIHu4XiiCCyFQkrf5qRzCe8zCsVKA/2Zb1VcYYeqv
+hcxeMERvw6wNgWdECfyROZdf9+J4sMs0D4mUc2o+ijiBvtrWHhE2ev3zQ2mJVtJQ
+YUoEIFYSIA+i0lsndq+vrokfNbsDVagsxhEzhAaUWN6mL6dZatpPiMP60CzvwAp4
+cDCxrPEURL3W7fBOvCmd4+6lcmikRU/iYPyCvZM4Pin2T/1t0ZZH2e19bDXsvpC+
+yUYtg2vcwbXryZpGmSnNC12tnDAEq/SHWZwUbr0O8CtMaB2RAoIBAQDCcsSx1ooQ
+3YqIy5YlNPkSK7r3H483FBw/iiXrJ7JqM+Gn6ZuhbzIKgnpc0OSbagJlV5ORLYpW
+BNws48O8NQoSRzTRP7OBUaPgeL2FOKyAx05Lmlp23uf5Rl4OnHBkOd/59AwVI42S
+XGVEWONTyGY2Zvxy/ZGdrKAo4xgfW43FBf7zGBFqRqln3ytz2YGmDGZrv3ETumVa
+1SNdjk+pBi/b/iYYJlt7YjWu7YjGMaJy7QA0NaJYu6GRIhU9fCIVW17Kml6mo8LP
+3jpf/grdCUfZfJXRw2Sulu2qDR+fqqozyrqwiz0ExtBS/Ib8PPMBEh9O4h8eYrFS
+AHWBwxJRt3udAoIBAA46uYU4yvK1bWyGsxhOpQFRUHdq5htH+GGebUHjfLV7AX2L
+YxzXgqdonSOoIIVAgE+zEuxNJIUT9OP6+tJruRag5AdM29d2l9EDr1g1wIgmlq2J
+I4f2TpbqAR+cT18j+4784PzlJlG1GhMLMVb51Pa6FSamu5aZM7NRM8tegq5DGOKu
+1fH/h0O/9MPT8g5jly0+mLzOtJnWlcl87kRBeH5fQcSqpNB5/PghHUre//DWhN1l
+D70zpSCYKB9uWYiaD6bCn76JtIn6+fA45N5eAYfDU94mWHucrtUS4Ryss2kGLqyK
+bU7Er7Zp62mxmgAirl4OXnE0ybPx6wWDWXPcllECggEAOs2QVCOIDz+gBGxk1I2n
+gOo+mTsvCT4IqOJzQyD3IIzeAfRwfypsXKdGr8jwSVuOq+0HEFFQU2EW4HBkogb8
+K7ji7SCxfTseLuT0k1QnPq6HK+/aybXxOv4ftZVzm6uw4xr9iGr/BjLw4PFslcq1
+tmAAmhm6ro8kxBihE+KRBfMhPYyav6Ps2R+xOVCel4OKea0kWg31Vrm7/y/pQTlA
+weuiw4zd/3sctvDYeu9JrC2l8SQDG4hqfMRs3fIrMIA4M1bppsVBRbFzv9HIoT2M
+P+YgPJY1XWMBLnrXhGaNICp/uKHy6v3gxCff/mnEJx++3hEdzgeUjjLbVkmSwamW
+NQKCAQEApaiKQMsddXmEu5ZALeaCoagAIG0LhQYxvmGV2s0hsqzWlPf3Rgibjw7V
+rbLJflzmQvHQcX7W7NxCLfoxbInZEVJvsg4kyNoTC9hBTtd429iV2iniec0+hKqT
+iBmUiHKlJLY3sXkO9yXmyBB8eWi3lBV19ylmHbAknSJI+XWDAeCl0uYOB2SLqFCE
+9xhVrZbl/od6+CjrI8gDIzNEkxaR3H7OaRl7rRVeYP/LWSFNYM5Xk3th2ho42jz4
+XnoVZKOLLVbFT+uqWCcxUxt1T0hMYh8FW1B2zjILHxEYnzmCyPxGk1QcRon4lK7l
+Tg+GmU9QQHC8AIKkHqHsjger8K9paw==
+-----END PRIVATE KEY-----