Skip to content

Commit 2a096ab

Browse files
committed
its working!
1 parent d809ecc commit 2a096ab

File tree

3 files changed

+12
-89
lines changed

3 files changed

+12
-89
lines changed

test/unit/node/app.test.ts

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import { createApp, ensureAddress, handleArgsSocketCatchError, handleServerError
77
import { OptionalString, setDefaults } from "../../../src/node/cli"
88
import { getAvailablePort, tmpdir } from "../../utils/helpers"
99

10-
// wip: todo@jsjoeio fix this
10+
// wip: todo@jsjoeio fix
1111
const FAKE_CRT = `-----BEGIN CERTIFICATE-----
1212
MIIFjjCCA3YCCQCVV/TwiFnSozANBgkqhkiG9w0BAQsFADCBiDELMAkGA1UEBhMC
1313
VVMxDjAMBgNVBAgMBVRleGFzMQ8wDQYDVQQHDAZBdXN0aW4xDjAMBgNVBAoMBUNv
@@ -39,7 +39,8 @@ b7XTXHw68gEQp/iVZc0cP23gaDs26KIduLez2moF+iTjqn4J77epV6vGjuj27WL3
3939
hK8Z7KUFqUU6DSVJ2Z/qGBw/ZP78l//o2Jbu4KFfg5UviUzrLXWfrMJw9uqgfD4c
4040
OiahmBsqB/9JHGFGOhQy1/F8k/7Y3k1o1hdYwNCmB7iwPJ9eklhYHCrQc/yIarZz
4141
Z4rwv90aq+cFtoVvrTPA0rjSu4jwo2tI/nYfdZOfcCXhcw==
42-
-----END CERTIFICATE-----`
42+
-----END CERTIFICATE-----
43+
`
4344

4445
const FAKE_KEY = `-----BEGIN PRIVATE KEY-----
4546
MIIJQgIBADANBgkqhkiG9w0BAQEFAASCCSwwggkoAgEAAoICAQCoczbPZMn4ILxg
@@ -92,7 +93,8 @@ iBmUiHKlJLY3sXkO9yXmyBB8eWi3lBV19ylmHbAknSJI+XWDAeCl0uYOB2SLqFCE
9293
9xhVrZbl/od6+CjrI8gDIzNEkxaR3H7OaRl7rRVeYP/LWSFNYM5Xk3th2ho42jz4
9394
XnoVZKOLLVbFT+uqWCcxUxt1T0hMYh8FW1B2zjILHxEYnzmCyPxGk1QcRon4lK7l
9495
Tg+GmU9QQHC8AIKkHqHsjger8K9paw==
95-
-----END PRIVATE KEY-----`
96+
-----END PRIVATE KEY-----
97+
`
9698

9799
describe("createApp", () => {
98100
let spy: jest.SpyInstance
@@ -216,7 +218,10 @@ describe("createApp", () => {
216218
server.close()
217219
})
218220
it("should catch errors thrown when unlinking a socket", async () => {
219-
const socketPath = `${tmpFilePath}-doesnt-exist`
221+
const tmpDir2 = await tmpdir("unlink-socket-error")
222+
const tmpFile = path.join(tmpDir2, "unlink-socket-file")
223+
// await promises.writeFile(tmpFile, "")
224+
const socketPath = tmpFile
220225
const defaultArgs = await setDefaults({
221226
_: [],
222227
socket: socketPath,
@@ -229,10 +234,12 @@ describe("createApp", () => {
229234
expect(spy).toHaveBeenCalledWith(`ENOENT: no such file or directory, unlink '${socketPath}'`)
230235

231236
server.close()
237+
// Ensure directory was removed
238+
rmdirSync(tmpDir2, { recursive: true })
232239
})
233240

234241
it("should create an https server if args.cert exists", async () => {
235-
const cert = new OptionalString(certKeyPath)
242+
const cert = new OptionalString(certPath)
236243
const defaultArgs = await setDefaults({
237244
port,
238245
cert,

test/utils/test.crt

Lines changed: 0 additions & 32 deletions
This file was deleted.

test/utils/test.key

Lines changed: 0 additions & 52 deletions
This file was deleted.

0 commit comments

Comments
 (0)