Reseted branch commit

Author: belingueres

README.md

@@ -1,5 +1,7 @@
 Plexus-Interpolation
 ===============
 
+[![Build Status](https://travis-ci.org/codehaus-plexus/plexus-interpolation.svg?branch=master)](https://travis-ci.org/codehaus-plexus/plexus-interpolation)
+
 Components for interpolating `${}` strings and the like.
 

pom.xml

@@ -8,7 +8,7 @@
   </parent>
 
   <artifactId>plexus-interpolation</artifactId>
-  <version>1.24-SNAPSHOT</version>
+  <version>1.25-SNAPSHOT</version>
   <packaging>bundle</packaging>
 
   <name>Plexus Interpolation API</name>
@@ -17,7 +17,7 @@
     <connection>scm:git:git@github.com:codehaus-plexus/plexus-interpolation.git</connection>
     <developerConnection>scm:git:git@github.com:codehaus-plexus/plexus-interpolation.git</developerConnection>
     <url>http://github.com/codehaus-plexus/plexus-interpolation</url>
-    <tag>HEAD</tag>
+    <tag>plexus-interpolation-1.24</tag>
   </scm>
 
   <issueManagement>

src/main/java/org/codehaus/plexus/interpolation/EnvarBasedValueSource.java

@@ -110,5 +110,14 @@ public Object getValue( String expression )
 
         return envars.getProperty( expr );
     }
+ 
+    /**
+     * reset static variables acting as a cache for testing purposes only
+     */
+    static void resetStatics()
+    {
+        envarsCaseSensitive = null;
+        envarsCaseInsensitive = null;
+    }
 
 }

src/main/java/org/codehaus/plexus/interpolation/InterpolatorFilterReader.java

@@ -138,7 +138,7 @@ public InterpolatorFilterReader( Reader in, Interpolator interpolator, String be
      */
     public InterpolatorFilterReader( Reader in, Interpolator interpolator, RecursionInterceptor ri )
     {
-        this( in, interpolator, DEFAULT_BEGIN_TOKEN, DEFAULT_END_TOKEN, new SimpleRecursionInterceptor() );
+        this( in, interpolator, DEFAULT_BEGIN_TOKEN, DEFAULT_END_TOKEN, ri );
     }
 
     /**

src/main/java/org/codehaus/plexus/interpolation/fixed/EnvarBasedValueSource.java

@@ -110,4 +110,13 @@ public Object getValue( String expression, InterpolationState interpolationState
         return envars.getProperty( expr );
     }
 
+    /**
+     * reset static variables acting as a cache for testing purposes only
+     */
+    static void resetStatics()
+    {
+        envarsCaseSensitive = null;
+        envarsCaseInsensitive = null;
+    }
+
 }

src/main/java/org/codehaus/plexus/interpolation/multi/MultiDelimiterStringSearchInterpolator.java

@@ -201,13 +201,17 @@ private String interpolate( String input, RecursionInterceptor recursionIntercep
 
                 if ( startIdx >= 0 && escapeString != null && escapeString.length() > 0 )
                 {
-                    int startEscapeIdx = startIdx == 0 ? 0 : startIdx - escapeString.length();
+                    int startEscapeIdx = ( startIdx == 0 ) ? 0 : startIdx - escapeString.length();
                     if ( startEscapeIdx >= 0 )
                     {
                         String escape = input.substring( startEscapeIdx, startIdx );
                         if ( escape != null && escapeString.equals( escape ) )
                         {
                             result.append( wholeExpr );
+                            if ( startEscapeIdx > 0 )
+                            {
+                                --startEscapeIdx;
+                            }
                             result.replace( startEscapeIdx, startEscapeIdx + escapeString.length(), "" );
                             continue;
                         }
@@ -388,6 +392,12 @@ public void setEscapeString( String escapeString )
     {
         this.escapeString = escapeString;
     }
+
+    public MultiDelimiterStringSearchInterpolator escapeString( String escapeString )
+    {
+        this.escapeString = escapeString;
+        return this;
+    }
 
     public MultiDelimiterStringSearchInterpolator setDelimiterSpecs( LinkedHashSet<String> specs )
     {

src/main/java/org/codehaus/plexus/interpolation/os/OperatingSystemUtils.java

@@ -39,6 +39,8 @@
 public final class OperatingSystemUtils
 {
 
+    private static EnvVarSource envVarSource = new DefaultEnvVarSource();
+
     private OperatingSystemUtils()
     {
     }
@@ -62,16 +64,54 @@ public static Properties getSystemEnvVars( boolean caseSensitive )
         throws IOException
     {
         Properties envVars = new Properties();
-        Map<String, String> envs = System.getenv();
+        Map<String, String> envs = envVarSource.getEnvMap();
         for ( String key : envs.keySet() )
         {
             String value = envs.get( key );
-            if ( !caseSensitive)
+            if ( !caseSensitive )
             {
                 key = key.toUpperCase( Locale.ENGLISH );
             }
             envVars.put( key, value );
         }
         return envVars;
     }
+
+    /**
+     * Set the source object to load the environment variables from.
+     * Default implementation should suffice. This is mostly for testing. 
+     * @param source the EnvVarSource instance that loads the environment variables.
+     * 
+     * @since 3.1.2
+     */
+    public static void setEnvVarSource( EnvVarSource source )
+    {
+        envVarSource = source;
+    }
+
+    /**
+     * Defines the functionality to load a Map of environment variables.
+     * 
+     * @since 3.1.2
+     */
+    public interface EnvVarSource
+    {
+        public Map<String, String> getEnvMap();
+    }
+
+    /**
+     * Default implementation to load environment variables.
+     *
+     * @since 3.1.2
+     */
+    public static class DefaultEnvVarSource
+        implements EnvVarSource
+    {
+
+        public Map<String, String> getEnvMap()
+        {
+            return System.getenv();
+        }
+
+    }
 }