From 0533b06731a8f34e220d94b12b877b7ea60660c0 Mon Sep 17 00:00:00 2001 From: Scott Larkin Date: Wed, 20 Dec 2017 13:03:33 -0500 Subject: [PATCH 1/2] Adjust DEFAULT_MASS to 100 and OVERAGE to 10,000 --- lib/cc/engine/analyzers/go/main.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/cc/engine/analyzers/go/main.rb b/lib/cc/engine/analyzers/go/main.rb index fdc2b7db..747a2b7f 100644 --- a/lib/cc/engine/analyzers/go/main.rb +++ b/lib/cc/engine/analyzers/go/main.rb @@ -12,11 +12,11 @@ module Go class Main < CC::Engine::Analyzers::Base LANGUAGE = "go" PATTERNS = ["**/*.go"].freeze - DEFAULT_MASS_THRESHOLD = 30 + DEFAULT_MASS_THRESHOLD = 100 DEFAULT_FILTERS = [ "(ImportSpec ___)", ].freeze - POINTS_PER_OVERAGE = 40_000 + POINTS_PER_OVERAGE = 10_000 REQUEST_PATH = "/go" COMMENT_MATCHER = Sexp::Matcher.parse("(_ (comments ___) ___)") From deddbe96be2fdff756982369f917d2a57f30922c Mon Sep 17 00:00:00 2001 From: Scott Larkin Date: Wed, 20 Dec 2017 13:03:53 -0500 Subject: [PATCH 2/2] Fix tests due to adjustment of mass/overage --- spec/cc/engine/analyzers/go/main_spec.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/spec/cc/engine/analyzers/go/main_spec.rb b/spec/cc/engine/analyzers/go/main_spec.rb index 79916e4b..db747934 100644 --- a/spec/cc/engine/analyzers/go/main_spec.rb +++ b/spec/cc/engine/analyzers/go/main_spec.rb @@ -36,7 +36,7 @@ module CC::Engine::Analyzers "path" => "foo.go", "lines" => { "begin" => 6, "end" => 6 }, }) - expect(json["remediation_points"]).to eq(540_000) + expect(json["remediation_points"]).to eq(360_000) expect(json["other_locations"]).to eq([ {"path" => "foo.go", "lines" => { "begin" => 7, "end" => 7} }, ]) @@ -82,7 +82,7 @@ module CC::Engine::Analyzers "path" => "foo.go", "lines" => { "begin" => 5, "end" => 7 }, }) - expect(json["remediation_points"]).to eq(1_260_000) + expect(json["remediation_points"]).to eq(540_000) expect(json["other_locations"]).to eq([ {"path" => "foo.go", "lines" => { "begin" => 9, "end" => 11} }, {"path" => "foo.go", "lines" => { "begin" => 13, "end" => 15} },