From 7e8d1127981fb96f4cdcaaab5b07aefc92e9aa52 Mon Sep 17 00:00:00 2001 From: kobenguyent Date: Sat, 16 Dec 2023 09:40:03 +0100 Subject: [PATCH 1/3] fix(puppeteer): hide deprecation info --- lib/helper/Puppeteer.js | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/helper/Puppeteer.js b/lib/helper/Puppeteer.js index 41f2fd44a..3cabc0927 100644 --- a/lib/helper/Puppeteer.js +++ b/lib/helper/Puppeteer.js @@ -259,6 +259,7 @@ class Puppeteer extends Helper { headless: !this.options.show, ...this._getOptions(config), }; + if (this.puppeteerOptions.headless) this.puppeteerOptions.headless = 'new'; this.isRemoteBrowser = !!this.puppeteerOptions.browserWSEndpoint; popupStore.defaultAction = this.options.defaultPopupAction; } From 9f37b3a70dcca878a98e71302b19619a7aa53aa6 Mon Sep 17 00:00:00 2001 From: kobenguyent Date: Sat, 16 Dec 2023 15:27:40 +0100 Subject: [PATCH 2/3] fix: UTs --- lib/helper/Puppeteer.js | 3 ++- package.json | 2 +- test/helper/Puppeteer_test.js | 8 ++++++-- 3 files changed, 9 insertions(+), 4 deletions(-) diff --git a/lib/helper/Puppeteer.js b/lib/helper/Puppeteer.js index 3cabc0927..9833de3a1 100644 --- a/lib/helper/Puppeteer.js +++ b/lib/helper/Puppeteer.js @@ -741,7 +741,8 @@ class Puppeteer extends Helper { assertElementExists(els, locator, 'Element to focus'); const el = els[0]; - await focusElement(el, this.page); + await el.click(); + await el.focus(); return this._waitForAction(); } diff --git a/package.json b/package.json index 7459ff231..8289173c8 100644 --- a/package.json +++ b/package.json @@ -141,7 +141,7 @@ "jsdoc-typeof-plugin": "1.0.0", "json-server": "0.10.1", "playwright": "1.40.1", - "puppeteer": "21.1.1", + "puppeteer": "21.6.1", "qrcode-terminal": "0.12.0", "rosie": "2.1.0", "runok": "0.9.3", diff --git a/test/helper/Puppeteer_test.js b/test/helper/Puppeteer_test.js index c5ef748d9..7623f9536 100644 --- a/test/helper/Puppeteer_test.js +++ b/test/helper/Puppeteer_test.js @@ -137,8 +137,12 @@ describe('Puppeteer', function () { }); it('should be unauthenticated ', async () => { - await I.amOnPage('/basic_auth'); - await I.dontSee('You entered admin as your password.'); + try { + await I.amOnPage('/basic_auth'); + await I.dontSee('You entered admin as your password.'); + } catch (e) { + expect(e.message).to.eq('net::ERR_INVALID_AUTH_CREDENTIALS at http://localhost:8000/basic_auth'); + } }); }); From 699f6727e65cef68fc0008a6ea478094e42ff464 Mon Sep 17 00:00:00 2001 From: KobeNguyenT <7845001+kobenguyent@users.noreply.github.com> Date: Sat, 16 Dec 2023 15:35:36 +0100 Subject: [PATCH 3/3] revert ppt version --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 8289173c8..7459ff231 100644 --- a/package.json +++ b/package.json @@ -141,7 +141,7 @@ "jsdoc-typeof-plugin": "1.0.0", "json-server": "0.10.1", "playwright": "1.40.1", - "puppeteer": "21.6.1", + "puppeteer": "21.1.1", "qrcode-terminal": "0.12.0", "rosie": "2.1.0", "runok": "0.9.3",