Added DataTable and DataTableArgument types
#3492
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, could you please review my changes and tell me if you need something more? |
DavertMik
requested changes
Nov 25, 2022
| /** | ||
| * Datatable class to provide data driven testing | ||
| */ | ||
| class DataTable { | ||
| /** @param {Array<*>} array */ | ||
| /** @param {Array<DataTableArgument>} array */ | ||
| constructor(array) { |
There was a problem hiding this comment.
I'm not sure this is correct
As you can actually pass any array into DataTable
DataTableArgument works only with Gherkin tables while DataTable works with classical tables as well
|
I'm sorry it took me that long to review this PR, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/Description of the PR
DataTableandDataTableArgumenttypes toindex.d.tsType of change
Checklist:
npm run lint)npm test)