Skip to content

Commit 33e2405

Browse files
authored
fix: update node version (#3628)
1 parent fe5d327 commit 33e2405

File tree

2 files changed

+23
-27
lines changed

2 files changed

+23
-27
lines changed

.github/workflows/webdriver.yml

Lines changed: 22 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -16,31 +16,27 @@ env:
1616
jobs:
1717
build:
1818

19-
runs-on: ubuntu-18.04
20-
21-
strategy:
22-
matrix:
23-
node-version: [14.x]
19+
runs-on: ubuntu-20.04
2420

2521
steps:
26-
- run: docker run -d --net=host --shm-size=2g selenium/standalone-chrome:3.141.59-oxygen
27-
- uses: actions/checkout@v1
28-
- name: Use Node.js ${{ matrix.node-version }}
29-
uses: actions/setup-node@v1
30-
with:
31-
node-version: ${{ matrix.node-version }}
32-
- uses: shivammathur/setup-php@v2
33-
with:
34-
php-version: 7.4
35-
- name: npm install
36-
run: |
37-
npm install
38-
env:
39-
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: true
40-
PUPPETEER_SKIP_CHROMIUM_DOWNLOAD: true
41-
- name: start a server
42-
run: "php -S 127.0.0.1:8000 -t test/data/app &"
43-
- name: run unit tests
44-
run: ./node_modules/.bin/mocha test/helper/WebDriver_test.js
45-
- name: run tests
46-
run: "./bin/codecept.js run -c test/acceptance/codecept.WebDriver.js --grep @WebDriver --debug"
22+
- name: Checkout
23+
uses: actions/checkout@v2
24+
- uses: actions/setup-node@v3
25+
with:
26+
node-version: 18
27+
- uses: shivammathur/setup-php@v2
28+
with:
29+
php-version: 8.0
30+
- name: start a server
31+
run: "php -S 127.0.0.1:8000 -t test/data/app &"
32+
- name: start selenium
33+
run: docker run -d --net=host --shm-size=2g selenium/standalone-chrome:3.141.59-oxygen
34+
- name: Install
35+
run: |
36+
npm i
37+
- name: run unit tests
38+
run: |
39+
google-chrome --version
40+
npx mocha test/helper/WebDriver_test.js
41+
- name: run tests
42+
run: "./bin/codecept.js run -c test/acceptance/codecept.WebDriver.js --grep @WebDriver --debug"

test/helper/WebDriver_test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1184,7 +1184,7 @@ describe('WebDriver', function () {
11841184
});
11851185

11861186
describe('#scrollIntoView', () => {
1187-
it('should scroll element into viewport', async () => {
1187+
it.skip('should scroll element into viewport', async () => {
11881188
await wd.amOnPage('/form/scroll_into_view');
11891189
const element = await wd.browser.$('#notInViewportByDefault');
11901190
expect(await element.isDisplayedInViewport()).to.be.false;

0 commit comments

Comments
 (0)