Reject null byte in path to SQLite database file

Author: SimonFrings

src/Factory.php

@@ -104,6 +104,13 @@ public function __construct(LoopInterface $loop = null)
     public function open($filename, $flags = null)
     {
         $filename = $this->resolve($filename);
+
+        if (\strpos($filename, "\0") !== false) {
+            return \React\Promise\reject(new \InvalidArgumentException(
+                'Invalid argument (filename) given: Invalid null byte in your SQLite database file path'
+            ));
+        }
+
         return $this->useSocket ? $this->openSocketIo($filename, $flags) : $this->openProcessIo($filename, $flags);
     }
 

tests/FunctionalDatabaseTest.php

@@ -134,6 +134,29 @@ public function testOpenInvalidPathRejects($flag)
         $loop->run();
     }
 
+    /**
+     * @dataProvider provideSocketFlags
+     * @param bool $flag
+     */
+    public function testOpenInvalidPathWithNullByteReadAsOneByteWillReject($flag)
+    {
+        $loop = \React\EventLoop\Factory::create();
+        $factory = new Factory($loop);
+
+        $ref = new \ReflectionProperty($factory, 'useSocket');
+        $ref->setAccessible(true);
+        $ref->setValue($factory, $flag);
+
+        $promise = $factory->open("test\0.db");
+
+        $promise->then(
+            null,
+            $this->expectCallableOnceWith($this->isInstanceOf('InvalidArgumentException'))
+        );
+
+        $loop->run();
+    }
+
     /**
      * @dataProvider provideSocketFlags
      * @param bool $flag