Support including deleted files (attic) in CVS directory listings

Author: clue

src/Client.php

@@ -56,7 +56,7 @@ public function fetchFile($path, $revision = null)
         return $this->fetch($url);
     }
 
-    public function fetchDirectory($path, $revision = null)
+    public function fetchDirectory($path, $revision = null, $showAttic = false)
     {
         if (substr($path, -1) !== '/') {
             return $this->reject(new InvalidArgumentException('Directory path MUST end with trailing slash'));
@@ -68,6 +68,11 @@ public function fetchDirectory($path, $revision = null)
             $url .= '?pathrev=' . $revision;
         }
 
+        if ($showAttic) {
+            $url .= (strpos($url, '?') === false) ? '?' : '&';
+            $url .= 'hideattic=0';
+        }
+
         // TODO: path MUST end with trailing slash
         // TODO: accessing files will redirect to file with relative location URL (not supported by clue/buzz-react)
 

tests/ClientTest.php

@@ -67,6 +67,24 @@ public function testFetchDirectoryRevision()
         $this->expectPromiseReject($promise);
     }
 
+    public function testFetchDirectoryAttic()
+    {
+        $this->browser->expects($this->once())->method('get')->with($this->equalTo('http://viewvc.example.org/directory/?hideattic=0'))->will($this->returnValue($this->createPromiseRejected()));
+
+        $promise = $this->client->fetchDirectory('/directory/', null, true);
+
+        $this->expectPromiseReject($promise);
+    }
+
+    public function testFetchDirectoryRevisionAttic()
+    {
+        $this->browser->expects($this->once())->method('get')->with($this->equalTo('http://viewvc.example.org/directory/?pathrev=1.1&hideattic=0'))->will($this->returnValue($this->createPromiseRejected()));
+
+        $promise = $this->client->fetchDirectory('/directory/', '1.1', true);
+
+        $this->expectPromiseReject($promise);
+    }
+
     public function testFetchPatch()
     {
         $this->browser->expects($this->once())->method('get')->with($this->equalTo('http://viewvc.example.org/README.md?view=patch&r1=1.0&r2=1.1'))->will($this->returnValue($this->createPromiseRejected()));