Update to new Promise API (keeping BC)

Author: clue

composer.json

@@ -16,6 +16,7 @@
     "require": {
         "php": ">=5.3",
         "react/event-loop": "~0.4.0|~0.3.0",
+        "react/promise": "~2.1|~1.1",
         "clue/buzz-react": "~0.4.0",
         "ext-simplexml": "*",
         "neitanod/forceutf8": "~1.4"

src/Client.php

@@ -8,7 +8,7 @@
 use InvalidArgumentException;
 use Clue\React\Buzz\Browser;
 use Clue\React\Buzz\Message\Response;
-use React\Promise\Deferred;
+use React\Promise;
 use Clue\React\ViewVcApi\Io\Parser;
 use Clue\React\ViewVcApi\Io\Loader;
 
@@ -40,7 +40,7 @@ public function __construct($url, Browser $browser, Parser $parser = null, Loade
     public function fetchFile($path, $revision = null)
     {
         if (substr($path, -1) === '/') {
-            return $this->reject(new InvalidArgumentException('File path MUST NOT end with trailing slash'));
+            return Promise\reject(new InvalidArgumentException('File path MUST NOT end with trailing slash'));
         }
 
         $url = $path . '?view=co';
@@ -59,7 +59,7 @@ public function fetchFile($path, $revision = null)
     public function fetchDirectory($path, $revision = null, $showAttic = false)
     {
         if (substr($path, -1) !== '/') {
-            return $this->reject(new InvalidArgumentException('Directory path MUST end with trailing slash'));
+            return Promise\reject(new InvalidArgumentException('Directory path MUST end with trailing slash'));
         }
 
         $url = $path;
@@ -144,12 +144,4 @@ function ($error) {
             }
         );
     }
-
-    private function reject($with)
-    {
-        $deferred = new Deferred();
-        $deferred->reject($with);
-
-        return $deferred->promise();
-    }
 }

tests/ClientTest.php

@@ -3,6 +3,7 @@
 use Clue\React\ViewVcApi\Client;
 use Clue\React\Buzz\Message\Response;
 use Clue\React\Buzz\Message\Body;
+use React\Promise;
 
 class ClientTest extends TestCase
 {
@@ -32,7 +33,7 @@ public function testInvalidFile()
     public function testFetchFile()
     {
         $response = new Response('HTTP/1.0', 200, 'OK', array(), new Body('# hello'));
-        $this->browser->expects($this->once())->method('get')->with($this->equalTo('http://viewvc.example.org/README.md?view=co'))->will($this->returnValue($this->createPromiseResolved($response)));
+        $this->browser->expects($this->once())->method('get')->with($this->equalTo('http://viewvc.example.org/README.md?view=co'))->will($this->returnValue(Promise\resolve($response)));
 
         $promise = $this->client->fetchFile('README.md');
 
@@ -41,7 +42,7 @@ public function testFetchFile()
 
     public function testFetchFileExcessiveSlashesAreIgnored()
     {
-        $this->browser->expects($this->once())->method('get')->with($this->equalTo('http://viewvc.example.org/README.md?view=co'))->will($this->returnValue($this->createPromiseRejected()));
+        $this->browser->expects($this->once())->method('get')->with($this->equalTo('http://viewvc.example.org/README.md?view=co'))->will($this->returnValue(Promise\reject()));
 
         $client = new Client($this->url . '/', $this->browser);
         $promise = $client->fetchFile('/README.md');
@@ -51,7 +52,7 @@ public function testFetchFileExcessiveSlashesAreIgnored()
 
     public function testFetchFileRevision()
     {
-        $this->browser->expects($this->once())->method('get')->with($this->equalTo('http://viewvc.example.org/README.md?view=co&pathrev=1.0'))->will($this->returnValue($this->createPromiseRejected()));
+        $this->browser->expects($this->once())->method('get')->with($this->equalTo('http://viewvc.example.org/README.md?view=co&pathrev=1.0'))->will($this->returnValue(Promise\reject()));
 
         $promise = $this->client->fetchFile('/README.md', '1.0');
 
@@ -60,7 +61,7 @@ public function testFetchFileRevision()
 
     public function testFetchDirectoryRevision()
     {
-        $this->browser->expects($this->once())->method('get')->with($this->equalTo('http://viewvc.example.org/directory/?pathrev=1.0'))->will($this->returnValue($this->createPromiseRejected()));
+        $this->browser->expects($this->once())->method('get')->with($this->equalTo('http://viewvc.example.org/directory/?pathrev=1.0'))->will($this->returnValue(Promise\reject()));
 
         $promise = $this->client->fetchDirectory('/directory/', '1.0');
 
@@ -69,7 +70,7 @@ public function testFetchDirectoryRevision()
 
     public function testFetchDirectoryAttic()
     {
-        $this->browser->expects($this->once())->method('get')->with($this->equalTo('http://viewvc.example.org/directory/?hideattic=0'))->will($this->returnValue($this->createPromiseRejected()));
+        $this->browser->expects($this->once())->method('get')->with($this->equalTo('http://viewvc.example.org/directory/?hideattic=0'))->will($this->returnValue(Promise\reject()));
 
         $promise = $this->client->fetchDirectory('/directory/', null, true);
 
@@ -78,7 +79,7 @@ public function testFetchDirectoryAttic()
 
     public function testFetchDirectoryRevisionAttic()
     {
-        $this->browser->expects($this->once())->method('get')->with($this->equalTo('http://viewvc.example.org/directory/?pathrev=1.1&hideattic=0'))->will($this->returnValue($this->createPromiseRejected()));
+        $this->browser->expects($this->once())->method('get')->with($this->equalTo('http://viewvc.example.org/directory/?pathrev=1.1&hideattic=0'))->will($this->returnValue(Promise\reject()));
 
         $promise = $this->client->fetchDirectory('/directory/', '1.1', true);
 
@@ -87,7 +88,7 @@ public function testFetchDirectoryRevisionAttic()
 
     public function testFetchLogRevision()
     {
-        $this->browser->expects($this->once())->method('get')->with($this->equalTo('http://viewvc.example.org/README.md?view=log&pathrev=1.0'))->will($this->returnValue($this->createPromiseRejected()));
+        $this->browser->expects($this->once())->method('get')->with($this->equalTo('http://viewvc.example.org/README.md?view=log&pathrev=1.0'))->will($this->returnValue(Promise\reject()));
 
         $promise = $this->client->fetchLog('/README.md', '1.0');
 
@@ -96,7 +97,7 @@ public function testFetchLogRevision()
 
     public function testFetchPatch()
     {
-        $this->browser->expects($this->once())->method('get')->with($this->equalTo('http://viewvc.example.org/README.md?view=patch&r1=1.0&r2=1.1'))->will($this->returnValue($this->createPromiseRejected()));
+        $this->browser->expects($this->once())->method('get')->with($this->equalTo('http://viewvc.example.org/README.md?view=patch&r1=1.0&r2=1.1'))->will($this->returnValue(Promise\reject()));
 
         $promise = $this->client->fetchPatch('/README.md', '1.0', '1.1');
 

tests/FunctionalApacheClientTest.php

@@ -3,7 +3,6 @@
 use Clue\React\ViewVcApi\Client;
 use React\EventLoop\Factory as LoopFactory;
 use Clue\React\Buzz\Browser;
-use React\Promise\PromiseInterface;
 use Clue\React\Block;
 
 class FunctionalApacheClientTest extends TestCase

tests/FunctionalGentooClientTest.php

@@ -3,7 +3,6 @@
 use Clue\React\ViewVcApi\Client;
 use React\EventLoop\Factory as LoopFactory;
 use Clue\React\Buzz\Browser;
-use React\Promise\PromiseInterface;
 use Clue\React\Block;
 
 class FunctionalGentooClientTest extends TestCase

tests/bootstrap.php

@@ -1,7 +1,5 @@
 <?php
 
-use React\Promise\Deferred;
-
 require __DIR__ . '/../vendor/autoload.php';
 
 class TestCase extends PHPUnit_Framework_TestCase
@@ -73,22 +71,6 @@ protected function expectPromiseReject($promise)
 
         return $promise;
     }
-
-    protected function createPromiseResolved($value = null)
-    {
-        $deferred = new Deferred();
-        $deferred->resolve($value);
-
-        return $deferred->promise();
-    }
-
-    protected function createPromiseRejected($value = null)
-    {
-        $deferred = new Deferred();
-        $deferred->reject($value);
-
-        return $deferred->promise();
-    }
 }
 
 class CallableStub