Support broken markup generated by older ViewVC versions

Author: clue

src/Io/Loader.php

@@ -26,8 +26,13 @@ public function loadXmlFile($path)
 
     public function loadXmlString($html)
     {
-        // fix invalid markup of help link in footer of outdated ViewVC versions
+        // fix invalid markup of outdated ViewVC versions
+        // - help link in footer not terminated
+        // - selected branch/tag in CVS "sticky tag" dropdown has not attribute value
+        // - clear button for selected branch/tag has no trailing slash
         $html = str_replace('Help</strong></td>', 'Help</a></strong></td>', $html);
+        $html = str_replace('selected>', 'selected="selected">', $html);
+        $html = preg_replace('#<input([^\/]+)>#', '<input$1 />', $html);
 
         // replace named HTML entities with their UTF-8 value
         $html = str_replace(array_values($this->entities), array_keys($this->entities), $html);

tests/Io/LoaderTest.php

@@ -38,4 +38,20 @@ public function testHtmlEntities()
         // c3 a4 e2 80 a6 c2 a0 c2 a9
         $this->assertEquals('ä… ©', (string)$xml);
     }
+
+    public function testLoadInvalidMarkupInputNotClosed()
+    {
+        $str = '<input type="hidden">';
+        $xml = $this->loader->loadXmlString($str);
+
+        $this->assertEquals('hidden', (string)$xml['type']);
+    }
+
+    public function testLoadInvalidMarkupSelectedAttributeNoValue()
+    {
+        $str = '<option selected>this</option>';
+        $xml = $this->loader->loadXmlString($str);
+
+        $this->assertEquals('selected', (string)$xml['selected']);
+    }
 }