feat: List scalars #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
disq
commented
Aug 9, 2023
| import { Scalar } from './scalar.js'; | ||
| import { isInvalid, NULL_VALUE } from './util.js'; | ||
|
|
||
| type TVector<T extends Scalar<unknown>> = T[]; |
There was a problem hiding this comment.
TVector because Vector is:
export type Vector = Scalar<unknown>[];There was a problem hiding this comment.
Explanation: Difference between TVector and Vector types
TVector
type TVector<T extends Scalar<unknown>> = T[];- TVector is a generic type.
- It creates an array type, but the type of items in this array is based on whatever type you provide when using
TVector.- For example:
- If you use
TVector<Int64>, then it's equivalent toInt64[]. - If you use
TVector<Bool>, then it's equivalent toBool[].
- If you use
- For example:
- This flexibility allows you to specify the item type of the array whenever you utilize
TVector.
Vector
export type Vector = Scalar<unknown>[];- Vector is not a generic.
- It explicitly states that
Vectoris an array ofScalar<unknown>. - This means there's no flexibility when using
Vector; it's always an array ofScalar<unknown>.
Summary
TVectorprovides flexibility on the array item's type, letting you specify it when using the type.Vectoris fixed to always be an array ofScalar<unknown>.
erezrokah
approved these changes
Aug 9, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Aug 16, 2023
🤖 I have created a release *beep* *boop* --- ## [0.0.3](v0.0.2...v0.0.3) (2023-08-16) ### Features * Add `addCQIDsColumns` util, split MemDB into files ([#51](#51)) ([dd71c60](dd71c60)) * Add arrow dependency ([#15](#15)) ([082213f](082213f)) * Add Bool scalar ([#17](#17)) ([80edcd5](80edcd5)) * Add CLI argument parsing ([#10](#10)) ([0d70b25](0d70b25)) * Add CQID and Parent CQID ([#53](#53)) ([fbb7c94](fbb7c94)) * Add initial sync, scheduler ([#37](#37)) ([9b41287](9b41287)) * Add JSON scalar ([#55](#55)) ([7e39769](7e39769)) * Add multiplexer, round-robin ([#48](#48)) ([00a842a](00a842a)) * Add String type ([#29](#29)) ([4c07a3d](4c07a3d)) * Add table types ([#32](#32)) ([c7b301d](c7b301d)) * Add UUID scalar ([#54](#54)) ([d8474ce](d8474ce)) * Add UUID, JSON types ([#56](#56)) ([45ab919](45ab919)) * Implement discovery service ([#19](#19)) ([3abe320](3abe320)) * Implement logger ([#21](#21)) ([43becf1](43becf1)) * List scalars ([#36](#36)) ([0eb6d62](0eb6d62)) * MemDB read ([#43](#43)) ([3429de0](3429de0)), closes [#41](#41) * MemDB writes ([#42](#42)) ([8f21f52](8f21f52)) * More scalars ([#50](#50)) ([a9589b6](a9589b6)) * Scaffold plugin server ([#27](#27)) ([f0864eb](f0864eb)) * **scalars:** Timestamp, float64, int64 ([#35](#35)) ([7fc391c](7fc391c)) * Transform objects ([#34](#34)) ([c14f017](c14f017)), closes [#5](#5) * Transformers ([#25](#25)) ([e96adb3](e96adb3)) ### Bug Fixes * @grpc/grpc-js dependency ([2adf06d](2adf06d)) * **deps:** Update dependency @cloudquery/plugin-pb-javascript to ^0.0.6 ([#14](#14)) ([92a87a1](92a87a1)) * Encode tables in migrate messages ([#38](#38)) ([f6413d2](f6413d2)) * Error handling, `null` values in scalars, proper exports ([#61](#61)) ([2b283d1](2b283d1)) * Extension types null values ([#58](#58)) ([e8bb0a0](e8bb0a0)) * Flatten tables in GetTables gRPC call ([#57](#57)) ([5a8f3c3](5a8f3c3)) * Implement sync, scheduler, resource encoding ([#44](#44)) ([4a5f9e8](4a5f9e8)) * Parent CQId resolver ([8de14cb](8de14cb)) * Properly encode uuid ([#59](#59)) ([72efa22](72efa22)) * Support only tcp network ([#23](#23)) ([e138e40](e138e40)) * Write gRPC call, use `for await` on write readble stream ([#52](#52)) ([773a0e5](773a0e5)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.