Skip to content

Commit 1c8ff53

Browse files
authored
Merge pull request #2 from clouddrove/CD-147
fix labels managedby variables
2 parents 434a6e3 + 0916e9d commit 1c8ff53

File tree

6 files changed

+103
-95
lines changed

6 files changed

+103
-95
lines changed

README.md

Lines changed: 88 additions & 87 deletions
Large diffs are not rendered by default.

README.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ usage : |-
3737
### Basic Example
3838
```hcl
3939
module "api-gateway" {
40-
source = "git::https://github.com/clouddrove/terraform-aws-api-gateway.git?ref=tags/0.12.0"
40+
source = "git::https://github.com/clouddrove/terraform-aws-api-gateway.git?ref=tags/0.12.2"
4141
name = "api-gateway"
4242
application = "clouddrove"
4343
environment = "test"
@@ -95,7 +95,7 @@ usage : |-
9595
### Complete Example
9696
```hcl
9797
module "api-gateway" {
98-
source = "git::https://github.com/clouddrove/terraform-aws-api-gateway.git?ref=tags/0.12.0"
98+
source = "git::https://github.com/clouddrove/terraform-aws-api-gateway.git?ref=tags/0.12.2"
9999
name = "api-gateway"
100100
application = "clouddrove"
101101
environment = "test"

_example/basic/example.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ provider "aws" {
33
}
44

55
module "api-gateway" {
6-
source = "git::https://github.com/clouddrove/terraform-aws-api-gateway.git?ref=tags/0.12.0"
6+
source = "../../"
77
name = "api-gateway"
88
application = "clouddrove"
99
environment = "test"

_example/complete/example.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ provider "aws" {
33
}
44

55
module "api-gateway" {
6-
source = "git::https://github.com/clouddrove/terraform-aws-api-gateway.git?ref=tags/0.12.0"
6+
source = "../../"
77

88
name = "api-gateway"
99
application = "clouddrove"

main.tf

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ module "labels" {
1111
name = var.name
1212
application = var.application
1313
environment = var.environment
14+
managedby = var.managedby
1415
label_order = var.label_order
1516
}
1617

@@ -144,7 +145,7 @@ resource "aws_api_gateway_method_response" "options_200" {
144145
"method.response.header.Access-Control-Allow-Credentials" = true
145146
}
146147

147-
depends_on = ["aws_api_gateway_method.options_method"]
148+
depends_on = [aws_api_gateway_method.options_method]
148149
}
149150

150151
resource "aws_api_gateway_integration" "options_integration" {
@@ -156,7 +157,7 @@ resource "aws_api_gateway_integration" "options_integration" {
156157
type = "MOCK"
157158
content_handling = "CONVERT_TO_TEXT"
158159

159-
depends_on = ["aws_api_gateway_method.options_method"]
160+
depends_on = [aws_api_gateway_method.options_method]
160161
}
161162

162163
resource "aws_api_gateway_integration_response" "options_integration_response" {
@@ -173,8 +174,8 @@ resource "aws_api_gateway_integration_response" "options_integration_response" {
173174
}
174175

175176
depends_on = [
176-
"aws_api_gateway_method_response.options_200",
177-
"aws_api_gateway_integration.options_integration",
177+
aws_api_gateway_method_response.options_200,
178+
aws_api_gateway_integration.options_integration,
178179
]
179180
}
180181

variables.tf

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,12 @@ variable "tags" {
4242
description = "Additional tags (e.g. map(`BusinessUnit`,`XYZ`)."
4343
}
4444

45+
variable "managedby" {
46+
type = string
47+
default = "anmol@clouddrove.com"
48+
description = "ManagedBy, eg 'CloudDrove' or 'AnmolNagpal'."
49+
}
50+
4551
# Module : Api Gateway
4652
# Description : Terraform Api Gateway module variables.
4753
variable "enabled" {

0 commit comments

Comments
 (0)