chore(clippy): make clippy happy

Author: clearloop

src/cache/mod.rs

@@ -23,16 +23,13 @@ pub fn conn(p: String) -> SqliteConnection {
 
 /// Condition submit or test
 #[derive(Clone, Debug)]
+#[derive(Default)]
 pub enum Run {
     Test,
+    #[default]
     Submit,
 }
 
-impl Default for Run {
-    fn default() -> Self {
-        Run::Submit
-    }
-}
 
 /// Requests if data not download
 #[derive(Clone)]

src/cache/parser.rs

@@ -15,12 +15,12 @@ pub fn problem(problems: &mut Vec<Problem>, v: Value) -> Option<()> {
             // Handle on leetcode-com
             Some(s) => s as i32,
             // Handle on leetcode-cn
-            None => fid_obj.as_str()?.split(" ").last()?.parse::<i32>().ok()?,
+            None => fid_obj.as_str()?.split(' ').last()?.parse::<i32>().ok()?,
         };
 
         problems.push(Problem {
             category: v.get("category_slug")?.as_str()?.to_string(),
-            fid: fid,
+            fid,
             id: stat.get("question_id")?.as_i64()? as i32,
             level: p.get("difficulty")?.as_object()?.get("level")?.as_i64()? as i32,
             locked: p.get("paid_only")?.as_bool()?,
@@ -102,7 +102,7 @@ pub fn daily(v: Value) -> Option<i32> {
         // Handle on leetcode-com
         Some(v) => v,
         // Handle on leetcode-cn
-        None => v_obj.get("todayRecord")?.as_array()?.get(0)?,
+        None => v_obj.get("todayRecord")?.as_array()?.first()?,
     }
     .as_object()?
     .get("question")?

src/cmds/list.rs

@@ -184,7 +184,6 @@ impl Command for ListCommand {
                 .get_many::<i32>("range")
                 .ok_or(Error::NoneError)?
                 .copied()
-                .into_iter()
                 .collect();
             ps.retain(|x| num_range[0] <= x.fid && x.fid <= num_range[1]);
         }

src/cmds/pick.rs

@@ -139,11 +139,8 @@ impl Command for PickCommand {
         let fid = match m.contains_id("name") {
             // check for name specified, or closest name
             true => {
-                match m.get_one::<String>("name").map(|name| name) {
-                    Some(quesname) => match closest_named_problem(&problems, quesname) {
-                        Some(p) => p,
-                        None => 1,
-                    },
+                match m.get_one::<String>("name") {
+                    Some(quesname) => closest_named_problem(&problems, quesname).unwrap_or(1),
                     None => {
                         // Pick random without specify id
                         let problem = &problems[rand::thread_rng().gen_range(0..problems.len())];
@@ -190,7 +187,7 @@ fn closest_named_problem(problems: &Vec<Problem>, lookup_name: &str) -> Option<i
     let mut table: Vec<usize> = vec![0; (max_name_size + 1) * (lookup_name.len() + 1)];
 
     // this is guaranteed because of the earlier max None propegation
-    assert!(problems.len() > 0);
+    assert!(!problems.is_empty());
     let mut max_score = 0;
     let mut current_problem = &problems[0];
     for problem in problems {
@@ -204,7 +201,7 @@ fn closest_named_problem(problems: &Vec<Problem>, lookup_name: &str) -> Option<i
 
         if this_score > max_score {
             max_score = this_score;
-            current_problem = &problem;
+            current_problem = problem;
         }
     }
 

src/cmds/stat.rs

@@ -81,7 +81,7 @@ impl Command for StatCommand {
         );
 
         // lines
-        for (i, l) in vec![(easy, easy_ac), (medium, medium_ac), (hard, hard_ac)]
+        for (i, l) in [(easy, easy_ac), (medium, medium_ac), (hard, hard_ac)]
             .iter()
             .enumerate()
         {

src/config/storage.rs

@@ -65,7 +65,7 @@ impl Storage {
             self.scripts = Some("scripts".into());
         }
 
-        let p = PathBuf::from(root).join(&self.scripts.ok_or(Error::NoneError)?);
+        let p = PathBuf::from(root).join(self.scripts.ok_or(Error::NoneError)?);
         if !PathBuf::from(&p).exists() {
             std::fs::create_dir(&p)?
         }

src/plugins/leetcode.rs

@@ -86,15 +86,13 @@ impl LeetCode {
         json.insert("variables", r#"{"slug": "$slug"}"#.replace("$slug", slug));
         json.insert(
             "query",
-            vec![
-                "query getTopicTag($slug: String!) {",
+            ["query getTopicTag($slug: String!) {",
                 "  topicTag(slug: $slug) {",
                 "    questions {",
                 "      questionId",
                 "    }",
                 "  }",
-                "}",
-            ]
+                "}"]
             .join("\n"),
         );
 
@@ -151,31 +149,27 @@ impl LeetCode {
                 json.insert("operationName", "daily".to_string());
                 json.insert(
                     "query",
-                    vec![
-                        "query daily {",
+                    ["query daily {",
                         "  activeDailyCodingChallengeQuestion {",
                         "    question {",
                         "      questionFrontendId",
                         "    }",
                         "  }",
-                        "}",
-                    ]
+                        "}"]
                     .join("\n"),
                 );
             }
             config::LeetcodeSite::LeetcodeCn => {
                 json.insert("operationName", "questionOfToday".to_string());
                 json.insert(
                     "query",
-                    vec![
-                        "query questionOfToday {",
+                    ["query questionOfToday {",
                         "  todayRecord {",
                         "    question {",
                         "      questionFrontendId",
                         "    }",
                         "  }",
-                        "}",
-                    ]
+                        "}"]
                     .join("\n"),
                 );
             }
@@ -201,8 +195,7 @@ impl LeetCode {
         let mut json: Json = HashMap::new();
         json.insert(
             "query",
-            vec![
-                "query getQuestionDetail($titleSlug: String!) {",
+            ["query getQuestionDetail($titleSlug: String!) {",
                 "  question(titleSlug: $titleSlug) {",
                 "    content",
                 "    stats",
@@ -213,8 +206,7 @@ impl LeetCode {
                 "    metaData",
                 "    translatedContent",
                 "  }",
-                "}",
-            ]
+                "}"]
             .join("\n"),
         );
 
@@ -232,7 +224,7 @@ impl LeetCode {
             json: Some(json),
             mode: Mode::Post,
             name: "get_problem_detail",
-            url: self.conf.sys.urls.graphql.into(),
+            url: self.conf.sys.urls.graphql,
         }
         .send(&self.client)
         .await