Skip to content

Commit 1f000ab

Browse files
phoflcbpygit
authored andcommitted
TST: Adjust excel tests for new string option (pandas-dev#56534)
1 parent 45d3116 commit 1f000ab

File tree

3 files changed

+23
-18
lines changed

3 files changed

+23
-18
lines changed

pandas/conftest.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -863,8 +863,8 @@ def float_frame() -> DataFrame:
863863
"""
864864
return DataFrame(
865865
np.random.default_rng(2).standard_normal((30, 4)),
866-
index=Index([f"foo_{i}" for i in range(30)], dtype=object),
867-
columns=Index(list("ABCD"), dtype=object),
866+
index=Index([f"foo_{i}" for i in range(30)]),
867+
columns=Index(list("ABCD")),
868868
)
869869

870870

pandas/tests/io/excel/test_readers.py

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -550,7 +550,7 @@ def test_reader_dtype(self, read_ext):
550550

551551
expected["a"] = expected["a"].astype("float64")
552552
expected["b"] = expected["b"].astype("float32")
553-
expected["c"] = ["001", "002", "003", "004"]
553+
expected["c"] = Series(["001", "002", "003", "004"], dtype=object)
554554
tm.assert_frame_equal(actual, expected)
555555

556556
msg = "Unable to convert column d to type int64"
@@ -577,8 +577,8 @@ def test_reader_dtype(self, read_ext):
577577
{
578578
"a": Series([1, 2, 3, 4], dtype="float64"),
579579
"b": Series([2.5, 3.5, 4.5, 5.5], dtype="float32"),
580-
"c": ["001", "002", "003", "004"],
581-
"d": ["1", "2", np.nan, "4"],
580+
"c": Series(["001", "002", "003", "004"], dtype=object),
581+
"d": Series(["1", "2", np.nan, "4"], dtype=object),
582582
}
583583
),
584584
),
@@ -694,15 +694,20 @@ def test_dtype_backend_string(self, read_ext, string_storage):
694694
)
695695
tm.assert_frame_equal(result, expected)
696696

697-
@pytest.mark.parametrize("dtypes, exp_value", [({}, "1"), ({"a.1": "int64"}, 1)])
697+
@pytest.mark.parametrize("dtypes, exp_value", [({}, 1), ({"a.1": "int64"}, 1)])
698698
def test_dtype_mangle_dup_cols(self, read_ext, dtypes, exp_value):
699699
# GH#35211
700700
basename = "df_mangle_dup_col_dtypes"
701-
dtype_dict = {"a": str, **dtypes}
701+
dtype_dict = {"a": object, **dtypes}
702702
dtype_dict_copy = dtype_dict.copy()
703703
# GH#42462
704704
result = pd.read_excel(basename + read_ext, dtype=dtype_dict)
705-
expected = DataFrame({"a": ["1"], "a.1": [exp_value]})
705+
expected = DataFrame(
706+
{
707+
"a": Series([1], dtype=object),
708+
"a.1": Series([exp_value], dtype=object if not dtypes else None),
709+
}
710+
)
706711
assert dtype_dict == dtype_dict_copy, "dtype dict changed"
707712
tm.assert_frame_equal(result, expected)
708713

pandas/tests/io/excel/test_writers.py

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -234,14 +234,14 @@ def test_excel_multindex_roundtrip(
234234
check_names = bool(r_idx_names) or r_idx_levels <= 1
235235

236236
if c_idx_levels == 1:
237-
columns = Index(list("abcde"), dtype=object)
237+
columns = Index(list("abcde"))
238238
else:
239239
columns = MultiIndex.from_arrays(
240240
[range(5) for _ in range(c_idx_levels)],
241241
names=[f"{c_idx_names}-{i}" for i in range(c_idx_levels)],
242242
)
243243
if r_idx_levels == 1:
244-
index = Index(list("ghijk"), dtype=object)
244+
index = Index(list("ghijk"))
245245
else:
246246
index = MultiIndex.from_arrays(
247247
[range(5) for _ in range(r_idx_levels)],
@@ -475,7 +475,7 @@ def test_ts_frame(self, path):
475475
unit = get_exp_unit(path)
476476
df = DataFrame(
477477
np.random.default_rng(2).standard_normal((5, 4)),
478-
columns=Index(list("ABCD"), dtype=object),
478+
columns=Index(list("ABCD")),
479479
index=date_range("2000-01-01", periods=5, freq="B"),
480480
)
481481

@@ -556,7 +556,7 @@ def test_sheets(self, frame, path):
556556
unit = get_exp_unit(path)
557557
tsframe = DataFrame(
558558
np.random.default_rng(2).standard_normal((5, 4)),
559-
columns=Index(list("ABCD"), dtype=object),
559+
columns=Index(list("ABCD")),
560560
index=date_range("2000-01-01", periods=5, freq="B"),
561561
)
562562
index = pd.DatetimeIndex(np.asarray(tsframe.index), freq=None)
@@ -684,7 +684,7 @@ def test_excel_roundtrip_datetime(self, merge_cells, path):
684684
# freq does not round-trip
685685
tsframe = DataFrame(
686686
np.random.default_rng(2).standard_normal((5, 4)),
687-
columns=Index(list("ABCD"), dtype=object),
687+
columns=Index(list("ABCD")),
688688
index=date_range("2000-01-01", periods=5, freq="B"),
689689
)
690690
index = pd.DatetimeIndex(np.asarray(tsframe.index), freq=None)
@@ -812,7 +812,7 @@ def test_to_excel_periodindex(self, path):
812812
# xp has a PeriodIndex
813813
df = DataFrame(
814814
np.random.default_rng(2).standard_normal((5, 4)),
815-
columns=Index(list("ABCD"), dtype=object),
815+
columns=Index(list("ABCD")),
816816
index=date_range("2000-01-01", periods=5, freq="B"),
817817
)
818818
xp = df.resample("ME").mean().to_period("M")
@@ -882,7 +882,7 @@ def test_to_excel_multiindex_dates(self, merge_cells, path):
882882
unit = get_exp_unit(path)
883883
tsframe = DataFrame(
884884
np.random.default_rng(2).standard_normal((5, 4)),
885-
columns=Index(list("ABCD"), dtype=object),
885+
columns=Index(list("ABCD")),
886886
index=date_range("2000-01-01", periods=5, freq="B"),
887887
)
888888
tsframe.index = MultiIndex.from_arrays(
@@ -1310,7 +1310,7 @@ def test_freeze_panes(self, path):
13101310
def test_path_path_lib(self, engine, ext):
13111311
df = DataFrame(
13121312
1.1 * np.arange(120).reshape((30, 4)),
1313-
columns=Index(list("ABCD"), dtype=object),
1313+
columns=Index(list("ABCD")),
13141314
index=Index([f"i-{i}" for i in range(30)], dtype=object),
13151315
)
13161316
writer = partial(df.to_excel, engine=engine)
@@ -1322,8 +1322,8 @@ def test_path_path_lib(self, engine, ext):
13221322
def test_path_local_path(self, engine, ext):
13231323
df = DataFrame(
13241324
1.1 * np.arange(120).reshape((30, 4)),
1325-
columns=Index(list("ABCD"), dtype=object),
1326-
index=Index([f"i-{i}" for i in range(30)], dtype=object),
1325+
columns=Index(list("ABCD")),
1326+
index=Index([f"i-{i}" for i in range(30)]),
13271327
)
13281328
writer = partial(df.to_excel, engine=engine)
13291329

0 commit comments

Comments
 (0)