Skip to content

Commit e272314

Browse files
fix(cicd): Replace deprecated golangci config (#628)
# Description This PR simply removes a deprecated config field in the golangci config file and replaces it with its replacement. See this CICD run for an example of a failed run: https://github.com/caraml-dev/merlin/actions/runs/13383384346/job/37376991624#step:4:35. Previously using the old config would only emit warnings but now they have become explicit errors. See this PR from golangci for more details golangci/golangci-lint#4509. # Modifications - `api/.golangci.yml` - Replace deprecated configs # Tests <!-- Besides the existing / updated automated tests, what specific scenarios should be tested? Consider the backward compatibility of the changes, whether corner cases are covered, etc. Please describe the tests and check the ones that have been completed. Eg: - [x] Deploying new and existing standard models - [ ] Deploying PyFunc models --> # Checklist - [x] Added PR label - [ ] Added unit test, integration, and/or e2e tests - [ ] Tested locally - [ ] Updated documentation - [ ] Update Swagger spec if the PR introduce API changes - [ ] Regenerated Golang and Python client if the PR introduces API changes # Release Notes <!-- Does this PR introduce a user-facing change? If no, just write "NONE" in the release-note block below. If yes, a release note is required. Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required". For more information about release notes, see kubernetes' guide here: http://git.k8s.io/community/contributors/guide/release-notes.md --> ```release-note NONE ```
1 parent 71d93a0 commit e272314

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

api/.golangci.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,6 @@
11
run:
22
timeout: 10m
33
modules-download-mode: readonly
4-
skip-dirs:
5-
- client
6-
- '.*/mocks/.*'
74

85
linters:
96
# See https://golangci-lint.run/usage/linters/
@@ -17,3 +14,6 @@ issues:
1714
exclude-use-default: false
1815
max-issues-per-linter: 0
1916
max-same-issues: 0
17+
exclude-dirs:
18+
- client
19+
- '.*/mocks/.*'

0 commit comments

Comments
 (0)