fix: 🐛 centralize tsconfig

okwasniewski · okwasniewski · commit 4b0165d2f185 · 2024-11-18T10:28:20.000+01:00
diff --git a/apps/example-expo/app/_layout.tsx b/apps/example-expo/app/_layout.tsx
@@ -15,7 +15,6 @@ import { useColorScheme } from '@/hooks/useColorScheme';
 SplashScreen.preventAutoHideAsync();
 
 export default function RootLayout() {
-  console.log('RootLayout');
   const colorScheme = useColorScheme();
   const [loaded] = useFonts({
     SpaceMono: require('../assets/fonts/SpaceMono-Regular.ttf'),
diff --git a/apps/example-expo/babel.config.js b/apps/example-expo/babel.config.js
@@ -3,7 +3,7 @@ const tabView = require('../../packages/react-native-bottom-tabs/package.json');
 const reactNavigationIntegration = require('../../packages/react-navigation/package.json');
 
 module.exports = {
-  presets: ['module:@react-native/babel-preset'],
+  presets: ['babel-preset-expo'],
   plugins: [
     [
       'module-resolver',
diff --git a/apps/example/tsconfig.json b/apps/example/tsconfig.json
@@ -1,30 +1,10 @@
 {
+  "extends": "../tsconfig",
+  "references": [
+    { "path": "../../packages/react-native-bottom-tabs" },
+    { "path": "../../packages/react-navigation" },
+  ],
   "compilerOptions": {
-    "paths": {
-      "react-native-bottom-tabs": ["../../packages/react-native-bottom-tabs/src/index"],
-      "@bottom-tabs/react-navigation": [
-        "../../packages/react-navigation/src/index"
-      ]
-    },
-    "allowUnreachableCode": false,
-    "allowUnusedLabels": false,
-    "esModuleInterop": true,
-    "forceConsistentCasingInFileNames": true,
-    "jsx": "react-jsx",
-    "lib": ["ESNext"],
-    "module": "ESNext",
-    "moduleResolution": "Bundler",
-    "noFallthroughCasesInSwitch": true,
-    "noImplicitReturns": true,
-    "noImplicitUseStrict": false,
-    "noStrictGenericChecks": false,
-    "noUncheckedIndexedAccess": true,
-    "noUnusedLocals": true,
-    "noUnusedParameters": true,
-    "resolveJsonModule": true,
-    "skipLibCheck": true,
-    "strict": true,
-    "target": "ESNext",
-    "verbatimModuleSyntax": true
+    "rootDir": "."
   }
 }
diff --git a/package.json b/package.json
@@ -1,5 +1,5 @@
 {
-  "name": "@native-tabs/monorepo",
+  "name": "@bottom-tabs/monorepo",
   "private": true,
   "workspaces": {
     "packages": [
@@ -30,6 +30,7 @@
     "eslint": "^8.51.0",
     "eslint-config-prettier": "^9.0.0",
     "eslint-plugin-prettier": "^5.0.1",
+    "jest": "^29.7.0",
     "prettier": "^3.0.3",
     "turbo": "^2.1.0",
     "typescript": "^5.2.2"
@@ -39,6 +40,13 @@
       "@commitlint/config-conventional"
     ]
   },
+  "jest": {
+    "preset": "react-native",
+    "modulePathIgnorePatterns": [
+      "<rootDir>/example/node_modules",
+      "<rootDir>/lib/"
+    ]
+  },
   "prettier": {
     "quoteProps": "consistent",
     "singleQuote": true,
diff --git a/packages/react-native-bottom-tabs/package.json b/packages/react-native-bottom-tabs/package.json
@@ -78,17 +78,11 @@
     "registry": "https://registry.npmjs.org/"
   },
   "devDependencies": {
-    "@commitlint/config-conventional": "^17.0.2",
-    "@evilmartians/lefthook": "^1.5.0",
     "@expo/config-plugins": "^7.0.0 || ^8.0.0",
     "@react-native/babel-preset": "0.76.2",
     "@react-native/eslint-config": "0.76.2",
-    "@react-navigation/native": "^6.1.18",
     "@types/jest": "^29.5.5",
     "@types/react": "^18.2.44",
-    "commitlint": "^17.0.2",
-    "del-cli": "^5.1.0",
-    "jest": "^29.7.0",
     "react": "18.3.1",
     "react-native": "0.75.4",
     "react-native-builder-bob": "^0.30.2",
@@ -99,19 +93,6 @@
     "react": "*",
     "react-native": "*"
   },
-  "packageManager": "yarn@3.6.1",
-  "jest": {
-    "preset": "react-native",
-    "modulePathIgnorePatterns": [
-      "<rootDir>/example/node_modules",
-      "<rootDir>/lib/"
-    ]
-  },
-  "commitlint": {
-    "extends": [
-      "@commitlint/config-conventional"
-    ]
-  },
   "release-it": {
     "git": {
       "commitMessage": "chore: release ${version}",
diff --git a/packages/react-native-bottom-tabs/tsconfig.build.json b/packages/react-native-bottom-tabs/tsconfig.build.json
@@ -1,4 +1,7 @@
 {
   "extends": "./tsconfig",
+  "compilerOptions": {
+    "paths": {}
+  },
   "exclude": ["lib"]
 }
diff --git a/packages/react-native-bottom-tabs/tsconfig.json b/packages/react-native-bottom-tabs/tsconfig.json
@@ -1,31 +1,6 @@
 {
+  "extends": "../../tsconfig",
   "compilerOptions": {
     "rootDir": ".",
-    "paths": {
-      "react-native-bottom-tabs": ["./src/index"],
-      "react-native-bottom-tabs/react-navigation": [
-        "./src/react-navigation/index"
-      ]
-    },
-    "allowUnreachableCode": false,
-    "allowUnusedLabels": false,
-    "esModuleInterop": true,
-    "forceConsistentCasingInFileNames": true,
-    "jsx": "react-jsx",
-    "lib": ["ESNext"],
-    "module": "ESNext",
-    "moduleResolution": "Bundler",
-    "noEmit": true,
-    "noFallthroughCasesInSwitch": true,
-    "noImplicitReturns": true,
-    "noImplicitUseStrict": false,
-    "noStrictGenericChecks": false,
-    "noUncheckedIndexedAccess": true,
-    "noUnusedLocals": true,
-    "noUnusedParameters": true,
-    "resolveJsonModule": true,
-    "skipLibCheck": true,
-    "strict": true,
-    "target": "ESNext"
   }
 }
diff --git a/packages/react-navigation/tsconfig.build.json b/packages/react-navigation/tsconfig.build.json
@@ -1,4 +1,7 @@
 {
   "extends": "./tsconfig",
+  "compilerOptions": {
+    "paths": {}
+  },
   "exclude": ["lib"]
 }
diff --git a/packages/react-navigation/tsconfig.json b/packages/react-navigation/tsconfig.json
@@ -1,28 +1,7 @@
 {
+  "extends": "../../tsconfig",
   "compilerOptions": {
     "rootDir": ".",
-    "paths": {
-      "@bottom-tabs/react-navigation": ["./src/index"],
-    },
-    "allowUnreachableCode": false,
-    "allowUnusedLabels": false,
-    "esModuleInterop": true,
-    "forceConsistentCasingInFileNames": true,
-    "jsx": "react-jsx",
-    "lib": ["ESNext"],
-    "module": "ESNext",
-    "moduleResolution": "Bundler",
-    "noEmit": true,
-    "noFallthroughCasesInSwitch": true,
-    "noImplicitReturns": true,
-    "noImplicitUseStrict": false,
-    "noStrictGenericChecks": false,
-    "noUncheckedIndexedAccess": true,
-    "noUnusedLocals": true,
-    "noUnusedParameters": true,
-    "resolveJsonModule": true,
-    "skipLibCheck": true,
-    "strict": true,
-    "target": "ESNext"
+    "paths": {}
   }
 }
diff --git a/tsconfig.json b/tsconfig.json
@@ -0,0 +1,28 @@
+{
+  "compilerOptions": {
+    "paths": {
+      "react-native-bottom-tabs": ["./packages/react-native-bottom-tabs/src/index"],
+      "@bottom-tabs/react-navigation": ["./packages/react-navigation/src/index"],
+    },
+    "allowUnreachableCode": false,
+    "allowUnusedLabels": false,
+    "esModuleInterop": true,
+    "forceConsistentCasingInFileNames": true,
+    "jsx": "react-jsx",
+    "lib": ["ESNext"],
+    "module": "ESNext",
+    "moduleResolution": "Bundler",
+    "noEmit": true,
+    "noFallthroughCasesInSwitch": true,
+    "noImplicitReturns": true,
+    "noImplicitUseStrict": false,
+    "noStrictGenericChecks": false,
+    "noUncheckedIndexedAccess": true,
+    "noUnusedLocals": true,
+    "noUnusedParameters": true,
+    "resolveJsonModule": true,
+    "skipLibCheck": true,
+    "strict": true,
+    "target": "ESNext"
+  }
+}
diff --git a/turbo.json b/turbo.json
@@ -2,13 +2,19 @@
   "$schema": "https://turbo.build/schema.json",
   "tasks": {
     "lint": {
+      "dependsOn": ["prepare"],
       "inputs": ["**/*.ts", "**/*.tsx", "**/*.js"]
     },
     "typecheck": {
+      "dependsOn": ["prepare"],
       "inputs": ["**/*.ts", "**/*.tsx"]
     },
     "test": {},
-    "prepare": {},
+    "prepare": {
+      "dependsOn": ["^prepare"],
+      "outputs": ["lib/**"],
+      "inputs": ["src/**/*.ts", "src/**/*.tsx"]
+    },
     "build:android": {
       "env": ["JAVA_HOME", "ANDROID_NDK", "ANDROID_SDK", "ANDROID_HOME"],
       "inputs": [
diff --git a/yarn.lock b/yarn.lock

Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,7 @@ const tabView = require('../../packages/react-native-bottom-tabs/package.json');`
`3`	`3`	`const reactNavigationIntegration = require('../../packages/react-navigation/package.json');`
`4`	`4`
`5`	`5`	`module.exports = {`
`6`		`- presets: ['module:@react-native/babel-preset'],`
	`6`	`+ presets: ['babel-preset-expo'],`
`7`	`7`	`plugins: [`
`8`	`8`	`[`
`9`	`9`	`'module-resolver',`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,7 @@`
`1`	`1`	`{`
`2`	`2`	`"extends": "./tsconfig",`
	`3`	`+ "compilerOptions": {`
	`4`	`+ "paths": {}`
	`5`	`+ },`
`3`	`6`	`"exclude": ["lib"]`
`4`	`7`	`}`