From 19da6e086bd1422735f28349d9ad9c9878c91764 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Pierzcha=C5=82a?= Date: Thu, 3 Sep 2020 13:22:20 +0200 Subject: [PATCH 1/2] fix: add note about baseElement removed from render --- website/docs/MigrationV7.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/website/docs/MigrationV7.md b/website/docs/MigrationV7.md index 89da4b5f6..2ad0e63a6 100644 --- a/website/docs/MigrationV7.md +++ b/website/docs/MigrationV7.md @@ -101,9 +101,9 @@ You can opt-out of this behavior by running tests with `RNTL_SKIP_AUTO_CLEANUP=t We don't provide any abstraction over `ReactTestInstance` returned by queries, but allow to use it directly to access queried component's `props` or `type` for that example. -## No `container` returned from `render` +## No `container` nor `baseElement` returned from `render` -There's no such key returned from the `render` function. If you must, use `react-test-renderer` directly, although we advise not doing so. +There's no `container` returned from the `render` function. If you must, use `react-test-renderer` directly, although we advise not doing so. We also don't implement `baseElement` beacuse of that, since there's no `document.documentElement` nor `container`. ## Firing events changes From fb353d3edb9da3d18889780a10ecd416087b15cc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Pierzcha=C5=82a?= Date: Thu, 3 Sep 2020 14:08:42 +0200 Subject: [PATCH 2/2] typos, language --- website/docs/MigrationV7.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/website/docs/MigrationV7.md b/website/docs/MigrationV7.md index 2ad0e63a6..d362c2f4e 100644 --- a/website/docs/MigrationV7.md +++ b/website/docs/MigrationV7.md @@ -103,7 +103,7 @@ We don't provide any abstraction over `ReactTestInstance` returned by queries, b ## No `container` nor `baseElement` returned from `render` -There's no `container` returned from the `render` function. If you must, use `react-test-renderer` directly, although we advise not doing so. We also don't implement `baseElement` beacuse of that, since there's no `document.documentElement` nor `container`. +There's no `container` returned from the `render` function. If you must, use `react-test-renderer` directly, although we advise against doing so. We also don't implement `baseElement` because of that, since there's no `document.documentElement` nor `container`. ## Firing events changes