Skip to content

fix: modify *ByType API TS typings to allow required props #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 27, 2018
Merged

fix: modify *ByType API TS typings to allow required props #71

merged 2 commits into from
Nov 27, 2018

Conversation

kdbcinco
Copy link
Contributor

@kdbcinco kdbcinco commented Nov 26, 2018 •
edited by thymikee
Loading

Summary

Modify ByType API typings to allow required props.

Fixes #69

Test plan

  • yarn test

@thymikee thymikee changed the title Issue/69 fix: modify *ByType API TS typings to allow required props Nov 26, 2018
@thymikee thymikee requested a review from Esemesek November 26, 2018 08:37
@thymikee thymikee merged commit b410e39 into callstack:master Nov 27, 2018
@thymikee
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thymikee thymikee thymikee approved these changes

@Esemesek Esemesek Awaiting requested review from Esemesek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kdbcinco @thymikee @kdbcinco-cs