Skip to content

Compile to ES5 #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 23, 2018
Merged

Compile to ES5 #50

merged 7 commits into from
Nov 23, 2018

Conversation

Jukkish
Copy link
Contributor

@Jukkish Jukkish commented Oct 29, 2018

Summary

Fixes #49

@thymikee thymikee requested a review from Esemesek October 29, 2018 13:05
@thymikee
Copy link
Member

Thanks! I've adjusted the PR a bit. We don't use npm, so no package-lock.json.

@Jukkish
Copy link
Contributor Author

Jukkish commented Oct 29, 2018

Thanks!

@Jukkish Jukkish closed this Oct 29, 2018
@thymikee
Copy link
Member

Um, it's not merged yet?

@thymikee thymikee reopened this Oct 29, 2018
@Jukkish
Copy link
Contributor Author

Jukkish commented Oct 29, 2018

Um, it's not merged yet?

Sry, it was an accident :D

@Esemesek
Copy link
Collaborator

Looks good to me. We still need to investigate if flow types are working correctly with this configuration.

@thymikee
Copy link
Member

They're not. We're gonna need something like https://github.com/Macil/flow-copy-source

@henrikra
Copy link

Side note: does it make sense to have tests inside src folder? Usually tests are on root level 🤔

@thymikee
Copy link
Member

Of course it does! The same way as having them in the root level or side-by-side to your source files 😉

@henrikra
Copy link

henrikra commented Nov 4, 2018

Can we get this merged? 😀

@thymikee
Copy link
Member

thymikee commented Nov 4, 2018

Not yet, we need to figure out exporting Flow types, would like to avoid duplication where possible.

@nonewcode
Copy link

Any updates on this one? When could we expect a merge?

@thymikee
Copy link
Member

I'll try to get this over finishing line tomorrow :)

@henrikra
Copy link

Great!

@thymikee thymikee merged commit c3672cf into callstack:master Nov 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants