-
Notifications
You must be signed in to change notification settings - Fork 274
Compile to ES5 #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compile to ES5 #50
Conversation
Thanks! I've adjusted the PR a bit. We don't use |
Thanks! |
Um, it's not merged yet? |
Sry, it was an accident :D |
Looks good to me. We still need to investigate if |
They're not. We're gonna need something like https://github.com/Macil/flow-copy-source |
Side note: does it make sense to have tests inside src folder? Usually tests are on root level 🤔 |
Of course it does! The same way as having them in the root level or side-by-side to your source files 😉 |
Can we get this merged? 😀 |
Not yet, we need to figure out exporting Flow types, would like to avoid duplication where possible. |
Any updates on this one? When could we expect a merge? |
I'll try to get this over finishing line tomorrow :) |
Great! |
Summary
Fixes #49