Skip to content

Commit 7d5f04a

Browse files
committed
code review changes
1 parent 8ca8fc1 commit 7d5f04a

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

src/__tests__/fireEvent.test.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,7 @@ test('should not fire on disabled TouchableOpacity', () => {
173173
</TouchableOpacity>
174174
);
175175

176-
expect(() => fireEvent.press(screen.getByText('Trigger'))).not.toThrow();
176+
fireEvent.press(screen.getByText('Trigger'));
177177
expect(handlePress).not.toHaveBeenCalled();
178178
});
179179

@@ -185,7 +185,7 @@ test('should not fire on disabled Pressable', () => {
185185
</Pressable>
186186
);
187187

188-
expect(() => fireEvent.press(screen.getByText('Trigger'))).not.toThrow();
188+
fireEvent.press(screen.getByText('Trigger'));
189189
expect(handlePress).not.toHaveBeenCalled();
190190
});
191191

src/fireEvent.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,12 +20,14 @@ const findEventHandler = (
2020

2121
// Do not bubble event to the root element
2222
if (element.parent === null || element.parent.parent === null) {
23-
if (hasHandler) return null;
24-
else
23+
if (hasHandler) {
24+
return null;
25+
} else {
2526
throw new ErrorWithStack(
2627
`No handler function found for event: "${eventName}"`,
2728
callsite || invokeEvent
2829
);
30+
}
2931
}
3032

3133
return findEventHandler(

0 commit comments

Comments
 (0)