Skip to content

Commit 45f45bf

Browse files
authored
feat: move pretty-format from peer do deps (#39)
<!-- Please provide enough information so that others can review your pull request. --> <!-- Keep pull requests small and focused on a single change. --> ### Summary We could also make it an optional dependency and inline-require it inside debug (the only place we use it) but for now I decided to make it a regular dependency, because that's what it is, no point in making users install it directly. ### Test plan green CI
1 parent 22ffe84 commit 45f45bf

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ Open a Terminal in your project's folder and run:
5757
yarn add --dev react-native-testing-library
5858
```
5959

60-
This library has a peerDependencies listing for `react-test-renderer`, `pretty-format` and, of course, `react`. Make sure to install them too!
60+
This library has a peerDependencies listing for `react-test-renderer` and, of course, `react`. Make sure to install them too!
6161

6262
As you may have noticed, it's not tied to React Native at all – you can safely use it in your React components if you feel like not interacting directly with DOM.
6363

package.json

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,16 +23,17 @@
2323
"flow-bin": "^0.83.0",
2424
"jest": "^23.6.0",
2525
"metro-react-native-babel-preset": "^0.48.0",
26-
"pretty-format": "^23.6.0",
2726
"react": "16.6.0-alpha.8af6728",
2827
"react-native": "^0.57.3",
2928
"react-test-renderer": "16.6.0-alpha.8af6728",
3029
"release-it": "^7.6.2",
3130
"strip-ansi": "^5.0.0",
3231
"typescript": "^3.1.1"
3332
},
33+
"dependencies": {
34+
"pretty-format": "^23.6.0"
35+
},
3436
"peerDependencies": {
35-
"pretty-format": ">=20.0.0",
3637
"react": ">=16.0.0",
3738
"react-test-renderer": ">= 16.0.0"
3839
},

0 commit comments

Comments
 (0)