From 82390ce8b3dce7c3a23a222c27181d8a7850b7c6 Mon Sep 17 00:00:00 2001 From: Satyajit Sahoo Date: Wed, 4 Dec 2024 15:21:05 +0100 Subject: [PATCH] fix: use 'all' for fabric components codegen config currently codegen doesn't generate all required files such as `Android.mk`, `CMakeLists.txt` etc. for fabric when type is set to `components`. so we use `all` for now until this bug is fixed. closes #661 --- .../templates/common-local/$package.json | 2 +- .../templates/common/$package.json | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/create-react-native-library/templates/common-local/$package.json b/packages/create-react-native-library/templates/common-local/$package.json index e3b230994..8a861ca35 100644 --- a/packages/create-react-native-library/templates/common-local/$package.json +++ b/packages/create-react-native-library/templates/common-local/$package.json @@ -6,7 +6,7 @@ <% if (project.arch !== 'legacy') { -%> "codegenConfig": { "name": "RN<%- project.name -%><%- project.view ? 'View': '' -%>Spec", - "type": <%- project.view ? '"components"': '"modules"' %>, + "type": <%- project.view ? '"all"': '"modules"' %>, "jsSrcsDir": "src" }, <% } -%> diff --git a/packages/create-react-native-library/templates/common/$package.json b/packages/create-react-native-library/templates/common/$package.json index 99dd8931d..289b74a0f 100644 --- a/packages/create-react-native-library/templates/common/$package.json +++ b/packages/create-react-native-library/templates/common/$package.json @@ -198,7 +198,7 @@ }, "codegenConfig": { "name": "RN<%- project.name -%><%- project.view ? 'View': '' -%>Spec", - "type": "<%- project.view ? 'components': 'modules' -%>", + "type": "<%- project.view ? 'all': 'modules' -%>", "jsSrcsDir": "src", "outputDir": { "ios": "ios/generated", @@ -209,7 +209,7 @@ <% if (example === 'vanilla') { -%> }, "includesGeneratedCode": true - <% } else { -%> + <% } else { -%> } <% } -%> <% } -%>