Address comments

demirkayaender · demirkayaender · commit 5e668454e8de · 2021-07-13T22:10:44.000-07:00
diff --git a/build.gradle b/build.gradle
@@ -88,7 +88,7 @@ task updateDlsSubmodule(type: Exec) {
 compileThrift {
     dependsOn updateDlsSubmodule
     verbose true
-    sourceItems "./src/main/idls/thrift/cadence.thrift","./src/main/idls/thrift/shared.thrift","./src/main/idls/thrift/shadower.thrift"
+    sourceItems "${projectDir}/src/main/idls/thrift/cadence.thrift","${projectDir}/src/main/idls/thrift/shared.thrift","${projectDir}/src/main/idls/thrift/shadower.thrift"
 }
 
 compileJava {
diff --git a/docker/buildkite/Dockerfile b/docker/buildkite/Dockerfile
@@ -1,3 +1,6 @@
+# Always use a release version or a specific commit hash below. Don't use
+# a branch name since we'd keep getting updates as long as there are new
+# commits to that branch and one of them can break the build
 FROM adoptopenjdk/openjdk11@sha256:13475f4be7d6701a2ebd0516c4c929f2fa78ea773b4483bb580a36a04975e9f9
 
 # Apache Thrift version

Original file line number	Diff line number	Diff line change
`@@ -88,7 +88,7 @@ task updateDlsSubmodule(type: Exec) {`
`88`	`88`	`compileThrift {`
`89`	`89`	`dependsOn updateDlsSubmodule`
`90`	`90`	`verbose true`
`91`		`- sourceItems "./src/main/idls/thrift/cadence.thrift","./src/main/idls/thrift/shared.thrift","./src/main/idls/thrift/shadower.thrift"`
	`91`	`+ sourceItems "${projectDir}/src/main/idls/thrift/cadence.thrift","${projectDir}/src/main/idls/thrift/shared.thrift","${projectDir}/src/main/idls/thrift/shadower.thrift"`
`92`	`92`	`}`
`93`	`93`
`94`	`94`	`compileJava {`