feat: remove derive feature from arbitrary support (#63)

* feat: remove derive feature from arbitrary support

* test: expand allowed string lengths in prop test

turns out 1018.0 PiB can be generated

Author: robjtede

Cargo.lock

@@ -20,7 +20,7 @@ arbitrary = ["dep:arbitrary"]
 serde = ["dep:serde"]
 
 [dependencies]
-arbitrary = { version = "1", features = ["derive"], optional = true }
+arbitrary = { version = "1", optional = true }
 serde = { version = "1", optional = true }
 
 [dev-dependencies]

Cargo.toml

@@ -0,0 +1,13 @@
+use arbitrary::{Arbitrary, Unstructured};
+
+use crate::ByteSize;
+
+impl Arbitrary<'_> for ByteSize {
+    fn arbitrary(u: &mut Unstructured<'_>) -> arbitrary::Result<Self> {
+        Ok(ByteSize(u64::arbitrary(u)?))
+    }
+
+    fn size_hint(depth: usize) -> (usize, Option<usize>) {
+        u64::size_hint(depth)
+    }
+}

src/arbitrary.rs

@@ -40,6 +40,8 @@
 //! assert_eq!(ByteSize::gb(996), minus);
 //! ```
 
+#[cfg(feature = "arbitrary")]
+mod arbitrary;
 mod parse;
 #[cfg(feature = "serde")]
 mod serde;
@@ -136,7 +138,6 @@ pub fn pib<V: Into<u64>>(size: V) -> u64 {
 
 /// Byte size representation
 #[derive(Copy, Clone, PartialEq, PartialOrd, Eq, Ord, Hash, Default)]
-#[cfg_attr(feature = "arbitrary", derive(arbitrary::Arbitrary))]
 pub struct ByteSize(pub u64);
 
 impl ByteSize {
@@ -400,7 +401,7 @@ mod property_tests {
         }
 
         fn to_string_never_large(size: ByteSize) -> bool {
-            size.to_string().len() < 10
+            size.to_string().len() < 11
         }
 
         // // currently fails on input like "14.0 EiB"