Skip to content

Commit 1f19d96

Browse files
authored
threads: rename thread.hw_concurrency to thread.available_parallelism (#2043)
This propagates @sunfishcode's renaming of the built-in upstream (see [#419]) to these crates. [#419]: WebAssembly/component-model#419
1 parent 59b0020 commit 1f19d96

File tree

18 files changed

+41
-41
lines changed

18 files changed

+41
-41
lines changed

crates/wasm-encoder/src/component/builder.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -379,9 +379,9 @@ impl ComponentBuilder {
379379
inc(&mut self.core_funcs)
380380
}
381381

382-
/// Declares a new `thread.hw_concurrency` intrinsic.
383-
pub fn thread_hw_concurrency(&mut self) -> u32 {
384-
self.canonical_functions().thread_hw_concurrency();
382+
/// Declares a new `thread.available_parallelism` intrinsic.
383+
pub fn thread_available_parallelism(&mut self) -> u32 {
384+
self.canonical_functions().thread_available_parallelism();
385385
inc(&mut self.core_funcs)
386386
}
387387

crates/wasm-encoder/src/component/canonicals.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,7 @@ impl CanonicalFunctionSection {
169169

170170
/// Defines a function which will return the number of threads that can be
171171
/// expected to execute concurrently.
172-
pub fn thread_hw_concurrency(&mut self) -> &mut Self {
172+
pub fn thread_available_parallelism(&mut self) -> &mut Self {
173173
self.bytes.push(0x06);
174174
self.num_added += 1;
175175
self

crates/wasm-encoder/src/reencode/component.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -964,8 +964,8 @@ pub mod component_utils {
964964
let func_ty = reencoder.type_index(func_ty_index);
965965
section.thread_spawn(func_ty);
966966
}
967-
wasmparser::CanonicalFunction::ThreadHwConcurrency => {
968-
section.thread_hw_concurrency();
967+
wasmparser::CanonicalFunction::ThreadAvailableParallelism => {
968+
section.thread_available_parallelism();
969969
}
970970
wasmparser::CanonicalFunction::TaskBackpressure => {
971971
section.task_backpressure();

crates/wasmparser/src/readers/component/canonicals.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ pub enum CanonicalFunction {
7474
},
7575
/// A function which returns the number of threads that can be expected to
7676
/// execute concurrently
77-
ThreadHwConcurrency,
77+
ThreadAvailableParallelism,
7878
/// A function which tells the host to enable or disable backpressure for
7979
/// the caller's instance.
8080
TaskBackpressure,
@@ -272,7 +272,7 @@ impl<'a> FromReader<'a> for CanonicalFunction {
272272
0x05 => CanonicalFunction::ThreadSpawn {
273273
func_ty_index: reader.read()?,
274274
},
275-
0x06 => CanonicalFunction::ThreadHwConcurrency,
275+
0x06 => CanonicalFunction::ThreadAvailableParallelism,
276276
0x08 => CanonicalFunction::TaskBackpressure,
277277
0x09 => CanonicalFunction::TaskReturn {
278278
result: match reader.read_u8()? {

crates/wasmparser/src/validator.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1307,8 +1307,8 @@ impl Validator {
13071307
crate::CanonicalFunction::ThreadSpawn { func_ty_index } => {
13081308
current.thread_spawn(func_ty_index, types, offset, features)
13091309
}
1310-
crate::CanonicalFunction::ThreadHwConcurrency => {
1311-
current.thread_hw_concurrency(types, offset, features)
1310+
crate::CanonicalFunction::ThreadAvailableParallelism => {
1311+
current.thread_available_parallelism(types, offset, features)
13121312
}
13131313
crate::CanonicalFunction::TaskBackpressure => {
13141314
current.task_backpressure(types, offset, features)

crates/wasmparser/src/validator/component.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1733,7 +1733,7 @@ impl ComponentState {
17331733
Ok(())
17341734
}
17351735

1736-
pub fn thread_hw_concurrency(
1736+
pub fn thread_available_parallelism(
17371737
&mut self,
17381738
types: &mut TypeAlloc,
17391739
offset: usize,
@@ -1742,7 +1742,7 @@ impl ComponentState {
17421742
if !features.shared_everything_threads() {
17431743
bail!(
17441744
offset,
1745-
"`thread.hw_concurrency` requires the shared-everything-threads proposal"
1745+
"`thread.available_parallelism` requires the shared-everything-threads proposal"
17461746
)
17471747
}
17481748

crates/wasmprinter/src/component.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -902,11 +902,11 @@ impl Printer<'_, '_> {
902902
self.end_group()?;
903903
state.core.funcs += 1;
904904
}
905-
CanonicalFunction::ThreadHwConcurrency => {
905+
CanonicalFunction::ThreadAvailableParallelism => {
906906
self.start_group("core func ")?;
907907
self.print_name(&state.core.func_names, state.core.funcs)?;
908908
self.result.write_str(" ")?;
909-
self.start_group("canon thread.hw_concurrency")?;
909+
self.start_group("canon thread.available_parallelism")?;
910910
self.end_group()?;
911911
self.end_group()?;
912912
state.core.funcs += 1;

crates/wast/src/component/binary.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -353,9 +353,9 @@ impl<'a> Encoder<'a> {
353353
self.core_func_names.push(name);
354354
self.funcs.thread_spawn(info.ty.into());
355355
}
356-
CanonicalFuncKind::ThreadHwConcurrency(_info) => {
356+
CanonicalFuncKind::ThreadAvailableParallelism(_info) => {
357357
self.core_func_names.push(name);
358-
self.funcs.thread_hw_concurrency();
358+
self.funcs.thread_available_parallelism();
359359
}
360360
CanonicalFuncKind::TaskBackpressure => {
361361
self.core_func_names.push(name);

crates/wast/src/component/expand.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -269,7 +269,7 @@ impl<'a> Expander<'a> {
269269
| CanonicalFuncKind::ResourceRep(_)
270270
| CanonicalFuncKind::ResourceDrop(_)
271271
| CanonicalFuncKind::ThreadSpawn(_)
272-
| CanonicalFuncKind::ThreadHwConcurrency(_)
272+
| CanonicalFuncKind::ThreadAvailableParallelism(_)
273273
| CanonicalFuncKind::TaskBackpressure
274274
| CanonicalFuncKind::TaskReturn(_)
275275
| CanonicalFuncKind::TaskWait(_)
@@ -338,12 +338,12 @@ impl<'a> Expander<'a> {
338338
name: func.name,
339339
kind: CanonicalFuncKind::ThreadSpawn(info),
340340
}),
341-
CoreFuncKind::ThreadHwConcurrency(info) => {
341+
CoreFuncKind::ThreadAvailableParallelism(info) => {
342342
ComponentField::CanonicalFunc(CanonicalFunc {
343343
span: func.span,
344344
id: func.id,
345345
name: func.name,
346-
kind: CanonicalFuncKind::ThreadHwConcurrency(info),
346+
kind: CanonicalFuncKind::ThreadAvailableParallelism(info),
347347
})
348348
}
349349
CoreFuncKind::TaskBackpressure => ComponentField::CanonicalFunc(CanonicalFunc {

crates/wast/src/component/func.rs

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ pub enum CoreFuncKind<'a> {
5252
ResourceDrop(CanonResourceDrop<'a>),
5353
ResourceRep(CanonResourceRep<'a>),
5454
ThreadSpawn(CanonThreadSpawn<'a>),
55-
ThreadHwConcurrency(CanonThreadHwConcurrency),
55+
ThreadAvailableParallelism(CanonThreadAvailableParallelism),
5656
TaskBackpressure,
5757
TaskReturn(CanonTaskReturn<'a>),
5858
TaskWait(CanonTaskWait<'a>),
@@ -100,8 +100,8 @@ impl<'a> Parse<'a> for CoreFuncKind<'a> {
100100
Ok(CoreFuncKind::ResourceRep(parser.parse()?))
101101
} else if l.peek::<kw::thread_spawn>()? {
102102
Ok(CoreFuncKind::ThreadSpawn(parser.parse()?))
103-
} else if l.peek::<kw::thread_hw_concurrency>()? {
104-
Ok(CoreFuncKind::ThreadHwConcurrency(parser.parse()?))
103+
} else if l.peek::<kw::thread_available_parallelism>()? {
104+
Ok(CoreFuncKind::ThreadAvailableParallelism(parser.parse()?))
105105
} else if l.peek::<kw::task_backpressure>()? {
106106
parser.parse::<kw::task_backpressure>()?;
107107
Ok(CoreFuncKind::TaskBackpressure)
@@ -341,7 +341,7 @@ pub enum CanonicalFuncKind<'a> {
341341
ResourceRep(CanonResourceRep<'a>),
342342

343343
ThreadSpawn(CanonThreadSpawn<'a>),
344-
ThreadHwConcurrency(CanonThreadHwConcurrency),
344+
ThreadAvailableParallelism(CanonThreadAvailableParallelism),
345345

346346
TaskBackpressure,
347347
TaskReturn(CanonTaskReturn<'a>),
@@ -509,11 +509,11 @@ impl<'a> Parse<'a> for CanonThreadSpawn<'a> {
509509

510510
/// Information relating to the `thread.spawn` intrinsic.
511511
#[derive(Debug)]
512-
pub struct CanonThreadHwConcurrency;
512+
pub struct CanonThreadAvailableParallelism;
513513

514-
impl<'a> Parse<'a> for CanonThreadHwConcurrency {
514+
impl<'a> Parse<'a> for CanonThreadAvailableParallelism {
515515
fn parse(parser: Parser<'a>) -> Result<Self> {
516-
parser.parse::<kw::thread_hw_concurrency>()?;
516+
parser.parse::<kw::thread_available_parallelism>()?;
517517
Ok(Self)
518518
}
519519
}

crates/wast/src/component/resolve.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -386,7 +386,7 @@ impl<'a> Resolver<'a> {
386386
CanonicalFuncKind::ThreadSpawn(info) => {
387387
self.resolve_ns(&mut info.ty, Ns::CoreType)?;
388388
}
389-
CanonicalFuncKind::ThreadHwConcurrency(_)
389+
CanonicalFuncKind::ThreadAvailableParallelism(_)
390390
| CanonicalFuncKind::TaskBackpressure
391391
| CanonicalFuncKind::TaskYield(_)
392392
| CanonicalFuncKind::SubtaskDrop
@@ -964,7 +964,7 @@ impl<'a> ComponentState<'a> {
964964
| CanonicalFuncKind::ResourceRep(_)
965965
| CanonicalFuncKind::ResourceDrop(_)
966966
| CanonicalFuncKind::ThreadSpawn(_)
967-
| CanonicalFuncKind::ThreadHwConcurrency(_)
967+
| CanonicalFuncKind::ThreadAvailableParallelism(_)
968968
| CanonicalFuncKind::TaskBackpressure
969969
| CanonicalFuncKind::TaskReturn(_)
970970
| CanonicalFuncKind::TaskWait(_)

crates/wast/src/lib.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -555,7 +555,7 @@ pub mod kw {
555555
custom_keyword!(import_info = "import-info");
556556
custom_keyword!(thread);
557557
custom_keyword!(thread_spawn = "thread.spawn");
558-
custom_keyword!(thread_hw_concurrency = "thread.hw_concurrency");
558+
custom_keyword!(thread_available_parallelism = "thread.available_parallelism");
559559
custom_keyword!(task_backpressure = "task.backpressure");
560560
custom_keyword!(task_return = "task.return");
561561
custom_keyword!(task_wait = "task.wait");

src/bin/wasm-tools/dump.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -419,7 +419,7 @@ impl<'a> Dump<'a> {
419419
| CanonicalFunction::ResourceDrop { .. }
420420
| CanonicalFunction::ResourceRep { .. }
421421
| CanonicalFunction::ThreadSpawn { .. }
422-
| CanonicalFunction::ThreadHwConcurrency => {
422+
| CanonicalFunction::ThreadAvailableParallelism => {
423423
("core func", &mut i.core_funcs)
424424
}
425425
CanonicalFunction::TaskBackpressure

tests/local/missing-features/component-model/shared-everything-threads-builtins.wast

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,6 @@
88

99
(assert_invalid
1010
(component
11-
(core func $concurrency (canon thread.hw_concurrency))
11+
(core func $parallelism (canon thread.available_parallelism))
1212
)
13-
"`thread.hw_concurrency` requires the shared-everything-threads proposal")
13+
"`thread.available_parallelism` requires the shared-everything-threads proposal")

tests/local/shared-everything-threads/builtins.wast

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,24 +3,24 @@
33
(component
44
(core type $start (shared (func (param $context i32))))
55
(core func $spawn (canon thread.spawn $start))
6-
(core func $concurrency (canon thread.hw_concurrency))
6+
(core func $parallelism (canon thread.available_parallelism))
77
)
88

99
(component
1010
(core type $start (shared (func (param $context i32))))
1111
(core func $spawn (canon thread.spawn $start))
12-
(core func $concurrency (canon thread.hw_concurrency))
12+
(core func $parallelism (canon thread.available_parallelism))
1313

1414
(core module $m
1515
(type $st (shared (func (param $context i32))))
1616
(import "" "spawn" (func (param (ref null $st)) (param i32) (result i32)))
17-
(import "" "concurrency" (func (result i32)))
17+
(import "" "parallelism" (func (result i32)))
1818
)
1919

2020
(core instance (instantiate $m
2121
(with "" (instance
2222
(export "spawn" (func $spawn))
23-
(export "concurrency" (func $concurrency))
23+
(export "parallelism" (func $parallelism))
2424
))
2525
))
2626
)

tests/snapshots/local/missing-features/component-model/shared-everything-threads-builtins.wast.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"line": 10,
1414
"filename": "shared-everything-threads-builtins.1.wasm",
1515
"module_type": "binary",
16-
"text": "`thread.hw_concurrency` requires the shared-everything-threads proposal"
16+
"text": "`thread.available_parallelism` requires the shared-everything-threads proposal"
1717
}
1818
]
1919
}
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
(component
22
(core type $start (;0;) (shared (func (param i32))))
33
(core func $spawn (;0;) (canon thread.spawn $start))
4-
(core func $concurrency (;1;) (canon thread.hw_concurrency))
4+
(core func $parallelism (;1;) (canon thread.available_parallelism))
55
)

tests/snapshots/local/shared-everything-threads/builtins.wast/1.print

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,17 @@
11
(component
22
(core type $start (;0;) (shared (func (param i32))))
33
(core func $spawn (;0;) (canon thread.spawn $start))
4-
(core func $concurrency (;1;) (canon thread.hw_concurrency))
4+
(core func $parallelism (;1;) (canon thread.available_parallelism))
55
(core module $m (;0;)
66
(type $st (;0;) (shared (func (param i32))))
77
(type (;1;) (func (param (ref null $st) i32) (result i32)))
88
(type (;2;) (func (result i32)))
99
(import "" "spawn" (func (;0;) (type 1)))
10-
(import "" "concurrency" (func (;1;) (type 2)))
10+
(import "" "parallelism" (func (;1;) (type 2)))
1111
)
1212
(core instance (;0;)
1313
(export "spawn" (func $spawn))
14-
(export "concurrency" (func $concurrency))
14+
(export "parallelism" (func $parallelism))
1515
)
1616
(core instance (;1;) (instantiate $m
1717
(with "" (instance 0))

0 commit comments

Comments
 (0)