Merge branch 'release/0.13.0'

Author: Kevin Hellemun

.github/ISSUE_TEMPLATE.md

@@ -7,9 +7,17 @@
 ## What happens:
 1.
 
-## Logs
-- Logs
+## Traceback
+[//]: # (If there is a traceback please share it in a quote! You can do this by pasting the traceback text, highlighting it and pressing the quote button.)
 
-## Extra info:
-- Tested on
+## SDK version and environment
+- Tested on [0.12.4](https://github.com/bunq/sdk_csharp/releases/tag/0.12.4)
+- [ ] Sandbox
+- [ ] Production
+
+## Response id
+[//]: # (If this error has something to do with a request that fails, please provide the response id of the request.)
+- Response id:
 
+## Extra info:
+[//]: # (Please provide any other relevant information here)

.github/PULL_REQUEST_TEMPLATE.md

@@ -0,0 +1,8 @@
+[//]: # (Thanks for opening this pull request! Before you proceed please make sure that you have an issue that explains what this pull request will do.
+         Make sure that all your commits link to this issue e.g. "My commit. \(bunq/sdk_csharp#<issue nr>\)".
+         If this pull request is changing files that are located in "BunqSdk/Model/Generated" then this pull request will be closed as these files must/can only be changed on bunq's side.)
+         
+## This PR closes/fixes the following issues:
+[//]: # (If for some reason your pull request does not require a test case you can just mark this box as checked and explain why it does not require a test case.)
+ - Closes bunq/sdk_csharp#
+    - [ ] Tested

.idea/.idea.BunqSdk/.idea/contentModel.xml

@@ -0,0 +1,25 @@
+autobranch:
+  pattern: 'bunq/sdk_csharp#{number}-{title}'
+  length: 100
+commit:
+  message:
+    patterns:
+      - '([A-Za-z0-9 ]+)\. (\(bunq\/sdk_csharp#[0-9]+\))'
+specification:
+  title:
+    minimum-length:
+      enabled: true
+      length: 8
+  body:
+    minimum-length:
+      enabled: true
+      length: 8
+    contains-url: true
+    contains-issue-number: true
+  template:
+    differs-from-body: true
+pull-request:
+  labels:
+    additional: true
+    required:
+      - Can be merged

.zappr.yaml

@@ -16,16 +16,16 @@ public class AttachmentPublicSample : ISample
 
         public void Run()
         {
-            var apiContext = ApiContext.Restore();
+            BunqContext.LoadApiContext(ApiContext.Restore());
             var customHeaders =
                 new Dictionary<string, string>
                 {
                     {ApiClient.HEADER_CONTENT_TYPE, CONTENT_TYPE_IMAGE_JPEG},
                     {ApiClient.HEADER_ATTACHMENT_DESCRIPTION, DESCRIPTION_TEST_JPG_ATTACHMENT}
                 };
             var requestBytes = File.ReadAllBytes(PATH_ATTACHMENT_IN);
-            var uuid = AttachmentPublic.Create(apiContext, requestBytes, customHeaders).Value;
-            var responseBytes = AttachmentPublicContent.List(apiContext, uuid).Value;
+            var uuid = AttachmentPublic.Create(requestBytes, customHeaders).Value;
+            var responseBytes = AttachmentPublicContent.List(uuid).Value;
             var fileOut = new FileInfo(PATH_ATTACHMENT_OUT);
             fileOut.Directory.Create();
             File.WriteAllBytes(fileOut.FullName, responseBytes);

BunqSdk.Samples/AttachmentPublicSample.cs

@@ -14,23 +14,23 @@ public class CardDebitSample : ISample
         private const string POINTER_TYPE_EMAIL = "EMAIL";
         private const string EMAIL_YOUR_COMPANY = "at@at.at"; // Put your user email here
         private const string POINTER_NAME_TEST = "test pointer";
+        private const string CARD_PIN_ASSIGNMENT_TYPE_PRIMARY = "PRIMARY";
         private const int USER_ITEM_ID = 0; // Put your user ID here
+        private const int MONETARY_ACCOUNT_ID = 0; // Put your monetaryAccount ID here
 
         public void Run()
         {
-            var apiContext = ApiContext.Restore();
-            var requestMap = new Dictionary<string, object>
-            {
-                {CardDebit.FIELD_NAME_ON_CARD, NAME_YOUR_COMPANY},
-                {CardDebit.FIELD_SECOND_LINE, GenerateRandomSecondLine()},
-                {CardDebit.FIELD_PIN_CODE, PIN_CODE},
-                {
-                    CardDebit.FIELD_ALIAS,
-                    new Pointer(POINTER_TYPE_EMAIL, EMAIL_YOUR_COMPANY) {Name = POINTER_NAME_TEST}
-                },
-            };
+            BunqContext.LoadApiContext(ApiContext.Restore());
+            var cardPinAssignment = new CardPinAssignment(
+                CARD_PIN_ASSIGNMENT_TYPE_PRIMARY,
+                PIN_CODE,
+                MONETARY_ACCOUNT_ID
+            );
+            var allCardPinAssignments = new List<CardPinAssignment> {cardPinAssignment};
 
-            Console.WriteLine(CardDebit.Create(apiContext, requestMap, USER_ITEM_ID));
+            Console.WriteLine(CardDebit.Create(GenerateRandomSecondLine(), NAME_YOUR_COMPANY,
+                new Pointer(POINTER_TYPE_EMAIL, EMAIL_YOUR_COMPANY) {Name = POINTER_NAME_TEST},
+                pinCodeAssignment: allCardPinAssignments));
         }
 
         private static string GenerateRandomSecondLine()
@@ -40,4 +40,4 @@ private static string GenerateRandomSecondLine()
             return random.Next(0, (int) Math.Pow(10, 21) - 1).ToString();
         }
     }
-}
+}

BunqSdk.Samples/CardDebitSample.cs

@@ -35,7 +35,7 @@ public class CustomerStatementExportSample : ISample
 
         public void Run()
         {
-            var apiContext = ApiContext.Restore();
+            BunqContext.LoadApiContext(ApiContext.Restore());
             var timeSpanWeek = new TimeSpan(
                 DAYS_IN_WEEK,
                 TIME_UNIT_COUNT_NONE,
@@ -45,31 +45,18 @@ public void Run()
             var dateStart = DateTime.Now.Subtract(timeSpanWeek);
             var dateEnd = DateTime.Now;
 
-            var customerStatementMap = new Dictionary<string, object>
-            {
-                {CustomerStatementExport.FIELD_STATEMENT_FORMAT, STATEMENT_FORMAT},
-                {CustomerStatementExport.FIELD_DATE_START, dateStart.ToString(FORMAT_DATE_STATEMENT)},
-                {CustomerStatementExport.FIELD_DATE_END, dateEnd.ToString(FORMAT_DATE_STATEMENT)},
-            };
+            var userId = BunqContext.UserContext.UserId;
 
-            var userId = User.List(apiContext).Value[INDEX_FIRST].UserCompany.Id;
+            var userIdInt = userId;
+            var monetaryAccountId = BunqContext.UserContext.PrimaryMonetaryAccountBank.Id.Value;
 
-            if (userId != null)
-            {
-                var userIdInt = (int) userId;
-                var monetaryAccountId = MonetaryAccountBank.List(apiContext, userIdInt).Value[INDEX_FIRST].Id;
+                var monetaryAccountIdInt = monetaryAccountId;
+                var customerStatementId = CustomerStatementExport.Create(STATEMENT_FORMAT,
+                    dateStart.ToString(FORMAT_DATE_STATEMENT), dateEnd.ToString(FORMAT_DATE_STATEMENT)).Value;
 
-                if (monetaryAccountId != null)
-                {
-                    var monetaryAccountIdInt = (int) monetaryAccountId;
-                    var customerStatementId = CustomerStatementExport.Create(apiContext, customerStatementMap,
-                        userIdInt, monetaryAccountIdInt).Value;
+                CustomerStatementExport.Delete(customerStatementId);
 
-                    CustomerStatementExport.Delete(apiContext, userIdInt, monetaryAccountIdInt, customerStatementId);
-                }
-            }
-
-            apiContext.Save();
+            BunqContext.ApiContext.Save();
         }
     }
-}
+}

BunqSdk.Samples/CustomerStatementExportSample.cs

@@ -7,14 +7,11 @@ namespace Bunq.Sdk.Samples
 {
     public class MonetaryAccountSample : ISample
     {
-        private const int USER_ITEM_ID = 0; // Put your user ID here
-        private const int MONETARY_ACCOUNT_ITEM_ID = 0; // Put your monetary account ID here
-
         public void Run()
         {
-            var apiContext = ApiContext.Restore();
-            var monetaryAccount = MonetaryAccount.Get(apiContext, USER_ITEM_ID, MONETARY_ACCOUNT_ITEM_ID).Value;
-            Console.WriteLine(monetaryAccount.MonetaryAccountBank);
+            BunqContext.LoadApiContext(ApiContext.Restore());
+            var monetaryAccount = BunqContext.UserContext.PrimaryMonetaryAccountBank;
+            Console.WriteLine(monetaryAccount);
         }
     }
 }

BunqSdk.Samples/MonetaryAccountSample.cs

@@ -1,6 +1,7 @@
 using System;
 using System.Collections.Generic;
 using Bunq.Sdk.Context;
+using Bunq.Sdk.Model.Core;
 using Bunq.Sdk.Model.Generated.Endpoint;
 using Bunq.Sdk.Model.Generated.Object;
 using Bunq.Sdk.Samples.Utils;
@@ -14,8 +15,6 @@ public class PaymentBatchSample : ISample
         private const string COUNTERPARTY_POINTER_TYPE = "EMAIL";
         private const string COUNTERPARTY_EMAIL = "bravo@bunq.com";
         private const string PAYMENT_DESCRIPTION = "This is a generated payment batch!";
-        private const int USER_ITEM_ID = 0; // Put your user ID here
-        private const int MONETARY_ACCOUNT_ITEM_ID = 0; // Put your monetary account ID here
 
         public void Run()
         {
@@ -38,11 +37,18 @@ public void Run()
                     }
                 }
             };
+            var allPayment = new List<Payment>();
+            var payment = new Payment
+            {
+                Amount = new Amount(PAYMENT_AMOUNT, PAYMENT_CURRENCY),
+                CounterpartyAlias =
+                    new MonetaryAccountReference(new Pointer(COUNTERPARTY_POINTER_TYPE, COUNTERPARTY_EMAIL)),
+                Description = PAYMENT_DESCRIPTION
+            };
 
-            var paymentBatchId = PaymentBatch.Create(apiContext, paymentBatchMap, USER_ITEM_ID,
-                MONETARY_ACCOUNT_ITEM_ID).Value;
+            var paymentBatchId = PaymentBatch.Create(allPayment).Value;
 
-            Console.WriteLine(PaymentBatch.Get(apiContext, USER_ITEM_ID, MONETARY_ACCOUNT_ITEM_ID, paymentBatchId));
+            Console.WriteLine(PaymentBatch.Get(paymentBatchId));
         }
     }
 }

BunqSdk.Samples/PaymentBatchSample.cs

@@ -21,30 +21,22 @@ public class PaymentListSample : ISample
         /// </summary>
         private const int PAGE_SIZE = 3;
 
-        /// <summary>
-        /// Constants to be changed to run the example.
-        /// </summary>
-        private const int USER_ITEM_ID = 0; // Put your user ID here
-        private const int MONETARY_ACCOUNT_ITEM_ID = 0; // Put your monetary account ID here
-
         public void Run()
         {
-            var apiContext = ApiContext.Restore();
+            BunqContext.LoadApiContext(ApiContext.Restore());
             var paginationCountOnly = new Pagination
             {
                 Count = PAGE_SIZE,
             };
             Console.WriteLine(MESSAGE_LATEST_PAGE_IDS);
-            var paymentResponse = Payment.List(apiContext, USER_ITEM_ID, MONETARY_ACCOUNT_ITEM_ID,
-                paginationCountOnly.UrlParamsCountOnly);
+            var paymentResponse = Payment.List(urlParams: paginationCountOnly.UrlParamsCountOnly);
             PrintPayments(paymentResponse.Value);
             var pagination = paymentResponse.Pagination;
 
             if (pagination.HasPreviousPage())
             {
                 Console.WriteLine(MESSAGE_SECOND_LATEST_PAGE_IDS);
-                var previousPaymentResponse = Payment.List(apiContext, USER_ITEM_ID, MONETARY_ACCOUNT_ITEM_ID,
-                    pagination.UrlParamsPreviousPage);
+                var previousPaymentResponse = Payment.List(urlParams: pagination.UrlParamsPreviousPage);
                 PrintPayments(previousPaymentResponse.Value);
             }
             else

BunqSdk.Samples/PaymentListSample.cs

@@ -19,24 +19,15 @@ public class PaymentSample : ISample
 
         public void Run()
         {
-            var apiContext = ApiContext.Restore();
-            var paymentMap = new Dictionary<string, object>
-            {
-                {Payment.FIELD_AMOUNT, new Amount(PAYMENT_AMOUNT, PAYMENT_CURRENCY)},
-                {
-                    Payment.FIELD_COUNTERPARTY_ALIAS,
-                    new Pointer(COUNTERPARTY_POINTER_TYPE, COUNTERPARTY_EMAIL)
-                },
-                {Payment.FIELD_DESCRIPTION, PAYMENT_DESCRIPTION}
-            };
+            BunqContext.LoadApiContext(ApiContext.Restore());
+            var paymentId = Payment.Create(new Amount(PAYMENT_AMOUNT, PAYMENT_CURRENCY),
+                new Pointer(COUNTERPARTY_POINTER_TYPE, COUNTERPARTY_EMAIL), PAYMENT_DESCRIPTION).Value;
 
-            var paymentId = Payment.Create(apiContext, paymentMap, USER_ITEM_ID, MONETARY_ACCOUNT_ITEM_ID).Value;
+            Console.WriteLine(Payment.Get(paymentId));
 
-            Console.WriteLine(Payment.Get(apiContext, USER_ITEM_ID, MONETARY_ACCOUNT_ITEM_ID, paymentId));
-            
             // Save the API context to account for all the changes that might have occurred to it
             // during the sample execution
-            apiContext.Save();
+            BunqContext.ApiContext.Save();
         }
     }
-}
+}