Skip to content

Commit a45ce63

Browse files
committed
switch order of configure values for PullRequest and PullRequest/Comments
Users would more commonly be interested in changing the bodyType rather than apiVersion Also, added missing @param values
1 parent 8380ce4 commit a45ce63

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

lib/Github/Api/PullRequest.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,9 @@ class PullRequest extends AbstractApi
2121
*
2222
* @link https://developer.github.com/v3/pulls/#custom-media-types
2323
* @param string|null $bodyType
24+
* @param string|null $apiVersion
2425
*/
25-
public function configure($apiVersion = null, $bodyType = null)
26+
public function configure($bodyType = null, $apiVersion = null)
2627
{
2728
if (!in_array($apiVersion, array('polaris-preview'))) {
2829
$apiVersion = $this->client->getApiVersion();

lib/Github/Api/PullRequest/Comments.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,9 @@ class Comments extends AbstractApi
1919
*
2020
* @link https://developer.github.com/v3/pulls/comments/#custom-media-types
2121
* @param string|null $bodyType
22+
* @param string|null @apiVersion
2223
*/
23-
public function configure($apiVersion = null, $bodyType = null)
24+
public function configure($bodyType = null, $apiVersion = null)
2425
{
2526
if (!in_array($apiVersion, array('squirrel-girl-preview'))) {
2627
$apiVersion = $this->client->getApiVersion();

0 commit comments

Comments
 (0)