fix premature exit of test process on windows

Author: bholloway

packages/test-my-cli/operations/exec.js

@@ -63,7 +63,7 @@ exports.create = (command) => {
     )),
     withTime(({index, root, caller, cwd, env, meta}, {onActivity}) =>
       new Promise((resolve) => {
-        let stdout = '', stderr = '', interval = 0;
+        let stdout = '', stderr = '', interval = 0, caughtError = null;
         const child = spawn(cmd, args, {cwd, env, shell: true, stdio: 'pipe'});
         addOrRemove(true);
 
@@ -72,8 +72,8 @@ exports.create = (command) => {
           const field = isAdd ? 'addListener' : 'removeListener';
           child.stdout[field]('data', onStdout);
           child.stderr[field]('data', onStderr);
-          child.on('exit', onExit);
-          child.on('error', onError);
+          child[field]('error', onError);
+          child[field]('close', onClose);
 
           if (isAdd) {
             child.stdout.setEncoding('utf8');
@@ -92,14 +92,16 @@ exports.create = (command) => {
           stderr += data;
         }
 
-        function onExit(code) {
-          addOrRemove(false);
-          resolve({index, root, caller, cwd, env, meta, code, stdout, stderr});
+        function onError(error) {
+          caughtError = error;
         }
 
-        function onError(error) {
+        function onClose(code) {
           addOrRemove(false);
-          resolve({index, root, caller, cwd, env, meta, code: 1, stdout, stderr: error.toString()});
+          resolve({
+            index, root, caller, cwd, env, meta, code, stdout,
+            stderr: caughtError ? caughtError.toString() : stderr
+          });
         }
       })
     ),

test/index.js

@@ -10,7 +10,7 @@ const tape = require('blue-tape');
 const {init, layer, cwd, fs, env, meta, exec} = require('test-my-cli');
 const {assign} = Object;
 
-const {assertExitCodeZero, bail} = require('./lib/assert');
+const {assertExitCodeZero, bail, saveOutput} = require('./lib/assert');
 const {testBase} = require('./cases/common/test');
 
 // tests are located in resolve-url-loader package which might differ from package under test
@@ -88,9 +88,11 @@ filterTests()
             PATH: dirname(process.execPath)
           }),
           exec('enforce-node-version'),
+          saveOutput('enforce-node-version'),
           assertExitCodeZero('enforce node version'),
           bail,
           exec('npm install'),
+          saveOutput('npm-install'),
           assertExitCodeZero('npm install'),
           bail
         )

test/lib/assert/util.js

@@ -3,4 +3,4 @@
 const {join, relative} = require('path');
 
 exports.subdir = ({root, cwd, env: {OUTPUT}}) =>
-  relative(root, join(cwd, OUTPUT));
+  relative(root, join(cwd, OUTPUT || '.'));