Skip to content

Commit 20ee544

Browse files
committed
Address comments, clean up WORKSPACE.template
1 parent 25db5f6 commit 20ee544

File tree

2 files changed

+9
-53
lines changed

2 files changed

+9
-53
lines changed

scala/BUILD

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -31,17 +31,17 @@ java_import(
3131
_declare_scalac_provider(
3232
name = "scala_default",
3333
default_classpath = [
34-
"@io_bazel_rules_scala_scala_library//:io_bazel_rules_scala_scala_library",
35-
"@io_bazel_rules_scala_scala_reflect//:io_bazel_rules_scala_scala_reflect",
34+
"@io_bazel_rules_scala_scala_library",
35+
"@io_bazel_rules_scala_scala_reflect",
3636
],
3737
default_macro_classpath = [
38-
"@io_bazel_rules_scala_scala_library//:io_bazel_rules_scala_scala_library",
39-
"@io_bazel_rules_scala_scala_reflect//:io_bazel_rules_scala_scala_reflect",
38+
"@io_bazel_rules_scala_scala_library",
39+
"@io_bazel_rules_scala_scala_reflect",
4040
],
4141
default_repl_classpath = [
42-
"@io_bazel_rules_scala_scala_library//:io_bazel_rules_scala_scala_library",
43-
"@io_bazel_rules_scala_scala_reflect//:io_bazel_rules_scala_scala_reflect",
44-
"@io_bazel_rules_scala_scala_compiler//:io_bazel_rules_scala_scala_compiler",
42+
"@io_bazel_rules_scala_scala_library",
43+
"@io_bazel_rules_scala_scala_reflect",
44+
"@io_bazel_rules_scala_scala_compiler",
4545
],
4646
scalac = "@io_bazel_rules_scala//src/java/io/bazel/rulesscala/scalac",
4747
visibility = ["//visibility:public"],

test_version/WORKSPACE.template

Lines changed: 2 additions & 46 deletions
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,6 @@ load("@io_bazel_rules_scala//tut_rule:tut.bzl", "tut_repositories")
2424

2525
tut_repositories(scala_version)
2626

27-
load("@io_bazel_rules_scala//jmh:jmh.bzl", "jmh_repositories")
28-
29-
jmh_repositories()
30-
3127
load("@io_bazel_rules_scala//scala_proto:scala_proto.bzl", "scala_proto_repositories")
3228

3329
scala_proto_repositories(scala_version)
@@ -36,53 +32,13 @@ load("@io_bazel_rules_scala//specs2:specs2_junit.bzl", "specs2_junit_repositorie
3632

3733
specs2_junit_repositories(scala_version)
3834

39-
load("@io_bazel_rules_scala//scala:scala_cross_version.bzl", "scala_mvn_artifact")
35+
load("@io_bazel_rules_scala//scala:toolchains.bzl", "scala_register_toolchains")
4036

41-
maven_jar(
42-
name = "org_apache_commons_commons_lang_3_5",
43-
artifact = "org.apache.commons:commons-lang3:3.5",
44-
sha1 = "6c6c702c89bfff3cd9e80b04d668c5e190d588c6",
45-
)
37+
scala_register_toolchains()
4638

4739
http_archive(
4840
name = "com_google_protobuf",
4941
sha256 = "118ac276be0db540ff2a89cecc5dfb9606d4d16e91cc4ea8883ae8160acb5163",
5042
strip_prefix = "protobuf-0456e269ee6505766474aa8d7b8bba7ac047f457",
5143
urls = ["https://github.com/google/protobuf/archive/0456e269ee6505766474aa8d7b8bba7ac047f457.zip"],
5244
)
53-
54-
http_archive(
55-
name = "com_google_protobuf_java",
56-
sha256 = "118ac276be0db540ff2a89cecc5dfb9606d4d16e91cc4ea8883ae8160acb5163",
57-
strip_prefix = "protobuf-0456e269ee6505766474aa8d7b8bba7ac047f457",
58-
urls = ["https://github.com/google/protobuf/archive/0456e269ee6505766474aa8d7b8bba7ac047f457.zip"],
59-
)
60-
61-
load("@io_bazel_rules_scala//scala:toolchains.bzl", "scala_register_toolchains")
62-
63-
scala_register_toolchains()
64-
65-
load("@io_bazel_rules_scala//scala:scala_maven_import_external.bzl", "scala_maven_import_external", "java_import_external")
66-
67-
scala_maven_import_external(
68-
name = "com_google_guava_guava_21_0",
69-
artifact = "com.google.guava:guava:21.0",
70-
jar_sha256 = "972139718abc8a4893fa78cba8cf7b2c903f35c97aaf44fa3031b0669948b480",
71-
licenses = ["notice"], # Apache 2.0
72-
server_urls = ["https://mirror.bazel.build/repo1.maven.org/maven2"],
73-
)
74-
75-
# bazel's java_import_external has been altered in rules_scala to be a macro based on jvm_import_external
76-
# in order to allow for other jvm-language imports (e.g. scala_import)
77-
# the 3rd-party dependency below is using the java_import_external macro
78-
# in order to make sure no regression with the original java_import_external
79-
load("@io_bazel_rules_scala//scala:scala_maven_import_external.bzl", "java_import_external")
80-
81-
java_import_external(
82-
name = "org_apache_commons_commons_lang_3_5_without_file",
83-
generated_linkable_rule_name = "linkable_org_apache_commons_commons_lang_3_5_without_file",
84-
jar_sha256 = "8ac96fc686512d777fca85e144f196cd7cfe0c0aec23127229497d1a38ff651c",
85-
jar_urls = ["http://central.maven.org/maven2/org/apache/commons/commons-lang3/3.5/commons-lang3-3.5.jar"],
86-
licenses = ["notice"], # Apache 2.0
87-
neverlink = True,
88-
)

0 commit comments

Comments
 (0)