Allow disabling ShellCheck while running

Author: skovhus

server/src/server.ts

@@ -132,16 +132,18 @@ export default class BashServer {
      * register capabilities. The initialized notification may only be sent once.
      */
     connection.onInitialized(async () => {
-      const { config: newConfig, environmentVariablesUsed } =
+      const { config: environmentConfig, environmentVariablesUsed } =
         config.getConfigFromEnvironmentVariables()
-      this.config = newConfig
-
-      if (environmentVariablesUsed.length > 0) {
-        connection.console.warn(
-          `Environment variable configuration is being deprecated, please use workspace configuration. The following environment variables were used: ${environmentVariablesUsed.join(
-            ', ',
-          )}`,
-        )
+      if (environmentConfig) {
+        this.updateConfiguration(environmentConfig)
+
+        if (environmentVariablesUsed.length > 0) {
+          connection.console.warn(
+            `Environment variable configuration is being deprecated, please use workspace configuration. The following environment variables were used: ${environmentVariablesUsed.join(
+              ', ',
+            )}`,
+          )
+        }
       }
 
       if (hasConfigurationCapability) {
@@ -158,16 +160,6 @@ export default class BashServer {
         this.connection.console.log('Configuration loaded from client')
       }
 
-      const { shellcheckPath } = this.config
-      if (!shellcheckPath) {
-        connection.console.info('ShellCheck linting is disabled.')
-      } else {
-        this.linter = new Linter({
-          console: connection.console,
-          executablePath: shellcheckPath,
-        })
-      }
-
       initialized = true
       if (currentDocument) {
         // If we already have a document, analyze it now that we're initialized
@@ -212,6 +204,20 @@ export default class BashServer {
 
         if (!isDeepStrictEqual(this.config, newConfig)) {
           this.config = newConfig
+
+          const { shellcheckPath } = this.config
+          if (!shellcheckPath) {
+            this.connection.console.log(
+              'ShellCheck linting is disabled as "shellcheckPath" was not set',
+            )
+            this.linter = undefined
+          } else {
+            this.linter = new Linter({
+              console: this.connection.console,
+              executablePath: shellcheckPath,
+            })
+          }
+
           return true
         }
       } catch (err) {