Skip to content

Commit d272cb2

Browse files
JimmysceneBlake Easley
authored and
Blake Easley
committed
Update release-client.sh script
Update vscde to latest version (vsce is depresated in favor of @vscode/vsce) Add --skip-duplicate flag, this allows us to fail silently if the version already exists on the marketplace, which was why we had the "|| echo" before, but it also hid real failures, so IMO this is a better way to handle that Also update snapshot, since I moved `tagRelease` to the next line, one of the tests failed
1 parent ef231a9 commit d272cb2

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

scripts/release-client.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,5 +13,5 @@ pnpm verify:bail
1313

1414
cd vscode-client
1515

16-
# NOTE: it would be much nicer if we could detect which version was deployed...
17-
npx vsce@1.103.1 publish -p $VSCE_TOKEN && tagRelease $tag || echo 'Deploy failed, probably there was no changes'
16+
npx @vscode/vsce@2.26.0 publish --skip-duplicate -p $VSCE_TOKEN
17+
tagRelease $tag || echo "Tag update failed, likely already exists"

server/src/__tests__/__snapshots__/server.test.ts.snap

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -653,11 +653,11 @@ exports[`server onRenameRequest Workspace-wide rename returns correct WorkspaceE
653653
"newText": "newName",
654654
"range": {
655655
"end": {
656-
"character": 53,
656+
"character": 10,
657657
"line": 16,
658658
},
659659
"start": {
660-
"character": 43,
660+
"character": 0,
661661
"line": 16,
662662
},
663663
},

0 commit comments

Comments
 (0)