Added test for segment ignore

Author: stijndehaes

docs/configurations.rst

@@ -92,7 +92,7 @@ Supported strategies are:
 
 * RUNTIME_ERROR: throw an SegmentNotFoundException
 * LOG_ERROR: log an error and continue
-* IGNORE: will do nothing
+* IGNORE: do nothing
 
 Segment Dynamic Naming
 ----------------------

tests/ext/aiohttp/test_client.py

@@ -3,6 +3,7 @@
 
 from aws_xray_sdk.core import xray_recorder
 from aws_xray_sdk.core.async_context import AsyncContext
+from aws_xray_sdk.core.context import MISSING_SEGMENT_MSG
 from aws_xray_sdk.core.exceptions.exceptions import SegmentNotFoundException
 from aws_xray_sdk.ext.util import strip_url, get_hostname
 from aws_xray_sdk.ext.aiohttp.client import aws_xray_trace_config
@@ -144,7 +145,7 @@ async def test_no_segment_raise(loop, recorder):
                 pass
 
 
-async def test_no_segment_not_raise(loop, recorder):
+async def test_no_segment_log_error(loop, recorder, capsys):
     xray_recorder.configure(context_missing='LOG_ERROR')
     trace_config = aws_xray_trace_config()
     status_code = 200
@@ -155,3 +156,20 @@ async def test_no_segment_not_raise(loop, recorder):
 
     # Just check that the request was done correctly
     assert status_received == status_code
+    captured = capsys.readouterr()
+    assert MISSING_SEGMENT_MSG in captured.out
+
+
+async def test_no_segment_ignore(loop, recorder, capsys):
+    xray_recorder.configure(context_missing='IGNORE')
+    trace_config = aws_xray_trace_config()
+    status_code = 200
+    url = 'http://{}/status/{}?foo=bar'.format(BASE_URL, status_code)
+    async with ClientSession(loop=loop, trace_configs=[trace_config]) as session:
+        async with session.get(url) as resp:
+            status_received = resp.status
+
+    # Just check that the request was done correctly
+    assert status_received == status_code
+    captured = capsys.readouterr()
+    assert MISSING_SEGMENT_MSG not in captured.out