fix(credential-provider-node): handle string value AWS_EC2_METADATA_DISABLED=false (#6823)

upsetbit · web-flow · commit 9ad490a5cb2a · 2025-01-28T13:52:49.000-08:00
Setting the environment variable `AWS_EC2_METADATA_DISABLED` to
"false" causes the condition to evaluate as `true`, which disables
the IMDS credentials check.
diff --git a/packages/credential-provider-node/src/remoteProvider.ts b/packages/credential-provider-node/src/remoteProvider.ts
@@ -24,7 +24,7 @@ export const remoteProvider = async (
     return chain(fromHttp(init), fromContainerMetadata(init));
   }
 
-  if (process.env[ENV_IMDS_DISABLED]) {
+  if (process.env[ENV_IMDS_DISABLED] && process.env[ENV_IMDS_DISABLED] !== "false") {
     return async () => {
       throw new CredentialsProviderError("EC2 Instance Metadata Service access disabled", { logger: init.logger });
     };

Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,7 @@ export const remoteProvider = async (`
`24`	`24`	`return chain(fromHttp(init), fromContainerMetadata(init));`
`25`	`25`	`}`
`26`	`26`
`27`		`- if (process.env[ENV_IMDS_DISABLED]) {`
	`27`	`+ if (process.env[ENV_IMDS_DISABLED] && process.env[ENV_IMDS_DISABLED] !== "false") {`
`28`	`28`	`return async () => {`
`29`	`29`	`throw new CredentialsProviderError("EC2 Instance Metadata Service access disabled", { logger: init.logger });`
`30`	`30`	`};`