Updated retry policy behavior. #1681
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1681 +/- ##
============================================
- Coverage 75.35% 75.21% -0.15%
Complexity 1446 1446
============================================
Files 1057 1065 +8
Lines 31517 31703 +186
Branches 2427 2441 +14
============================================
+ Hits 23749 23844 +95
- Misses 6578 6643 +65
- Partials 1190 1216 +26
Continue to review full report at Codecov.
|
zoewangg
reviewed
Mar 4, 2020
core/sdk-core/src/main/java/software/amazon/awssdk/core/internal/capacity/TokenBucket.java
Show resolved
Hide resolved
core/sdk-core/src/main/java/software/amazon/awssdk/core/internal/capacity/TokenBucket.java
Outdated
Show resolved
Hide resolved
| @@ -37,10 +36,10 @@ | |||
| private final ExecutionAttributes executionAttributes; | |||
|
|
|||
| private ExecutionContext(final Builder builder) { | |||
| this.signer = Validate.paramNotNull(builder.signer, "signer"); | |||
There was a problem hiding this comment.
Why did we remove those validations?
There was a problem hiding this comment.
I added them originally, but in hindsight they just made testing more difficult.
I ended up not needing them removed, because I changed the way I was testing this change, so I could add them back in again.
...re/src/main/java/software/amazon/awssdk/core/retry/conditions/TokenBucketRetryCondition.java
Outdated
Show resolved
Hide resolved
core/sdk-core/src/main/java/software/amazon/awssdk/core/retry/conditions/RetryCondition.java
Show resolved
Hide resolved
millems
force-pushed
the
millem/retry-improvements
branch
from
130e421 to
f68b47e
Compare
zoewangg
reviewed
Mar 5, 2020
core/aws-core/src/main/java/software/amazon/awssdk/awscore/retry/AwsRetryPolicy.java
Outdated
Show resolved
Hide resolved
core/sdk-core/src/main/java/software/amazon/awssdk/core/retry/RetryPolicy.java
Outdated
Show resolved
Hide resolved
codegen/src/main/java/software/amazon/awssdk/codegen/poet/builder/BaseClientBuilderClass.java
Show resolved
Hide resolved
...va/software/amazon/awssdk/core/internal/http/pipeline/stages/utils/RetryableStageHelper.java
Show resolved
Hide resolved
...in/java/software/amazon/awssdk/core/retry/conditions/TokenBucketExceptionCostCalculator.java
Outdated
Show resolved
Hide resolved
...re/src/main/java/software/amazon/awssdk/core/retry/conditions/TokenBucketRetryCondition.java
Outdated
Show resolved
Hide resolved
...re/src/main/java/software/amazon/awssdk/core/retry/conditions/TokenBucketRetryCondition.java
Show resolved
Hide resolved
...va/software/amazon/awssdk/core/internal/http/pipeline/stages/utils/RetryableStageHelper.java
Show resolved
Hide resolved
zoewangg
reviewed
Mar 5, 2020
...ed-classes-test/src/test/java/software/amazon/awssdk/services/retry/ClientRetryModeTest.java
Outdated
Show resolved
Hide resolved
millems
force-pushed
the
millem/retry-improvements
branch
2 times, most recently
from
c541587 to
d1c2a59
Compare
zoewangg
reviewed
Mar 6, 2020
core/sdk-core/src/main/java/software/amazon/awssdk/core/retry/conditions/OrRetryCondition.java
Outdated
Show resolved
Hide resolved
millems
force-pushed
the
millem/retry-improvements
branch
2 times, most recently
from
2a1862c to
b4dbc44
Compare
zoewangg
approved these changes
Mar 6, 2020
1. Added support for "retry modes". A retry mode allows configuring multiple SDK parameters at once using default retry profiles, some of which are standardized between AWS SDK languages. See RetryMode javadoc for more information. 2. Added the ability to configure or disable the default retry throttling behavior of the SDK that 'kicks in' during a large volume of retriable service call errors. This behavior can now be configured via `RetryPolicy.retryCapacityCondition`. 3. Fixed an issue where the retry condition returned by `RetryPolicy.retryCondition` differed from the one specified by `RetryPolicy.Builder.retryCondition`. The old value can be accessed via the new `RetryPolicy.aggregateRetryCondition`. 4. Fixed an issue where specifying your own retry policy would override AWS and service-specific retry conditions. By default, all retry policies now have AWS and service-specific retry conditions added. This can be disabled via the new `RetryPolicy.furtherRefinementsAllowed(false)`.
millems
force-pushed
the
millem/retry-improvements
branch
from
3799a64 to
329cd60
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
aws-sdk-java-automation
added a commit
that referenced
this pull request
Sep 9, 2021
…071cdf421 Pull request: release <- staging/3ba8be65-dc3b-4f8e-9b75-ee8071cdf421
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RetryPolicy.retryCapacityCondition.RetryPolicy.retryConditiondiffered from the one specified byRetryPolicy.Builder.retryCondition. The old value can be accessed via the newRetryPolicy.aggregateRetryCondition.RetryPolicy.furtherRefinementsAllowed(false).