Skip to content

Dynamodb-enhanced [preview]: Updates all operations with consumer sty… #1662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 24, 2020

Conversation

bmaizels
Copy link
Contributor

#1654 was rolled back due to a bug in a single test (AsyncBatchWriteItemTest.mixedCommands).

This is the PR that puts that change back in with the fix to that single test.

WriteBatch.builder(Record2.class)
.mappedTableResource(mappedTable2)
.addDeleteItem(i -> i.key(Key.create(numberValue(0))))
.build())).join();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the line that was changed from the original PR.

@bmaizels bmaizels requested a review from spfink February 24, 2020 19:52
@bmaizels bmaizels force-pushed the bmaizels/ddbmapper-consumer-operations-fixed branch 2 times, most recently from 1c4a62d to c663711 Compare February 24, 2020 22:06
@bmaizels bmaizels force-pushed the bmaizels/ddbmapper-consumer-operations-fixed branch from d0e02bd to da5a15e Compare February 24, 2020 22:29
@codecov-io
Copy link

codecov-io commented Feb 24, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@dfe5c06). Click here to learn what that means.
The diff coverage is 71.34%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1662   +/-   ##
=========================================
  Coverage          ?   74.49%           
  Complexity        ?      813           
=========================================
  Files             ?      949           
  Lines             ?    29908           
  Branches          ?     2340           
=========================================
  Hits              ?    22280           
  Misses            ?     6510           
  Partials          ?     1118
Flag Coverage Δ Complexity Δ
#unittests 74.49% <71.34%> (?) 813 <37> (?)
Impacted Files Coverage Δ Complexity Δ
...s/dynamodb/mappingclient/model/ConditionCheck.java 11.62% <ø> (ø) 2 <0> (?)
...appingclient/model/CreateTableEnhancedRequest.java 64.86% <ø> (ø) 7 <0> (?)
...mappingclient/model/UpdateItemEnhancedRequest.java 64.28% <ø> (ø) 7 <0> (?)
...db/mappingclient/model/PutItemEnhancedRequest.java 70% <ø> (ø) 6 <0> (?)
...ons/dynamodb/mappingclient/DynamoDbAsyncIndex.java 0% <0%> (ø) 0 <0> (?)
...dynamodb/mappingclient/DynamoDbEnhancedClient.java 11.11% <0%> (ø) 1 <0> (?)
...ons/dynamodb/mappingclient/DynamoDbAsyncTable.java 0% <0%> (ø) 0 <0> (?)
...tensions/dynamodb/mappingclient/DynamoDbTable.java 0% <0%> (ø) 0 <0> (?)
...odb/mappingclient/DynamoDbEnhancedAsyncClient.java 0% <0%> (ø) 0 <0> (?)
...tensions/dynamodb/mappingclient/DynamoDbIndex.java 0% <0%> (ø) 0 <0> (?)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfe5c06...da5a15e. Read the comment docs.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 1 Code Smell

No Coverage information No Coverage information
No Duplication information No Duplication information

@bmaizels bmaizels merged commit 226e676 into master Feb 24, 2020
@bmaizels bmaizels deleted the bmaizels/ddbmapper-consumer-operations-fixed branch February 24, 2020 23:17
aws-sdk-java-automation pushed a commit that referenced this pull request Sep 3, 2021
Fixed issue where handler.prepare() was being invoked after credential resolution.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants