Skip to content

Add method to enable environment variable forward ProcessCredentialsProvider #4570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jaecktec
Copy link

@jaecktec jaecktec commented Oct 10, 2023

Addd support to forward environment variables fo ProcessCredentialsProvider, so context like proxy config can be passed to the process.

closes #5688

Motivation and Context

using aws_signing_helper in a locked down environment need proxy settings. Needing to support global proxy environment variables tend to be confusing

Modifications

added env method in builder that can be used to inject environment variables.
forwarded these variables so they are available when the process runs
changed the process scripts so they can also accept variables from environment

Testing

updated the tests, so they test the happy case when there are variables defined

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@jaecktec jaecktec marked this pull request as ready for review November 7, 2023 21:53
@jaecktec jaecktec requested a review from a team as a code owner November 7, 2023 21:53
@debora-ito
Copy link
Member

Closing. Read my comment in #5688.

@debora-ito debora-ito closed this Nov 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proxy support for ProcessCredentialsProvider
2 participants