Updated FinalizeNewService release script to be idempotent, allowing a service to be finalized multiple times without duplicate pom.xml entries.

Author: millems

release-scripts/src/main/java/software/amazon/awssdk/release/FinalizeNewServiceModuleMain.java

@@ -89,8 +89,7 @@ private AddSubmoduleTransformer(String serviceModuleName) {
             protected void updateDocument(Document doc) {
                 Node project = findChild(doc, "project");
                 Node modules = findChild(project, "modules");
-
-                modules.appendChild(textElement(doc, "module", serviceModuleName));
+                addChild(modules, textElement(doc, "module", serviceModuleName));
             }
         }
 
@@ -105,8 +104,7 @@ private AddDependencyTransformer(String serviceModuleName) {
             protected void updateDocument(Document doc) {
                 Node project = findChild(doc, "project");
                 Node dependencies = findChild(project, "dependencies");
-
-                dependencies.appendChild(sdkDependencyElement(doc, serviceModuleName));
+                addChild(dependencies, sdkDependencyElement(doc, serviceModuleName));
             }
         }
 
@@ -122,8 +120,7 @@ protected void updateDocument(Document doc) {
                 Node project = findChild(doc, "project");
                 Node dependencyManagement = findChild(project, "dependencyManagement");
                 Node dependencies = findChild(dependencyManagement, "dependencies");
-
-                dependencies.appendChild(sdkDependencyElement(doc, serviceModuleName));
+                addChild(dependencies, sdkDependencyElement(doc, serviceModuleName));
             }
         }
     }

release-scripts/src/main/java/software/amazon/awssdk/release/PomTransformer.java

@@ -74,6 +74,19 @@ protected final Node findChild(Node parent, String childName) {
         throw new IllegalArgumentException(parent + " has no child element named " + childName);
     }
 
+    protected final void addChild(Node parent, Element childToAdd) {
+        NodeList children = parent.getChildNodes();
+        for (int i = 0; i < children.getLength(); ++i) {
+            Node existingChild = children.item(i);
+            if (existingChild.isEqualNode(childToAdd)) {
+                // Child already exists, skip.
+                return;
+            }
+        }
+
+        parent.appendChild(childToAdd);
+    }
+
     protected final Element textElement(Document doc, String name, String value) {
         Element element = doc.createElement(name);
         element.setTextContent(value);