Skip to content

Commit 98eac61

Browse files
authored
Removes TODOs that aren't needed (#2698)
1 parent 49d7588 commit 98eac61

File tree

3 files changed

+3
-6
lines changed

3 files changed

+3
-6
lines changed

core/auth-crt/src/main/java/software/amazon/awssdk/authcrt/signer/internal/CrtHttpRequestConverter.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -147,15 +147,13 @@ private HttpHeader[] createHttpHeaderArray(SdkHttpFullRequest request) {
147147
return crtHeaderList.toArray(new HttpHeader[0]);
148148
}
149149

150-
//TODO When CRT can work with SDK format empty paths, this method can be removed
151150
private static String encodedPathToCrtFormat(String sdkEncodedPath) {
152151
if (StringUtils.isEmpty(sdkEncodedPath)) {
153152
return "/";
154153
}
155154
return sdkEncodedPath;
156155
}
157156

158-
//TODO When CRT can work with SDK empty paths, this method can be removed
159157
private static String encodedPathFromCrtFormat(String sdkEncodedPath, String crtEncodedPath) {
160158
if (SLASH.equals(crtEncodedPath) && StringUtils.isEmpty(sdkEncodedPath)) {
161159
return "";

core/aws-core/src/main/java/software/amazon/awssdk/awscore/internal/AwsExecutionContextBuilder.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,8 +56,8 @@ private AwsExecutionContextBuilder() {
5656
public static <InputT extends SdkRequest, OutputT extends SdkResponse> ExecutionContext
5757
invokeInterceptorsAndCreateExecutionContext(ClientExecutionParams<InputT, OutputT> executionParams,
5858
SdkClientConfiguration clientConfig) {
59-
// Note: This is currently copied to DefaultS3Presigner and other presigners. Don't edit this without considering those
60-
// as well. TODO: Probably don't copy all of this manually.
59+
// Note: This is currently copied to DefaultS3Presigner and other presigners.
60+
// Don't edit this without considering those
6161

6262
SdkRequest originalRequest = executionParams.getInput();
6363
MetricCollector metricCollector = resolveMetricCollector(executionParams);

core/sdk-core/src/main/java/software/amazon/awssdk/core/internal/handler/BaseClientHandler.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -171,8 +171,7 @@ private static InterceptorContext runModifyHttpRequestAndHttpContentInterceptors
171171
(OutputT) response.toBuilder().sdkHttpResponse(httpFullResponse).build());
172172
}
173173

174-
//TODO: Remove/throw exception when called. This method is only called from tests, since the subclasses
175-
// in aws-core override it.
174+
// This method is only called from tests, since the subclasses in aws-core override it.
176175
protected <InputT extends SdkRequest, OutputT extends SdkResponse> ExecutionContext
177176
invokeInterceptorsAndCreateExecutionContext(
178177
ClientExecutionParams<InputT, OutputT> params) {

0 commit comments

Comments
 (0)