Skip to content

Commit 8a7f1f2

Browse files
committed
Support Python 3.x for changelog scripts.
1 parent 7682ea1 commit 8a7f1f2

File tree

5 files changed

+10
-12
lines changed

5 files changed

+10
-12
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,3 +17,4 @@ target/
1717
**/dependency-reduced-pom.xml
1818

1919
*.pyc
20+
*.swp

scripts/changelog/util.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
import os
33
from datetime import date
44

5-
from model import ReleaseChanges, ChangelogEntry, Version
5+
from changelog.model import ReleaseChanges, ChangelogEntry, Version
66

77

88
def version_cmp(a,b):

scripts/changelog/writer.py

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
from git import stage_file
2-
from util import load_all_released_changes, load_unreleased_changes, version_cmp
3-
1+
from changelog.git import stage_file
2+
from changelog.util import load_all_released_changes, load_unreleased_changes, version_cmp
3+
from functools import cmp_to_key
44

55
class ChangelogWriter(object):
66
"""
@@ -48,10 +48,7 @@ def group_entries(self):
4848
self.categories.add(e.category)
4949

5050
def get_sorted_categories(self):
51-
def category_cmp(a,b):
52-
return cmp(a,b)
53-
54-
return sorted(list(self.categories), cmp=category_cmp)
51+
return sorted(list(self.categories))
5552

5653
def is_service_category(self,s):
5754
return s.lower() not in NON_SERVICE_CATEGORIES
@@ -106,7 +103,7 @@ def write(self, s):
106103
def write_changelog():
107104
unreleased = load_unreleased_changes(".changes/next-release")
108105
released = load_all_released_changes(".changes")
109-
released = sorted(released, key=lambda c: c.version, cmp=version_cmp)
106+
released = sorted(released, key=lambda c: [c.version.major, c.version.minor, c.version.patch, c.version.prerelease_version_number()], reverse=True)
110107

111108
if unreleased is not None:
112109
all_changes = [unreleased] + released
@@ -121,4 +118,4 @@ def write_changelog():
121118
for changes in all_changes:
122119
writer.write_changes(changes)
123120

124-
stage_file('CHANGELOG.md')
121+
stage_file('CHANGELOG.md')

scripts/finalize-release-changes

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import shutil
1010
from changelog.git import stage_file
1111
from changelog.util import load_unreleased_changes, marshall_release_changes, parse_version_string
1212

13-
VERSION_REGEX = re.compile('^[0-9]+\.[0-9]+\.[0-9]$')
13+
VERSION_REGEX = re.compile('^[0-9]+\.[0-9]+\.[0-9]+$')
1414
DATE_REGEX = re.compile('^[0-9]{4}-[0-9]{2}-[0-9]{2}$')
1515

1616
def validate_args(args):

scripts/new-change

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ def write_new_change(parsed_values):
139139
category = parsed_values['category']
140140
short_summary = ''.join(filter(lambda x: x in VALID_CHARS, category))
141141
contents = json.dumps(parsed_values, indent=4) + "\n"
142-
contents_digest = hashlib.sha1(contents).hexdigest()
142+
contents_digest = hashlib.sha1(contents.encode('utf-8')).hexdigest()
143143
filename = '{type_name}-{summary}-{digest}.json'.format(
144144
type_name=parsed_values['type'],
145145
summary=short_summary,

0 commit comments

Comments
 (0)