Skip to content

Commit 6a9207d

Browse files
authored
Merge pull request #1945 from aws/brawn_integ_test_fix
Create bucket of HttpChecksumIntegrationTest failing due to resuse of…
2 parents 263f57d + 7f8d97c commit 6a9207d

File tree

1 file changed

+20
-7
lines changed

1 file changed

+20
-7
lines changed

services/s3/src/it/java/software/amazon/awssdk/services/s3/checksum/HttpChecksumIntegrationTest.java

Lines changed: 20 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717

1818
import static org.assertj.core.api.Assertions.assertThat;
1919
import static org.assertj.core.api.Assertions.assertThatExceptionOfType;
20+
import static software.amazon.awssdk.testutils.service.S3BucketUtils.temporaryBucketName;
2021

2122
import java.io.BufferedReader;
2223
import java.io.InputStreamReader;
@@ -44,11 +45,12 @@
4445
import software.amazon.awssdk.services.s3.model.ChecksumMode;
4546
import software.amazon.awssdk.services.s3.model.GetObjectRequest;
4647
import software.amazon.awssdk.services.s3.model.GetObjectResponse;
48+
import software.amazon.awssdk.services.s3.model.NoSuchBucketException;
4749
import software.amazon.awssdk.services.s3.model.PutObjectRequest;
4850
import software.amazon.awssdk.services.s3.model.PutObjectResponse;
4951
import software.amazon.awssdk.services.s3.model.S3Exception;
5052
import software.amazon.awssdk.services.s3.utils.CaptureChecksumValidationInterceptor;
51-
import software.amazon.awssdk.services.s3.utils.S3TestUtils;
53+
import software.amazon.awssdk.testutils.Waiter;
5254

5355
public class HttpChecksumIntegrationTest extends S3IntegrationTestBase {
5456

@@ -57,18 +59,29 @@ public class HttpChecksumIntegrationTest extends S3IntegrationTestBase {
5759
public static CaptureChecksumValidationInterceptor interceptor = new CaptureChecksumValidationInterceptor();
5860
protected static S3Client s3Https;
5961
protected static S3AsyncClient s3HttpAsync;
60-
private static String BUCKET;
62+
private static String BUCKET = temporaryBucketName(HttpChecksumIntegrationTest.class);
6163

6264
@BeforeAll
6365
public static void setUp() throws Exception {
66+
67+
// Http Client to generate Signed request
6468
s3 = s3ClientBuilder().overrideConfiguration(o -> o.addExecutionInterceptor(interceptor))
65-
.build();
69+
.endpointOverride(URI.create("http://s3." + DEFAULT_REGION + ".amazonaws.com")).build();
70+
6671
s3Async = s3AsyncClientBuilder().overrideConfiguration(o -> o.addExecutionInterceptor(interceptor)).build();
67-
s3Https = s3ClientBuilder().overrideConfiguration(o -> o.addExecutionInterceptor(interceptor))
68-
.endpointOverride(URI.create("https://s3.us-west-2.amazonaws.com")).build();
72+
73+
s3Https = s3ClientBuilder().overrideConfiguration(o -> o.addExecutionInterceptor(interceptor)).build();
74+
75+
// Http Client to generate Signed request
6976
s3HttpAsync = s3AsyncClientBuilder().overrideConfiguration(o -> o.addExecutionInterceptor(interceptor))
70-
.endpointOverride(URI.create("http://s3.us-west-2.amazonaws.com")).build();
71-
BUCKET = S3TestUtils.getTestBucket(s3);
77+
.endpointOverride(URI.create("http://s3." + DEFAULT_REGION + ".amazonaws.com")).build();
78+
79+
80+
createBucket(BUCKET);
81+
82+
Waiter.run(() -> s3.headBucket(r -> r.bucket(BUCKET)))
83+
.ignoringException(NoSuchBucketException.class)
84+
.orFail();
7285
interceptor.reset();
7386
}
7487

0 commit comments

Comments
 (0)