naming is hard

Author: josecorella

src/aws_encryption_sdk/internal/crypto/authentication.py

@@ -19,7 +19,7 @@
 from cryptography.hazmat.primitives.asymmetric import ec
 from cryptography.hazmat.primitives.asymmetric.utils import Prehashed
 
-from aws_encryption_sdk.internal.utils import verify_interface
+from aws_encryption_sdk.internal.utils import verify_ec_interface
 
 from ...exceptions import NotSupportedError
 from .elliptic_curve import (
@@ -48,7 +48,7 @@ def __init__(self, algorithm, key):
 
     def _set_signature_type(self):
         """Ensures that the algorithm signature type is a known type and sets a reference value."""
-        if not verify_interface(self.algorithm):
+        if not verify_ec_interface(self.algorithm):
             raise NotSupportedError("Unsupported signing algorithm info")
         return ec.EllipticCurve
 

src/aws_encryption_sdk/internal/crypto/elliptic_curve.py

@@ -20,7 +20,7 @@
 from cryptography.hazmat.primitives.asymmetric.utils import Prehashed, decode_dss_signature, encode_dss_signature
 from cryptography.utils import int_from_bytes, int_to_bytes
 
-from aws_encryption_sdk.internal.utils import verify_interface
+from aws_encryption_sdk.internal.utils import verify_ec_interface
 
 from ...exceptions import NotSupportedError
 from ..str_ops import to_bytes
@@ -185,6 +185,6 @@ def generate_ecc_signing_key(algorithm):
     :returns: Generated signing key
     :raises NotSupportedError: if signing algorithm is not supported on this platform
     """
-    if not verify_interface(algorithm):
+    if not verify_ec_interface(algorithm):
         raise NotSupportedError("Unsupported signing algorithm info")
     return ec.generate_private_key(curve=algorithm.signing_algorithm_info(), backend=default_backend())

src/aws_encryption_sdk/internal/utils/__init__.py

@@ -166,7 +166,7 @@ def source_data_key_length_check(source_data_key, algorithm):
         )
 
 
-def verify_interface(algorithm):
+def verify_ec_interface(algorithm):
     """Validates that the provided EllipticCurve Algorithm is correctly implemented by
     checking if it implements both of the abstract methods from the EllipticCurve
     abstract class.

test/unit/test_utils.py

@@ -20,8 +20,8 @@
 import aws_encryption_sdk.identifiers
 import aws_encryption_sdk.internal.utils
 from aws_encryption_sdk.exceptions import InvalidDataKeyError, SerializationError, UnknownIdentityError
-from aws_encryption_sdk.internal.defaults import MAX_FRAME_SIZE
-from aws_encryption_sdk.internal.utils import verify_interface
+from aws_encryption_sdk.internal.defaults import MAX_FRAME_SIZE, MESSAGE_ID_LENGTH
+from aws_encryption_sdk.internal.utils import verify_ec_interface
 from aws_encryption_sdk.structures import DataKey, EncryptedDataKey, MasterKeyInfo, RawDataKey
 
 from .test_values import VALUES
@@ -49,7 +49,7 @@ def test_verify_interface(patch_ec):
     mock_algorithm_info.return_value.key_size = True
     _algorithm = MagicMock(signing_algorithm_info=mock_algorithm_info)
 
-    implemented = verify_interface(algorithm=_algorithm)
+    implemented = verify_ec_interface(algorithm=_algorithm)
 
     assert implemented is True