chore: add integration tests for AWS KMS keyrings

Author: mattsb42-aws

test/integration/key_providers/__init__.py

@@ -0,0 +1,3 @@
+# Copyright Amazon.com Inc. or its affiliates. All Rights Reserved.
+# SPDX-License-Identifier: Apache-2.0
+"""Dummy stub to make linters work better."""

test/integration/key_providers/test_kms.py

@@ -0,0 +1,31 @@
+# Copyright Amazon.com Inc. or its affiliates. All Rights Reserved.
+# SPDX-License-Identifier: Apache-2.0
+"""Integration tests for ``aws_encryption_sdk.key_provider.kms``."""
+from test.integration.integration_test_utils import setup_kms_master_key_provider_with_botocore_session
+
+import pytest
+from botocore.exceptions import BotoCoreError
+
+from aws_encryption_sdk.key_providers.kms import KMSMasterKeyProvider
+
+pytestmark = [pytest.mark.integ]
+
+
+def test_remove_bad_client():
+    test = KMSMasterKeyProvider()
+    fake_region = "us-fakey-12"
+    test.add_regional_client(fake_region)
+
+    with pytest.raises(BotoCoreError):
+        test._regional_clients[fake_region].list_keys()
+
+    assert fake_region not in test._regional_clients
+
+
+def test_regional_client_does_not_modify_botocore_session(caplog):
+    mkp = setup_kms_master_key_provider_with_botocore_session()
+    fake_region = "us-fakey-12"
+
+    assert mkp.config.botocore_session.get_config_variable("region") != fake_region
+    mkp.add_regional_client(fake_region)
+    assert mkp.config.botocore_session.get_config_variable("region") != fake_region

test/integration/keyrings/__init__.py

@@ -0,0 +1,3 @@
+# Copyright Amazon.com Inc. or its affiliates. All Rights Reserved.
+# SPDX-License-Identifier: Apache-2.0
+"""Dummy stub to make linters work better."""

test/integration/keyrings/aws_kms/__init__.py

@@ -0,0 +1,3 @@
+# Copyright Amazon.com Inc. or its affiliates. All Rights Reserved.
+# SPDX-License-Identifier: Apache-2.0
+"""Dummy stub to make linters work better."""

test/integration/keyrings/aws_kms/test_client_cache.py

@@ -0,0 +1,48 @@
+# Copyright Amazon.com Inc. or its affiliates. All Rights Reserved.
+# SPDX-License-Identifier: Apache-2.0
+"""Integration tests for ``aws_encryption_sdk.keyrings.aws_kms.client_cache``."""
+import pytest
+from botocore.exceptions import BotoCoreError
+from botocore.session import Session
+
+from aws_encryption_sdk.keyrings.aws_kms.client_cache import ClientCache
+
+pytestmark = [pytest.mark.integ]
+
+
+def test_client_cache_removes_bad_client():
+    cache = ClientCache()
+    fake_region = "us-fake-1"
+
+    initial_client = cache.client(fake_region, "kms")
+
+    assert fake_region in cache._cache
+
+    with pytest.raises(BotoCoreError):
+        initial_client.encrypt(KeyId="foo", Plaintext=b"bar")
+
+    assert fake_region not in cache._cache
+
+
+def test_regional_client_does_not_modify_botocore_session():
+    cache = ClientCache(botocore_session=Session())
+    fake_region = "us-fake-1"
+
+    assert cache._botocore_session.get_config_variable("region") != fake_region
+    cache.client(fake_region, "kms")
+    assert cache._botocore_session.get_config_variable("region") != fake_region
+
+
+def test_client_cache_remove_bad_client_when_already_removed():
+    cache = ClientCache()
+    fake_region = "us-fake-1"
+
+    initial_client = cache.client(fake_region, "kms")
+
+    assert fake_region in cache._cache
+    del cache._cache[fake_region]
+
+    with pytest.raises(BotoCoreError):
+        initial_client.encrypt(KeyId="foo", Plaintext=b"bar")
+
+    assert fake_region not in cache._cache

test/requirements.txt

@@ -2,3 +2,4 @@ mock
 pytest>=3.3.1
 pytest-cov
 pytest-mock
+moto>=1.3.14