chore: update eslint rule to allow max 1 empty line (#25600)

There should be no reason to have back-to-back new lines which our current eslint rules allow. I made the rule stricter and fixed instances where we were breaking the stricter rule.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

Author: kaizencc

packages/@aws-cdk-testing/cli-integ/lib/aws.ts

@@ -185,7 +185,6 @@ type AwsCallIO<T> =
 type First<T> = T extends [any, any] ? T[0] : never;
 type Second<T> = T extends [any, any] ? T[1] : never;
 
-
 export function isStackMissingError(e: Error) {
   return e.message.indexOf('does not exist') > -1;
 }

packages/@aws-cdk-testing/cli-integ/lib/files.ts

@@ -45,7 +45,6 @@ export function findUp(name: string, directory: string = process.cwd()): string
   return findUp(name, path.dirname(absoluteDirectory));
 }
 
-
 /**
  * Docker-safe home directory
  */

packages/@aws-cdk-testing/cli-integ/lib/staging/parallel-shell.ts

@@ -2,7 +2,6 @@ import PQueue from 'p-queue';
 import { sleep } from '../aws';
 import { MemoryStream } from '../corking';
 
-
 export type ErrorResponse = 'fail' | 'skip' | 'retry';
 
 /**

packages/@aws-cdk-testing/cli-integ/lib/with-sam.ts

@@ -10,7 +10,6 @@ import { AwsContext, withAws } from './with-aws';
 import { cloneDirectory, installNpmPackages, TestFixture, DEFAULT_TEST_TIMEOUT_S } from './with-cdk-app';
 import { withTimeout } from './with-timeout';
 
-
 export interface ActionOutput {
   actionSucceeded?: boolean;
   actionOutput?: any;

packages/@aws-cdk-testing/cli-integ/test/xpmutex.test.ts

@@ -30,7 +30,6 @@ test('acquire waits', async () => {
   await secondProcess;
 });
 
-
 /**
  * Poll for some condition every 10ms
  */

packages/@aws-cdk-testing/cli-integ/tests/init-csharp/init-csharp.integtest.ts

@@ -13,4 +13,3 @@ import { integTest, withTemporaryDirectory, ShellHelper, withPackages } from '..
   })));
 });
 
-

packages/@aws-cdk-testing/framework-integ/test/aws-apigateway/test/authorizers/integ.token-authorizer.ts

@@ -27,7 +27,6 @@ const restapi = new RestApi(stack, 'MyRestApi', {
   },
 });
 
-
 restapi.root.addMethod('ANY', new MockIntegration({
   integrationResponses: [
     { statusCode: '200' },

packages/@aws-cdk-testing/framework-integ/test/aws-apigateway/test/integ.domain-name.ts

@@ -92,7 +92,6 @@ const api2 = new Api(testCase, 'IntegApi2', {
   path: 'items',
 });
 
-
 /**
  * Test 1
  *
@@ -151,7 +150,6 @@ secondDomain.addApiMapping(api2.restApi.deploymentStage, {
   basePath: 'orders/v2',
 });
 
-
 /**
  * Test 3
  *
@@ -177,7 +175,6 @@ thirdDomain.addBasePathMapping(api2.restApi, {
   basePath: 'v2',
 });
 
-
 /**
  * -------------------------------------------------------
  * ------------------------- THEN ------------------------

packages/@aws-cdk-testing/framework-integ/test/aws-apigateway/test/integ.method-grant-execute.ts

@@ -3,7 +3,6 @@ import * as cdk from 'aws-cdk-lib';
 import * as integ from '@aws-cdk/integ-tests-alpha';
 import * as apigw from 'aws-cdk-lib/aws-apigateway';
 
-
 const app = new cdk.App();
 const stack = new cdk.Stack(app, 'GrantExecute');
 

packages/@aws-cdk-testing/framework-integ/test/aws-appsync/test/integ.graphql-iam.ts

@@ -89,7 +89,6 @@ testDS.createResolver('MutationAddTest', {
 
 const lambdaIAM = new Role(stack, 'LambdaIAM', { assumedBy: new ServicePrincipal('lambda') });
 
-
 api.grant(lambdaIAM, IamResource.custom('types/Query/fields/getTests'), 'appsync:graphql');
 api.grant(lambdaIAM, IamResource.ofType('test'), 'appsync:GraphQL');
 api.grantMutation(lambdaIAM, 'addTest');

packages/@aws-cdk-testing/framework-integ/test/aws-appsync/test/integ.log-retention.ts

@@ -7,7 +7,6 @@ import { GraphqlApi, LogConfig, SchemaFile } from 'aws-cdk-lib/aws-appsync';
 const app = new App();
 const stack = new Stack(app, 'AppSyncIntegLogRetention');
 
-
 const retentionTime = RetentionDays.ONE_WEEK;
 const logConfig: LogConfig = {
   retention: retentionTime,

packages/@aws-cdk-testing/framework-integ/test/aws-autoscaling-hooktargets/test/integ.queue-hook.ts

@@ -53,7 +53,6 @@ const setDesired = integ.assertions.awsApiCall('AutoScaling', 'setDesiredCapacit
   DesiredCapacity: 1,
 });
 
-
 const message = integ.assertions.awsApiCall('SQS', 'receiveMessage', {
   QueueUrl: testCase.queueUrl,
 });

packages/@aws-cdk-testing/framework-integ/test/aws-cloudformation/test/integ.core-cross-region-references.ts

@@ -77,7 +77,6 @@ const integ = new IntegTest(app, 'cross-region-references', {
   stackUpdateWorkflow: false,
 });
 
-
 /**
  * Test that if the references are still in use, deleting the producer
  * stack will fail

packages/@aws-cdk-testing/framework-integ/test/aws-cloudfront/test/integ.cloudfront-cross-region-cert.ts

@@ -32,7 +32,6 @@ const cloudFrontStack = new cdk.Stack(app, 'integ-cloudfront-stack', {
   crossRegionReferences: true,
 });
 
-
 const hostedZone = route53.PublicHostedZone.fromHostedZoneAttributes(acmStack, 'HostedZone', {
   hostedZoneId,
   zoneName: hostedZoneName,

packages/@aws-cdk-testing/framework-integ/test/aws-cloudfront/test/integ.distribution-logbucket.ts

@@ -3,7 +3,6 @@ import { TestOrigin } from './test-origin';
 import * as cloudfront from 'aws-cdk-lib/aws-cloudfront';
 import * as integ from '@aws-cdk/integ-tests-alpha';
 
-
 const app = new cdk.App();
 const stack = new cdk.Stack(app, 'integ-distribution-logbucket');
 

packages/@aws-cdk-testing/framework-integ/test/aws-cloudtrail/test/integ.cloudtrail-insight.ts

@@ -38,7 +38,6 @@ new cloudtrail.Trail(stack, 'Trail', {
   ],
 });
 
-
 new integ.IntegTest(app, 'aws-cdk-cloudtrail-inshights', {
   testCases: [stack],
 });

packages/@aws-cdk-testing/framework-integ/test/aws-cloudwatch-actions/test/integ.ssm-incident-alarm-action.ts

@@ -37,7 +37,6 @@ class SsmIncidentAlarmActionIntegrationTestStack extends Stack {
 
     responsePlan.node.addDependency(replicationSet);
 
-
     const metric = new cloudwatch.Metric({
       namespace: 'CDK/Test',
       metricName: 'Metric',

packages/@aws-cdk-testing/framework-integ/test/aws-codebuild/test/integ.asset-build-spec.ts

@@ -28,7 +28,6 @@ getBuildProject.assertAtPath(
   ExpectedResult.stringLikeRegexp('.+'),
 );
 
-
 const getBuildProjectBuildSpecArn = getBuildProject.getAttString('projects.0.source.buildspec');
 
 // Assert that the buildspec for the project is in fact an S3 object arn

packages/@aws-cdk-testing/framework-integ/test/aws-codedeploy/test/lambda/integ.deployment-group.ts

@@ -4,7 +4,6 @@ import * as lambda from 'aws-cdk-lib/aws-lambda';
 import * as cdk from 'aws-cdk-lib';
 import * as codedeploy from 'aws-cdk-lib/aws-codedeploy';
 
-
 const app = new cdk.App();
 const stack = new cdk.Stack(app, 'aws-cdk-codedeploy-lambda');
 

packages/@aws-cdk-testing/framework-integ/test/aws-codepipeline-actions/test/integ.pipeline-s3-deploy.ts

@@ -92,7 +92,6 @@ getObjectCall.provider.addToRolePolicy({
   Resource: ['*'],
 });
 
-
 const putObjectCall = integ.assertions.awsApiCall('S3', 'putObject', {
   Bucket: bucket.bucketName,
   Key: 'key',

packages/@aws-cdk-testing/framework-integ/test/aws-codepipeline-actions/test/integ.pipeline-with-replication.ts

@@ -6,7 +6,6 @@ import { App, Stack, RemovalPolicy } from 'aws-cdk-lib';
 import { IntegTest } from '@aws-cdk/integ-tests-alpha';
 import { S3SourceAction, CodeBuildAction } from 'aws-cdk-lib/aws-codepipeline-actions';
 
-
 const app = new App({
   treeMetadata: false,
 });
@@ -23,7 +22,6 @@ const stack2 = new Stack(app, 'integ-pipeline-consumer-stack', {
   crossRegionReferences: true,
 });
 
-
 const key = new Key(stack1, 'ReplicationKey');
 const bucket = new Bucket(stack1, 'ReplicationBucket', {
   encryptionKey: key,

packages/@aws-cdk-testing/framework-integ/test/aws-cognito/test/integ.user-pool-idp.google.ts

@@ -2,7 +2,6 @@ import { Secret } from 'aws-cdk-lib/aws-secretsmanager';
 import { App, CfnOutput, RemovalPolicy, Stack } from 'aws-cdk-lib';
 import { ProviderAttribute, UserPool, UserPoolIdentityProviderGoogle } from 'aws-cdk-lib/aws-cognito';
 
-
 /*
  * Stack verification steps
  * * Visit the URL provided by stack output 'SignInLink' in a browser, and verify the 'Google' sign in link shows up.

packages/@aws-cdk-testing/framework-integ/test/aws-config/test/integ.rule.ts

@@ -32,7 +32,6 @@ driftRule.onComplianceChange('ComplianceChange', {
   target: new targets.SnsTopic(complianceTopic),
 });
 
-
 new integ.IntegTest(app, 'aws-cdk-config-rule-integ', {
   testCases: [stack],
 });

packages/@aws-cdk-testing/framework-integ/test/aws-dynamodb/test/integ.global-replicas-provisioned.ts

@@ -21,5 +21,4 @@ new IntegTest(app, 'aws-cdk-dynamodb-global-replicas-provisioned-test', {
   testCases: [stack],
 });
 
-
 app.synth();

packages/@aws-cdk-testing/framework-integ/test/aws-ec2/test/import-certificates-handler/index.ts

@@ -24,7 +24,6 @@ export async function handler(event: AWSLambda.CloudFormationCustomResourceEvent
         }).promise();
       }
 
-
       return {
         Data: {
           ServerCertificateArn: serverImport?.CertificateArn,

packages/@aws-cdk-testing/framework-integ/test/aws-ec2/test/integ.client-vpn-endpoint.js.snapshot/asset.1ef463e71119677d383a964bbb0740f0c4de382c21d5a8d68be98334d514ae8a/index.ts

@@ -24,7 +24,6 @@ export async function handler(event: AWSLambda.CloudFormationCustomResourceEvent
         }).promise();
       }
 
-
       return {
         Data: {
           ServerCertificateArn: serverImport?.CertificateArn,

packages/@aws-cdk-testing/framework-integ/test/aws-ec2/test/integ.launch-template.ts

@@ -2,7 +2,6 @@ import * as cdk from 'aws-cdk-lib';
 import * as integ from '@aws-cdk/integ-tests-alpha';
 import * as ec2 from 'aws-cdk-lib/aws-ec2';
 
-
 const app = new cdk.App();
 
 const stack = new cdk.Stack(app, 'aws-cdk-ec2-lt-metadata-1');

packages/@aws-cdk-testing/framework-integ/test/aws-ec2/test/integ.machine-image.ts

@@ -8,7 +8,6 @@ import {
 import { Construct } from 'constructs';
 import { EC2_RESTRICT_DEFAULT_SECURITY_GROUP } from 'aws-cdk-lib/cx-api';
 
-
 export class TestCase extends Stack {
   constructor(scope: Construct, id: string, props?: StackProps) {
     super(scope, id, props);
@@ -32,7 +31,6 @@ export class TestCase extends Stack {
   }
 }
 
-
 const app = new App();
 new IntegTest(app, 'integ-test', {
   testCases: [new TestCase(app, 'integ-ec2-machine-image-test')],

packages/@aws-cdk-testing/framework-integ/test/aws-ec2/test/integ.prefix-list.ts

@@ -7,7 +7,6 @@ import {
 } from 'aws-cdk-lib';
 import { Construct } from 'constructs';
 
-
 export class TestCase extends Stack {
   constructor(scope: Construct, id: string, props?: StackProps) {
     super(scope, id, props);
@@ -20,7 +19,6 @@ export class TestCase extends Stack {
   }
 }
 
-
 const app = new App();
 new IntegTest(app, 'integ-test', {
   testCases: [new TestCase(app, 'integ-ec2-prefix-list-test')],

packages/@aws-cdk-testing/framework-integ/test/aws-ec2/test/integ.vpc-flow-logs-customformat.ts

@@ -6,7 +6,6 @@ import { EC2_RESTRICT_DEFAULT_SECURITY_GROUP } from 'aws-cdk-lib/cx-api';
 
 const app = new App();
 
-
 class TestStack extends Stack {
   constructor(scope: App, id: string, props?: StackProps) {
     super(scope, id, props);
@@ -70,7 +69,6 @@ class TestStack extends Stack {
   }
 }
 
-
 new IntegTest(app, 'FlowLogs', {
   testCases: [
     new TestStack(app, 'FlowLogsTestStack'),

packages/@aws-cdk-testing/framework-integ/test/aws-ec2/test/integ.vpc-flow-logs-interval.ts

@@ -7,7 +7,6 @@ import { EC2_RESTRICT_DEFAULT_SECURITY_GROUP } from 'aws-cdk-lib/cx-api';
 
 const app = new App();
 
-
 class TestStack extends Stack {
   constructor(scope: App, id: string, props?: StackProps) {
     super(scope, id, props);
@@ -71,7 +70,6 @@ class TestStack extends Stack {
   }
 }
 
-
 new IntegTest(app, 'FlowLogs', {
   testCases: [
     new TestStack(app, 'FlowLogsTestStack'),

packages/@aws-cdk-testing/framework-integ/test/aws-ec2/test/integ.vpc-ipam.ts

@@ -82,4 +82,3 @@ integ.assertions.awsApiCall('EC2', 'describeVpcs', {
 
 app.synth();
 
-

packages/@aws-cdk-testing/framework-integ/test/aws-ecs-patterns/test/fargate/integ.healthchecks-multiple-network-load-balanced-fargate-service.ts

@@ -50,7 +50,6 @@ networkMultipleTargetGroupsFargateService.targetGroups[0].configureHealthCheck({
 
 networkMultipleTargetGroupsFargateService.targetGroups[1].configureHealthCheck({});
 
-
 new IntegTest(app, 'Integ', { testCases: [stack] });
 
 app.synth();

packages/@aws-cdk-testing/framework-integ/test/aws-ecs-patterns/test/fargate/integ.queue-processing-fargate-service-isolated.ts

@@ -24,7 +24,6 @@ const vpc = new ec2.Vpc(stack, 'VPC', {
   ],
 });
 
-
 vpc.addS3Endpoint('S3Endpoint', [{ subnetType: ec2.SubnetType.PRIVATE_ISOLATED }]);
 
 const securityGroup = new ec2.SecurityGroup(stack, 'MyCustomSG', {

packages/@aws-cdk-testing/framework-integ/test/aws-ecs-patterns/test/fargate/integ.runtime-platform-application-load-balanced-fargate-service.ts

@@ -10,7 +10,6 @@ import { ScheduledFargateTask } from 'aws-cdk-lib/aws-ecs-patterns';
 const app = new cdk.App();
 const stack = new cdk.Stack(app, 'aws-ecs-runtime-integ');
 
-
 const vpc = new ec2.Vpc(stack, 'Vpc', { maxAzs: 1, restrictDefaultSecurityGroup: false });
 const cluster = new ecs.Cluster(stack, 'FargateCluster', { vpc });
 

packages/@aws-cdk-testing/framework-integ/test/aws-ecs/test/ec2/integ.default-capacity-provider.ts

@@ -39,7 +39,6 @@ cluster.addDefaultCapacityProviderStrategy([
   { capacityProvider: 'FARGATE_SPOT', weight: 1 },
 ]);
 
-
 new ecs.Ec2Service(stack, 'EC2Service', {
   cluster,
   taskDefinition,

packages/@aws-cdk-testing/framework-integ/test/aws-ecs/test/fargate/integ.fargate-with-efs.ts

@@ -4,7 +4,6 @@ import * as cdk from 'aws-cdk-lib';
 import { Construct } from 'constructs';
 import * as ecs from 'aws-cdk-lib/aws-ecs';
 
-
 class FargateWithEfsStack extends cdk.Stack {
   constructor(scope: Construct, id: string, props?: cdk.StackProps) {
     super(scope, id, props);

packages/@aws-cdk-testing/framework-integ/test/aws-ecs/test/fargate/integ.runtime.ts

@@ -7,7 +7,6 @@ const stack = new cdk.Stack(app, 'aws-ecs-integ-runtime');
 
 const vpc = new ec2.Vpc(stack, 'Vpc', { maxAzs: 2, restrictDefaultSecurityGroup: false });
 
-
 const cluster = new ecs.Cluster(stack, 'FargateCluster', {
   vpc,
 });

packages/@aws-cdk-testing/framework-integ/test/aws-eks/test/integ.alb-controller.js.snapshot/asset.a21fb971385f0210c6b1c88a25f1b9986bae4e4e1bca8d4aa818c442e1878ddf/cluster.ts

@@ -7,7 +7,6 @@ import { EksClient, ResourceEvent, ResourceHandler } from './common';
 import { compareLoggingProps } from './compareLogging';
 import { IsCompleteResponse, OnEventResponse } from '../../../custom-resources/lib/provider-framework/types';
 
-
 const MAX_CLUSTER_NAME_LEN = 100;
 
 export class ClusterResourceHandler extends ResourceHandler {

packages/@aws-cdk-testing/framework-integ/test/aws-eks/test/integ.eks-bottlerocket-ng.js.snapshot/asset.a21fb971385f0210c6b1c88a25f1b9986bae4e4e1bca8d4aa818c442e1878ddf/cluster.ts

@@ -7,7 +7,6 @@ import { EksClient, ResourceEvent, ResourceHandler } from './common';
 import { compareLoggingProps } from './compareLogging';
 import { IsCompleteResponse, OnEventResponse } from '../../../custom-resources/lib/provider-framework/types';
 
-
 const MAX_CLUSTER_NAME_LEN = 100;
 
 export class ClusterResourceHandler extends ResourceHandler {

packages/@aws-cdk-testing/framework-integ/test/aws-eks/test/integ.eks-cluster-handlers-vpc.js.snapshot/asset.a21fb971385f0210c6b1c88a25f1b9986bae4e4e1bca8d4aa818c442e1878ddf/cluster.ts

@@ -7,7 +7,6 @@ import { EksClient, ResourceEvent, ResourceHandler } from './common';
 import { compareLoggingProps } from './compareLogging';
 import { IsCompleteResponse, OnEventResponse } from '../../../custom-resources/lib/provider-framework/types';
 
-
 const MAX_CLUSTER_NAME_LEN = 100;
 
 export class ClusterResourceHandler extends ResourceHandler {

packages/@aws-cdk-testing/framework-integ/test/aws-eks/test/integ.eks-cluster-private-endpoint.js.snapshot/asset.a21fb971385f0210c6b1c88a25f1b9986bae4e4e1bca8d4aa818c442e1878ddf/cluster.ts

@@ -7,7 +7,6 @@ import { EksClient, ResourceEvent, ResourceHandler } from './common';
 import { compareLoggingProps } from './compareLogging';
 import { IsCompleteResponse, OnEventResponse } from '../../../custom-resources/lib/provider-framework/types';
 
-
 const MAX_CLUSTER_NAME_LEN = 100;
 
 export class ClusterResourceHandler extends ResourceHandler {

packages/@aws-cdk-testing/framework-integ/test/aws-eks/test/integ.eks-cluster-private-endpoint.ts

@@ -42,7 +42,6 @@ class EksClusterStack extends Stack {
   }
 }
 
-
 const app = new App();
 
 const stack = new EksClusterStack(app, 'aws-cdk-eks-cluster-private-endpoint-test');