feat(codedeploy): throw ValidationErrors instead of untyped Errors (#33853)

### Issue # (if applicable)

Relates to #32569

### Reason for this change

untyped Errors are not recommended

### Description of changes

ValidationErrors everywhere

### Describe any new or updated permissions being added

None

### Description of how you validated changes

Existing tests. Exemptions granted as this is a refactor of existing code.

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

Author: kaizencc

packages/aws-cdk-lib/.eslintrc.js

@@ -34,13 +34,15 @@ const enableNoThrowDefaultErrorIn = [
   'aws-batch',
   'aws-chatbot',
   'aws-certificatemanager',
-  'aws-codebuild',
-  'aws-cognito',
   'aws-cloudfront',
   'aws-cloudfront-origins',
   'aws-cloudtrail',
   'aws-cloudwatch',
   'aws-cloudwatch-actions',
+  'aws-codeartifact',
+  'aws-codebuild',
+  'aws-cognito',
+  'aws-codedeploy',
   'aws-ecr',
   'aws-elasticloadbalancing',
   'aws-elasticloadbalancingv2',

packages/aws-cdk-lib/aws-codedeploy/lib/base-deployment-config.ts

@@ -3,7 +3,7 @@ import { CfnDeploymentConfig } from './codedeploy.generated';
 import { MinimumHealthyHosts, MinimumHealthyHostsPerZone } from './host-health-config';
 import { arnForDeploymentConfig, validateName } from './private/utils';
 import { TrafficRouting } from './traffic-routing-config';
-import { ArnFormat, Duration, Resource, Stack } from '../../core';
+import { ArnFormat, Duration, Resource, Stack, ValidationError } from '../../core';
 
 /**
  * The base class for ServerDeploymentConfig, EcsDeploymentConfig,
@@ -174,12 +174,12 @@ export abstract class BaseDeploymentConfig extends Resource implements IBaseDepl
 
     // Traffic routing is not applicable to Server-based deployment configs
     if (props?.trafficRouting && (props?.computePlatform === undefined || props?.computePlatform === ComputePlatform.SERVER)) {
-      throw new Error('Traffic routing config must not be specified for a Server-base deployment configuration');
+      throw new ValidationError('Traffic routing config must not be specified for a Server-base deployment configuration', this);
     }
 
     // Minimum healthy hosts is only applicable to Server-based deployment configs
     if (props?.minimumHealthyHosts && props?.computePlatform && props?.computePlatform !== ComputePlatform.SERVER) {
-      throw new Error('Minimum healthy hosts config must only be specified for a Server-base deployment configuration');
+      throw new ValidationError('Minimum healthy hosts config must only be specified for a Server-base deployment configuration', this);
     }
 
     if (props?.zonalConfig) {
@@ -217,7 +217,7 @@ export abstract class BaseDeploymentConfig extends Resource implements IBaseDepl
   private validateMinimumDuration(duration: Duration, name: string) {
     const milliseconds = duration.toMilliseconds();
     if (milliseconds > 0 && milliseconds < 1000) {
-      throw new Error(`${name} must be greater than or equal to 1 second or be equal to 0, got ${milliseconds}ms`);
+      throw new ValidationError(`${name} must be greater than or equal to 1 second or be equal to 0, got ${milliseconds}ms`, this);
     }
   }
 }

packages/aws-cdk-lib/aws-codedeploy/lib/ecs/deployment-group.ts

@@ -6,6 +6,7 @@ import * as ecs from '../../../aws-ecs';
 import * as elbv2 from '../../../aws-elasticloadbalancingv2';
 import * as iam from '../../../aws-iam';
 import * as cdk from '../../../core';
+import { ValidationError } from '../../../core';
 import { addConstructMetadata, MethodMetadata } from '../../../core/lib/metadata-resource';
 import { CODEDEPLOY_REMOVE_ALARMS_FROM_DEPLOYMENT_GROUP } from '../../../cx-api';
 import { CfnDeploymentGroup } from '../codedeploy.generated';
@@ -239,15 +240,11 @@ export class EcsDeploymentGroup extends DeploymentGroupBase implements IEcsDeplo
       const cfnSvc = (props.service as ecs.BaseService).node.defaultChild as ecs.CfnService;
       if (cfnSvc.deploymentController === undefined ||
         (cfnSvc.deploymentController! as ecs.CfnService.DeploymentControllerProperty).type !== ecs.DeploymentControllerType.CODE_DEPLOY) {
-        throw new Error(
-          'The ECS service associated with the deployment group must use the CODE_DEPLOY deployment controller type',
-        );
+        throw new ValidationError('The ECS service associated with the deployment group must use the CODE_DEPLOY deployment controller type', this);
       }
 
       if (cfnSvc.taskDefinition !== (props.service as ecs.BaseService).taskDefinition.family) {
-        throw new Error(
-          'The ECS service associated with the deployment group must specify the task definition using the task definition family name only. Otherwise, the task definition cannot be updated in the stack',
-        );
+        throw new ValidationError('The ECS service associated with the deployment group must specify the task definition using the task definition family name only. Otherwise, the task definition cannot be updated in the stack', this);
       }
     }
 
@@ -278,7 +275,7 @@ export class EcsDeploymentGroup extends DeploymentGroupBase implements IEcsDeplo
           ignoreAlarmConfiguration: props.ignoreAlarmConfiguration,
         }),
       }),
-      autoRollbackConfiguration: cdk.Lazy.any({ produce: () => renderAutoRollbackConfiguration(this.alarms, props.autoRollback) }),
+      autoRollbackConfiguration: cdk.Lazy.any({ produce: () => renderAutoRollbackConfiguration(this, this.alarms, props.autoRollback) }),
     });
 
     this._setNameAndArn(resource, this.application);

packages/aws-cdk-lib/aws-codedeploy/lib/host-health-config.ts

@@ -1,4 +1,5 @@
 import { CfnDeploymentConfig } from './codedeploy.generated';
+import { UnscopedValidationError } from '../../core';
 
 /**
  * Minimum number of healthy hosts for a server deployment.
@@ -60,7 +61,7 @@ export class MinimumHealthyHostsPerZone {
 
   private constructor(private readonly json: CfnDeploymentConfig.MinimumHealthyHostsProperty) {
     if (!Number.isInteger(json.value)) {
-      throw new Error(`The percentage or count value of minimumHealthyHostsPerZone must be an integer, got: ${json.value}`);
+      throw new UnscopedValidationError(`The percentage or count value of minimumHealthyHostsPerZone must be an integer, got: ${json.value}`);
     }
   }
 

packages/aws-cdk-lib/aws-codedeploy/lib/lambda/custom-deployment-config.ts

@@ -1,6 +1,6 @@
 import { Construct } from 'constructs';
 import { ILambdaDeploymentConfig } from './deployment-config';
-import { Duration, Names, Resource } from '../../../core';
+import { Duration, Names, Resource, ValidationError } from '../../../core';
 import { addConstructMetadata } from '../../../core/lib/metadata-resource';
 import { AwsCustomResource, AwsCustomResourcePolicy, PhysicalResourceId } from '../../../custom-resources';
 import { arnForDeploymentConfig, validateName } from '../private/utils';
@@ -163,14 +163,14 @@ export class CustomLambdaDeploymentConfig extends Resource implements ILambdaDep
   // Validate the inputs. The percentage/interval limits come from CodeDeploy
   private validateParameters(props: CustomLambdaDeploymentConfigProps): void {
     if ( !(1 <= props.percentage && props.percentage <= 99) ) {
-      throw new Error(
+      throw new ValidationError(
         `Invalid deployment config percentage "${props.percentage.toString()}". \
-        Step percentage must be an integer between 1 and 99.`);
+        Step percentage must be an integer between 1 and 99.`, this);
     }
     if (props.interval.toMinutes() > 2880) {
-      throw new Error(
+      throw new ValidationError(
         `Invalid deployment config interval "${props.interval.toString()}". \
-        Traffic shifting intervals must be positive integers up to 2880 (2 days).`);
+        Traffic shifting intervals must be positive integers up to 2880 (2 days).`, this);
     }
   }
 }

packages/aws-cdk-lib/aws-codedeploy/lib/lambda/deployment-group.ts

@@ -194,7 +194,7 @@ export class LambdaDeploymentGroup extends DeploymentGroupBase implements ILambd
           ignoreAlarmConfiguration: props.ignoreAlarmConfiguration,
         }),
       }),
-      autoRollbackConfiguration: cdk.Lazy.any({ produce: () => renderAutoRollbackConfiguration(this.alarms, props.autoRollback) }),
+      autoRollbackConfiguration: cdk.Lazy.any({ produce: () => renderAutoRollbackConfiguration(this, this.alarms, props.autoRollback) }),
     });
 
     this._setNameAndArn(resource, this.application);
@@ -240,7 +240,7 @@ export class LambdaDeploymentGroup extends DeploymentGroupBase implements ILambd
   @MethodMetadata()
   public addPreHook(preHook: lambda.IFunction): void {
     if (this.preHook !== undefined) {
-      throw new Error('A pre-hook function is already defined for this deployment group');
+      throw new cdk.ValidationError('A pre-hook function is already defined for this deployment group', this);
     }
     this.preHook = preHook;
     this.grantPutLifecycleEventHookExecutionStatus(this.preHook);
@@ -255,7 +255,7 @@ export class LambdaDeploymentGroup extends DeploymentGroupBase implements ILambd
   @MethodMetadata()
   public addPostHook(postHook: lambda.IFunction): void {
     if (this.postHook !== undefined) {
-      throw new Error('A post-hook function is already defined for this deployment group');
+      throw new cdk.ValidationError('A post-hook function is already defined for this deployment group', this);
     }
     this.postHook = postHook;
     this.grantPutLifecycleEventHookExecutionStatus(this.postHook);

packages/aws-cdk-lib/aws-codedeploy/lib/private/utils.ts

@@ -1,6 +1,7 @@
+import { Construct } from 'constructs';
 import { IPredefinedDeploymentConfig } from './predefined-deployment-config';
 import * as cloudwatch from '../../../aws-cloudwatch';
-import { Token, Stack, ArnFormat, Arn, Fn, Aws, IResource } from '../../../core';
+import { Token, Stack, ArnFormat, Arn, Fn, Aws, IResource, ValidationError } from '../../../core';
 import { IBaseDeploymentConfig } from '../base-deployment-config';
 import { CfnDeploymentGroup } from '../codedeploy.generated';
 import { AutoRollbackConfig } from '../rollback-config';
@@ -95,7 +96,7 @@ enum AutoRollbackEvent {
   DEPLOYMENT_STOP_ON_REQUEST = 'DEPLOYMENT_STOP_ON_REQUEST',
 }
 
-export function renderAutoRollbackConfiguration(alarms: cloudwatch.IAlarm[], autoRollbackConfig: AutoRollbackConfig = {}):
+export function renderAutoRollbackConfiguration(scope: Construct, alarms: cloudwatch.IAlarm[], autoRollbackConfig: AutoRollbackConfig = {}):
 CfnDeploymentGroup.AutoRollbackConfigurationProperty | undefined {
   const events = new Array<string>();
 
@@ -115,9 +116,9 @@ CfnDeploymentGroup.AutoRollbackConfigurationProperty | undefined {
     if (alarms.length > 0) {
       events.push(AutoRollbackEvent.DEPLOYMENT_STOP_ON_ALARM);
     } else if (autoRollbackConfig.deploymentInAlarm === true) {
-      throw new Error(
+      throw new ValidationError(
         "The auto-rollback setting 'deploymentInAlarm' does not have any effect unless you associate " +
-        'at least one CloudWatch alarm with the Deployment Group');
+        'at least one CloudWatch alarm with the Deployment Group', scope);
     }
   }
 

packages/aws-cdk-lib/aws-codedeploy/lib/server/deployment-group.ts

@@ -100,8 +100,7 @@ export class InstanceTagSet {
 
   constructor(...instanceTagGroups: InstanceTagGroup[]) {
     if (instanceTagGroups.length > 3) {
-      throw new Error('An instance tag set can have a maximum of 3 instance tag groups, ' +
-        `but ${instanceTagGroups.length} were provided`);
+      throw new cdk.UnscopedValidationError(`An instance tag set can have a maximum of 3 instance tag groups, but ${instanceTagGroups.length} were provided`);
     }
     this._instanceTagGroups = instanceTagGroups;
   }
@@ -297,7 +296,7 @@ export class ServerDeploymentGroup extends DeploymentGroupBase implements IServe
     this.loadBalancers = props.loadBalancers || (props.loadBalancer ? [props.loadBalancer]: undefined);
 
     if (this.loadBalancers && this.loadBalancers.length === 0) {
-      throw new Error('loadBalancers must be a non-empty array');
+      throw new cdk.ValidationError('loadBalancers must be a non-empty array', this);
     }
 
     for (const asg of this._autoScalingGroups) {
@@ -331,7 +330,7 @@ export class ServerDeploymentGroup extends DeploymentGroupBase implements IServe
           ignoreAlarmConfiguration: props.ignoreAlarmConfiguration,
         }),
       }),
-      autoRollbackConfiguration: cdk.Lazy.any({ produce: () => renderAutoRollbackConfiguration(this.alarms, props.autoRollback) }),
+      autoRollbackConfiguration: cdk.Lazy.any({ produce: () => renderAutoRollbackConfiguration(this, this.alarms, props.autoRollback) }),
       terminationHookEnabled: props.terminationHook,
     });
 
@@ -496,7 +495,7 @@ export class ServerDeploymentGroup extends DeploymentGroupBase implements IServe
               });
             }
           } else {
-            throw new Error('Cannot specify both an empty key and no values for an instance tag filter');
+            throw new cdk.ValidationError('Cannot specify both an empty key and no values for an instance tag filter', this);
           }
         }
       }